Re: [PATCH 2/2] NFSD: add shrinker to reap courtesy clients on low memory condition

Re: [PATCH 2/2] NFSD: add shrinker to reap courtesy clients on low memory condition

[kernel test robot]

Hi Dai,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc2 next-20220826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dai-Ngo/NFSD-memory-shrinker-for-NFSv4-clients/20220827-070241
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e022620b5d056e822e42eb9bc0f24fcb97389d86
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220827/202208271403.SinCnRF0-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8430e1a9491e9b4470a68f989a004b579e37fb73
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dai-Ngo/NFSD-memory-shrinker-for-NFSv4-clients/20220827-070241
        git checkout 8430e1a9491e9b4470a68f989a004b579e37fb73
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from fs/nfsd/trace.c:4:
   In file included from fs/nfsd/trace.h:488:
   In file included from fs/nfsd/state.h:42:
>> fs/nfsd/nfsd.h:513:72: error: expected ';' after return statement
   static inline int nfsd4_init_leases_net(struct nfsd_net *nn) { return 0 };
                                                                          ^
                                                                          ;
   1 error generated.
--
   In file included from fs/nfsd/nfsctl.c:23:
>> fs/nfsd/nfsd.h:513:72: error: expected ';' after return statement
   static inline int nfsd4_init_leases_net(struct nfsd_net *nn) { return 0 };
                                                                          ^
                                                                          ;
>> fs/nfsd/nfsctl.c:1511:2: error: implicit declaration of function 'nfsd4_leases_net_shutdown' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           nfsd4_leases_net_shutdown(nn);
           ^
   fs/nfsd/nfsctl.c:1511:2: note: did you mean 'nfsd4_leases_shutdown'?
   fs/nfsd/nfsd.h:514:20: note: 'nfsd4_leases_shutdown' declared here
   static inline void nfsd4_leases_shutdown(struct nfsd_net *nn) { };
                      ^
   2 errors generated.
--
   In file included from fs/nfsd/export.c:21:
>> fs/nfsd/nfsd.h:513:72: error: expected ';' after return statement
   static inline int nfsd4_init_leases_net(struct nfsd_net *nn) { return 0 };
                                                                          ^
                                                                          ;
   fs/nfsd/export.c:979:17: warning: variable 'inode' set but not used [-Wunused-but-set-variable]
           struct inode            *inode;
                                    ^
   1 warning and 1 error generated.
--
   In file included from fs/nfsd/trace.c:4:
   In file included from fs/nfsd/trace.h:488:
   In file included from fs/nfsd/state.h:42:
>> fs/nfsd/nfsd.h:513:72: error: expected ';' after return statement
   static inline int nfsd4_init_leases_net(struct nfsd_net *nn) { return 0 };
                                                                          ^
                                                                          ;
   In file included from fs/nfsd/trace.c:4:
   In file included from fs/nfsd/trace.h:1407:
   include/trace/define_trace.h:95:10: fatal error: './trace.h' file not found
   #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/define_trace.h:90:32: note: expanded from macro 'TRACE_INCLUDE'
   # define TRACE_INCLUDE(system) __TRACE_INCLUDE(system)
                                  ^~~~~~~~~~~~~~~~~~~~~~~
   include/trace/define_trace.h:87:34: note: expanded from macro '__TRACE_INCLUDE'
   # define __TRACE_INCLUDE(system) __stringify(TRACE_INCLUDE_PATH/system.h)
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
   #define __stringify(x...)       __stringify_1(x)
                                   ^~~~~~~~~~~~~~~~
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
   #define __stringify_1(x...)     #x
                                   ^~
   <scratch space>:56:1: note: expanded from here
   "./trace.h"
   ^~~~~~~~~~~
   2 errors generated.


vim +513 fs/nfsd/nfsd.h

   512	
 > 513	static inline int nfsd4_init_leases_net(struct nfsd_net *nn) { return 0 };
   514	static inline void nfsd4_leases_shutdown(struct nfsd_net *nn) { };
   515	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp