* Re: [PATCH v2 3/3] PCI/PM: Always disable PTM for all devices during suspend
[not found] <20220902233543.390890-4-helgaas@kernel.org>
@ 2022-09-03 4:07 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-09-03 4:07 UTC (permalink / raw)
To: Bjorn Helgaas, Kai-Heng Feng, Rajvi Jingar, Rafael J . Wysocki
Cc: llvm, kbuild-all, Koba Ko, Mika Westerberg, David E . Box,
Sathyanarayanan Kuppuswamy, linux-pci, linux-pm, linux-kernel,
Bjorn Helgaas
Hi Bjorn,
I love your patch! Yet something to improve:
[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on linus/master v6.0-rc3 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bjorn-Helgaas/PCI-PM-Always-disable-PTM-for-all-devices-during-suspend/20220903-073808
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: riscv-randconfig-r042-20220901 (https://download.01.org/0day-ci/archive/20220903/202209031120.PkNnRSt8-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c55b41d5199d2394dd6cdb8f52180d8b81d809d4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/809e1c954b459ee37193c4ab9fa843243fbd7fa9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Bjorn-Helgaas/PCI-PM-Always-disable-PTM-for-all-devices-during-suspend/20220903-073808
git checkout 809e1c954b459ee37193c4ab9fa843243fbd7fa9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/pci/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/pci/pci-driver.c:1350:15: error: no member named 'ptm_enabled' in 'struct pci_dev'
if (pci_dev->ptm_enabled)
~~~~~~~ ^
1 error generated.
vim +1350 drivers/pci/pci-driver.c
1335
1336 static int pci_pm_runtime_resume(struct device *dev)
1337 {
1338 struct pci_dev *pci_dev = to_pci_dev(dev);
1339 const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
1340 pci_power_t prev_state = pci_dev->current_state;
1341 int error = 0;
1342
1343 /*
1344 * Restoring config space is necessary even if the device is not bound
1345 * to a driver because although we left it in D0, it may have gone to
1346 * D3cold when the bridge above it runtime suspended.
1347 */
1348 pci_pm_default_resume_early(pci_dev);
1349
> 1350 if (pci_dev->ptm_enabled)
1351 pci_enable_ptm(pci_dev, NULL);
1352
1353 if (!pci_dev->driver)
1354 return 0;
1355
1356 pci_fixup_device(pci_fixup_resume_early, pci_dev);
1357 pci_pm_default_resume(pci_dev);
1358
1359 if (prev_state == PCI_D3cold)
1360 pci_pm_bridge_power_up_actions(pci_dev);
1361
1362 if (pm && pm->runtime_resume)
1363 error = pm->runtime_resume(dev);
1364
1365 return error;
1366 }
1367
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread