Re: [PATCH 09/13] devdax: Move address_space helpers to the DAX core

Re: [PATCH 09/13] devdax: Move address_space helpers to the DAX core

[kernel test robot]

Hi Dan,

I love your patch! Yet something to improve:

[auto build test ERROR on 1c23f9e627a7b412978b4e852793c5e3c3efc555]

url:    https://github.com/intel-lab-lkp/linux/commits/Dan-Williams/Fix-the-DAX-gup-mistake/20220904-101909
base:   1c23f9e627a7b412978b4e852793c5e3c3efc555
config: arm-randconfig-r026-20220904 (https://download.01.org/0day-ci/archive/20220904/202209041331.SpF1e88q-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c55b41d5199d2394dd6cdb8f52180d8b81d809d4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/fad43bd381f272faee26ae09d0741c48a4dbaa14
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dan-Williams/Fix-the-DAX-gup-mistake/20220904-101909
        git checkout fad43bd381f272faee26ae09d0741c48a4dbaa14
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from mm/filemap.c:15:
>> include/linux/dax.h:312:10: error: use of undeclared identifier 'PMD_SHIFT'
                   return PMD_SHIFT - PAGE_SHIFT;
                          ^
   In file included from mm/filemap.c:25:
   include/linux/mman.h:154:9: warning: division by zero is undefined [-Wdivision-by-zero]
                  _calc_vm_trans(flags, MAP_SYNC,       VM_SYNC      ) |
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/mman.h:132:21: note: expanded from macro '_calc_vm_trans'
      : ((x) & (bit1)) / ((bit1) / (bit2))))
                       ^ ~~~~~~~~~~~~~~~~~
   1 warning and 1 error generated.
--
   In file included from mm/readahead.c:118:
>> include/linux/dax.h:312:10: error: use of undeclared identifier 'PMD_SHIFT'
                   return PMD_SHIFT - PAGE_SHIFT;
                          ^
   1 error generated.


vim +/PMD_SHIFT +312 include/linux/dax.h

   306	
   307	static inline unsigned int pe_order(enum page_entry_size pe_size)
   308	{
   309		if (pe_size == PE_SIZE_PTE)
   310			return PAGE_SHIFT - PAGE_SHIFT;
   311		if (pe_size == PE_SIZE_PMD)
 > 312			return PMD_SHIFT - PAGE_SHIFT;
   313		if (pe_size == PE_SIZE_PUD)
   314			return PUD_SHIFT - PAGE_SHIFT;
   315		return ~0;
   316	}
   317	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp