* Re: [PATCH] phy: Add helpers for setting/clearing bits in paged registers
[not found] <20220904225555.1994290-1-oliver@schinagl.nl>
@ 2022-09-05 1:18 ` kernel test robot
2022-09-09 1:33 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-09-05 1:18 UTC (permalink / raw)
To: Olliver Schinagl, netdev, Andrew Lunn
Cc: llvm, kbuild-all, inux-kernel, Heiner Kallweit, Russell King,
Olliver Schinagl
Hi Olliver,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc4 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Olliver-Schinagl/phy-Add-helpers-for-setting-clearing-bits-in-paged-registers/20220905-070318
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7e18e42e4b280c85b76967a9106a13ca61c16179
config: hexagon-randconfig-r045-20220905 (https://download.01.org/0day-ci/archive/20220905/202209050910.t87wLY38-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c55b41d5199d2394dd6cdb8f52180d8b81d809d4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/342260cb7603ad567f4799836ad4ed390ccedf2a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Olliver-Schinagl/phy-Add-helpers-for-setting-clearing-bits-in-paged-registers/20220905-070318
git checkout 342260cb7603ad567f4799836ad4ed390ccedf2a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/phy/microchip/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/phy/microchip/lan966x_serdes.c:7:
>> include/linux/phy.h:1275:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return phy_modify_paged(phydev, page, regnum, 0, val);
^
include/linux/phy.h:1275:9: note: did you mean 'phy_modify_changed'?
include/linux/phy.h:1142:5: note: 'phy_modify_changed' declared here
int phy_modify_changed(struct phy_device *phydev, u32 regnum, u16 mask,
^
include/linux/phy.h:1288:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return phy_modify_paged(phydev, page, regnum, val, 0);
^
include/linux/phy.h:1447:5: error: conflicting types for 'phy_modify_paged'
int phy_modify_paged(struct phy_device *phydev, int page, u32 regnum,
^
include/linux/phy.h:1275:9: note: previous implicit declaration is here
return phy_modify_paged(phydev, page, regnum, 0, val);
^
3 errors generated.
vim +/phy_modify_paged +1275 include/linux/phy.h
1264
1265 /**
1266 * phy_set_bits_paged - Convenience function for setting bits in a paged register
1267 * @phydev: the phy_device struct
1268 * @page: the page for the phy
1269 * @regnum: register number to write
1270 * @val: bits to set
1271 */
1272 static inline int phy_set_bits_paged(struct phy_device *phydev, int page,
1273 u32 regnum, u16 val)
1274 {
> 1275 return phy_modify_paged(phydev, page, regnum, 0, val);
1276 }
1277
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] phy: Add helpers for setting/clearing bits in paged registers
[not found] <20220904225555.1994290-1-oliver@schinagl.nl>
2022-09-05 1:18 ` [PATCH] phy: Add helpers for setting/clearing bits in paged registers kernel test robot
@ 2022-09-09 1:33 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-09-09 1:33 UTC (permalink / raw)
To: Olliver Schinagl, netdev, Andrew Lunn
Cc: llvm, kbuild-all, inux-kernel, Heiner Kallweit, Russell King,
Olliver Schinagl
Hi Olliver,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.0-rc4 next-20220908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Olliver-Schinagl/phy-Add-helpers-for-setting-clearing-bits-in-paged-registers/20220905-070318
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7e18e42e4b280c85b76967a9106a13ca61c16179
config: arm64-randconfig-r016-20220907 (https://download.01.org/0day-ci/archive/20220909/202209090938.3xBYyNyf-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/342260cb7603ad567f4799836ad4ed390ccedf2a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Olliver-Schinagl/phy-Add-helpers-for-setting-clearing-bits-in-paged-registers/20220905-070318
git checkout 342260cb7603ad567f4799836ad4ed390ccedf2a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/stmicro/stmmac/enh_desc.c:11:
In file included from include/linux/stmmac.h:16:
include/linux/phy.h:1275:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return phy_modify_paged(phydev, page, regnum, 0, val);
^
include/linux/phy.h:1275:9: note: did you mean 'phy_modify_changed'?
include/linux/phy.h:1142:5: note: 'phy_modify_changed' declared here
int phy_modify_changed(struct phy_device *phydev, u32 regnum, u16 mask,
^
include/linux/phy.h:1288:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return phy_modify_paged(phydev, page, regnum, val, 0);
^
include/linux/phy.h:1447:5: error: conflicting types for 'phy_modify_paged'
int phy_modify_paged(struct phy_device *phydev, int page, u32 regnum,
^
include/linux/phy.h:1275:9: note: previous implicit declaration is here
return phy_modify_paged(phydev, page, regnum, 0, val);
^
In file included from drivers/net/ethernet/stmicro/stmmac/enh_desc.c:13:
>> drivers/net/ethernet/stmicro/stmmac/descs_com.h:39:26: warning: implicit conversion from 'unsigned long' to '__u32' (aka 'unsigned int') changes value from 18446744073707454463 to 4292870143 [-Wconstant-conversion]
p->des0 &= cpu_to_le32(~ETDES0_END_RING);
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/big_endian.h:34:53: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
~~~~~~~~~~^~~
include/uapi/linux/swab.h:120:12: note: expanded from macro '__swab32'
__fswab32(x))
~~~~~~~~~ ^
In file included from drivers/net/ethernet/stmicro/stmmac/enh_desc.c:13:
drivers/net/ethernet/stmicro/stmmac/descs_com.h:73:26: warning: implicit conversion from 'unsigned long' to '__u32' (aka 'unsigned int') changes value from 18446744073675997183 to 4261412863 [-Wconstant-conversion]
p->des1 &= cpu_to_le32(~TDES1_END_RING);
~~~~~~~~~~~~^~~~~~~~~~~~~~~~
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/big_endian.h:34:53: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
~~~~~~~~~~^~~
include/uapi/linux/swab.h:120:12: note: expanded from macro '__swab32'
__fswab32(x))
~~~~~~~~~ ^
2 warnings and 3 errors generated.
--
In file included from drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:11:
In file included from include/linux/stmmac.h:16:
include/linux/phy.h:1275:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return phy_modify_paged(phydev, page, regnum, 0, val);
^
include/linux/phy.h:1275:9: note: did you mean 'phy_modify_changed'?
include/linux/phy.h:1142:5: note: 'phy_modify_changed' declared here
int phy_modify_changed(struct phy_device *phydev, u32 regnum, u16 mask,
^
include/linux/phy.h:1288:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return phy_modify_paged(phydev, page, regnum, val, 0);
^
include/linux/phy.h:1447:5: error: conflicting types for 'phy_modify_paged'
int phy_modify_paged(struct phy_device *phydev, int page, u32 regnum,
^
include/linux/phy.h:1275:9: note: previous implicit declaration is here
return phy_modify_paged(phydev, page, regnum, 0, val);
^
>> drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:541:26: warning: implicit conversion from 'unsigned long' to '__u32' (aka 'unsigned int') changes value from 18446744073675997183 to 4261412863 [-Wconstant-conversion]
p->des3 &= cpu_to_le32(~RDES3_BUFFER2_VALID_ADDR);
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/big_endian.h:34:53: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
~~~~~~~~~~^~~
include/uapi/linux/swab.h:120:12: note: expanded from macro '__swab32'
__fswab32(x))
~~~~~~~~~ ^
1 warning and 3 errors generated.
vim +39 drivers/net/ethernet/stmicro/stmmac/descs_com.h
286a837217204b Giuseppe CAVALLARO 2011-10-18 33
293e4365a1adb1 Giuseppe Cavallaro 2016-02-29 34 static inline void enh_desc_end_tx_desc_on_ring(struct dma_desc *p, int end)
286a837217204b Giuseppe CAVALLARO 2011-10-18 35 {
293e4365a1adb1 Giuseppe Cavallaro 2016-02-29 36 if (end)
f8be0d78be6e7f Michael Weiser 2016-11-14 37 p->des0 |= cpu_to_le32(ETDES0_END_RING);
293e4365a1adb1 Giuseppe Cavallaro 2016-02-29 38 else
f8be0d78be6e7f Michael Weiser 2016-11-14 @39 p->des0 &= cpu_to_le32(~ETDES0_END_RING);
286a837217204b Giuseppe CAVALLARO 2011-10-18 40 }
286a837217204b Giuseppe CAVALLARO 2011-10-18 41
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread