From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: kernel test robot <lkp@intel.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-gpio@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [linusw-pinctrl:devel 26/32] drivers/pinctrl/freescale/pinctrl-imx.c:260:9: error: call to undeclared function 'pinmux_generic_get_function'; ISO C99 and later do not support implicit function declarations
Date: Mon, 5 Sep 2022 15:30:40 +0200 [thread overview]
Message-ID: <20220905133040.GB6496@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <CACRpkdbfHG3r1wtN3Gne-XX0Zg2qyFSgH4yR3ctauABY4u-XJw@mail.gmail.com>
On Mon, Sep 05, 2022 at 02:36:21PM +0200, Linus Walleij wrote:
> On Mon, Sep 5, 2022 at 12:25 AM kernel test robot <lkp@intel.com> wrote:
> > >> drivers/pinctrl/freescale/pinctrl-imx.c:288:23: error: use of undeclared identifier 'pinmux_generic_get_function_name'; did you mean 'pinmux_generic_free_functions'?
> > .get_function_name = pinmux_generic_get_function_name,
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > pinmux_generic_free_functions
>
> I don't understand this at all, tried to look at it.
>
> Francesco, do you have ideas?
Maybe the reason is that before my change the dependency was on
ARCH_MXC that cannot be compiled in test, while SOC_IMX8M dependency is
`depends on ARCH_MXC || COMPILE_TEST` leading to all of these.
The trivial fix would be to have the pinctrl dependency on SOC_IMX8M &&
ARCH_MXC. I'm not convinced is the smartest way but I think it will
work. What do you think? Should I send a patch or you have a better
idea?
Francesco
next prev parent reply other threads:[~2022-09-05 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 22:25 [linusw-pinctrl:devel 26/32] drivers/pinctrl/freescale/pinctrl-imx.c:260:9: error: call to undeclared function 'pinmux_generic_get_function'; ISO C99 and later do not support implicit function declarations kernel test robot
2022-09-05 12:36 ` Linus Walleij
2022-09-05 13:30 ` Francesco Dolcini [this message]
2022-09-05 13:37 ` Linus Walleij
2022-09-05 13:53 ` Arnd Bergmann
2022-09-05 21:20 ` Linus Walleij
2022-09-05 21:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905133040.GB6496@francesco-nb.int.toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=festevam@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).