From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4F0367 for ; Sun, 18 Sep 2022 04:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663475600; x=1695011600; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YFsGHYQm8fWHF/Mh2opqm57tS+b/OEtqHzuBxfwojsw=; b=bo7QXWnQt6anpyxLoe8cppy6NUzBzNvCxKWEVGGAMk0B43oTyn5v+syQ qYm45COKsM9T8I+v+m5u1VtuTD3Z7jN19N1kbv8EiYT665EsMI/+0Kb1u d3Oi+ghFXu21iKewx8joaDL4xMXEaP2hcAqCvDoIKbYzkzCHdT521Yu+L kxL7oTN0Lm8n6XIDkuvqGjeqC3KYS6g7J4PC35Se9cFC93/FqVQkplvkT uUKkwNCytApWatD1h5Dq1EvBlXNuLvR/NHa/+hcMSQsDm61UNp6X5OK0b kP+s31n3fPd8kHB+g/Bukd++FCkh8cSqSk+AcIjk8w5cul6NZMAf1fMo0 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10473"; a="300573627" X-IronPort-AV: E=Sophos;i="5.93,323,1654585200"; d="scan'208";a="300573627" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2022 21:33:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,323,1654585200"; d="scan'208";a="569261809" Received: from lkp-server01.sh.intel.com (HELO c0a60f19fe7e) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 17 Sep 2022 21:33:17 -0700 Received: from kbuild by c0a60f19fe7e with local (Exim 4.96) (envelope-from ) id 1oZlzY-0000sX-2I; Sun, 18 Sep 2022 04:33:16 +0000 Date: Sun, 18 Sep 2022 12:32:40 +0800 From: kernel test robot To: Jingyu Wang , sudeep.holla@arm.com, cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Jingyu Wang Subject: Re: [PATCH] firmware: arm_scmi: remove unnecessary 'NULL' values from pointer Message-ID: <202209181214.kSFKDUG9-lkp@intel.com> References: <20220918021410.17369-1-jingyuwang_vip@163.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220918021410.17369-1-jingyuwang_vip@163.com> Hi Jingyu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on d5538ab91d3a9a237805be6f8c6c272af2987995] url: https://github.com/intel-lab-lkp/linux/commits/Jingyu-Wang/firmware-arm_scmi-remove-unnecessary-NULL-values-from-pointer/20220918-101734 base: d5538ab91d3a9a237805be6f8c6c272af2987995 config: riscv-randconfig-r042-20220918 (https://download.01.org/0day-ci/archive/20220918/202209181214.kSFKDUG9-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/7fd368bb28e43ed330ef1e678986e3ef1fbc4295 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jingyu-Wang/firmware-arm_scmi-remove-unnecessary-NULL-values-from-pointer/20220918-101734 git checkout 7fd368bb28e43ed330ef1e678986e3ef1fbc4295 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/firmware/arm_scmi/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/firmware/arm_scmi/perf.c:762:2: warning: variable 'rep' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~~~~~ drivers/firmware/arm_scmi/perf.c:766:9: note: uninitialized use occurs here return rep; ^~~ >> drivers/firmware/arm_scmi/perf.c:751:7: warning: variable 'rep' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (sizeof(*p) != payld_sz) ^~~~~~~~~~~~~~~~~~~~~~ drivers/firmware/arm_scmi/perf.c:766:9: note: uninitialized use occurs here return rep; ^~~ drivers/firmware/arm_scmi/perf.c:751:3: note: remove the 'if' if its condition is always false if (sizeof(*p) != payld_sz) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/firmware/arm_scmi/perf.c:734:7: warning: variable 'rep' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (sizeof(*p) != payld_sz) ^~~~~~~~~~~~~~~~~~~~~~ drivers/firmware/arm_scmi/perf.c:766:9: note: uninitialized use occurs here return rep; ^~~ drivers/firmware/arm_scmi/perf.c:734:3: note: remove the 'if' if its condition is always false if (sizeof(*p) != payld_sz) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/firmware/arm_scmi/perf.c:726:11: note: initialize the variable 'rep' to silence this warning void *rep; ^ = NULL 3 warnings generated. vim +/rep +762 drivers/firmware/arm_scmi/perf.c fb5086dc474618 Cristian Marussi 2020-07-01 720 3cb8c95f4b3055 Cristian Marussi 2021-03-16 721 static void *scmi_perf_fill_custom_report(const struct scmi_protocol_handle *ph, 72a5eb9d9c319c Cristian Marussi 2020-07-10 722 u8 evt_id, ktime_t timestamp, fb5086dc474618 Cristian Marussi 2020-07-01 723 const void *payld, size_t payld_sz, fb5086dc474618 Cristian Marussi 2020-07-01 724 void *report, u32 *src_id) fb5086dc474618 Cristian Marussi 2020-07-01 725 { 7fd368bb28e43e Jingyu Wang 2022-09-18 726 void *rep; fb5086dc474618 Cristian Marussi 2020-07-01 727 fb5086dc474618 Cristian Marussi 2020-07-01 728 switch (evt_id) { fb5086dc474618 Cristian Marussi 2020-07-01 729 case SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED: fb5086dc474618 Cristian Marussi 2020-07-01 730 { fb5086dc474618 Cristian Marussi 2020-07-01 731 const struct scmi_perf_limits_notify_payld *p = payld; fb5086dc474618 Cristian Marussi 2020-07-01 732 struct scmi_perf_limits_report *r = report; fb5086dc474618 Cristian Marussi 2020-07-01 733 fb5086dc474618 Cristian Marussi 2020-07-01 734 if (sizeof(*p) != payld_sz) fb5086dc474618 Cristian Marussi 2020-07-01 735 break; fb5086dc474618 Cristian Marussi 2020-07-01 736 fb5086dc474618 Cristian Marussi 2020-07-01 737 r->timestamp = timestamp; fb5086dc474618 Cristian Marussi 2020-07-01 738 r->agent_id = le32_to_cpu(p->agent_id); fb5086dc474618 Cristian Marussi 2020-07-01 739 r->domain_id = le32_to_cpu(p->domain_id); fb5086dc474618 Cristian Marussi 2020-07-01 740 r->range_max = le32_to_cpu(p->range_max); fb5086dc474618 Cristian Marussi 2020-07-01 741 r->range_min = le32_to_cpu(p->range_min); fb5086dc474618 Cristian Marussi 2020-07-01 742 *src_id = r->domain_id; fb5086dc474618 Cristian Marussi 2020-07-01 743 rep = r; fb5086dc474618 Cristian Marussi 2020-07-01 744 break; fb5086dc474618 Cristian Marussi 2020-07-01 745 } fb5086dc474618 Cristian Marussi 2020-07-01 746 case SCMI_EVENT_PERFORMANCE_LEVEL_CHANGED: fb5086dc474618 Cristian Marussi 2020-07-01 747 { fb5086dc474618 Cristian Marussi 2020-07-01 748 const struct scmi_perf_level_notify_payld *p = payld; fb5086dc474618 Cristian Marussi 2020-07-01 749 struct scmi_perf_level_report *r = report; fb5086dc474618 Cristian Marussi 2020-07-01 750 fb5086dc474618 Cristian Marussi 2020-07-01 @751 if (sizeof(*p) != payld_sz) fb5086dc474618 Cristian Marussi 2020-07-01 752 break; fb5086dc474618 Cristian Marussi 2020-07-01 753 fb5086dc474618 Cristian Marussi 2020-07-01 754 r->timestamp = timestamp; fb5086dc474618 Cristian Marussi 2020-07-01 755 r->agent_id = le32_to_cpu(p->agent_id); fb5086dc474618 Cristian Marussi 2020-07-01 756 r->domain_id = le32_to_cpu(p->domain_id); fb5086dc474618 Cristian Marussi 2020-07-01 757 r->performance_level = le32_to_cpu(p->performance_level); fb5086dc474618 Cristian Marussi 2020-07-01 758 *src_id = r->domain_id; fb5086dc474618 Cristian Marussi 2020-07-01 759 rep = r; fb5086dc474618 Cristian Marussi 2020-07-01 760 break; fb5086dc474618 Cristian Marussi 2020-07-01 761 } fb5086dc474618 Cristian Marussi 2020-07-01 @762 default: fb5086dc474618 Cristian Marussi 2020-07-01 763 break; fb5086dc474618 Cristian Marussi 2020-07-01 764 } fb5086dc474618 Cristian Marussi 2020-07-01 765 fb5086dc474618 Cristian Marussi 2020-07-01 766 return rep; fb5086dc474618 Cristian Marussi 2020-07-01 767 } fb5086dc474618 Cristian Marussi 2020-07-01 768 -- 0-DAY CI Kernel Test Service https://01.org/lkp