From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4BD9320E; Fri, 28 Oct 2022 18:14:34 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id a5so3959653qkl.6; Fri, 28 Oct 2022 11:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=mm2xmltH5cssbfoG7DhNPzMHrojXBex0FsFFvjiLnbA=; b=Xh0pirw8ScVQtoFuI5mkHbYhfJdG7ft40xss/CBCZTY9wiS2Dig2U2910H0byfIZUd 0Kk/lZRwJex/UFE00dvJ99kwvcEd4TQlXXQoRP5NZO4Ws+4B5e8zJXd/WgYFgSXOf9xx cGQ4sK19LeEjLg9/HBOBE663TkQx/TypJrlDJbw6kEzvnc0tNd/fZDzqcisL/bWD1Pa8 16c9AAY1qloOMzLecG7Fgs3vMVFDevT5Sd2Oh8ycPtM4BRU8KCPcmdWekodHqhSEoRRK He4NDIIyCbDIZLQ7pz++5iHz4zk9Bbe0W4SJIz7khjQZsk7IoNt1KFX/zgpd8RZ/xM99 O9+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mm2xmltH5cssbfoG7DhNPzMHrojXBex0FsFFvjiLnbA=; b=NpGqlp2hbv25w165+nHzlbUxIL58KTPqjB6jQ+2gd5oGFAI4YQk4L/CLkrMyIn5EMR fyQfBKRzHPJKkT1YxKInNlAL2+glM7DbV5wxxTIsaJMoeZcr4LvEJuwoigvwlMWEgQ9z gFVMBje2l4OR4NZvaojZSTQS6mdiBGHL+JdxapCTttJMsYAUlyaYOcaiAB9/Gm2kDXTS 6L2T1ITRE4iPjaQ7gynsADEE8SaxcICEv9WoTozP8PTwjjwIewkz1OH94rHu7bAB//0T QTCHju8N2Ge0dB26z7YmrjRwedZsQDSwgXxZgHC15SCs3DU2HEgN7E7KQfMP7AjCxWL7 ir4g== X-Gm-Message-State: ACrzQf3wCyds8e6h3cg9mCFzI2WXW7lSsqe83dZAL0iHMINFepoqiM1D GgvQ3gH/ItPFyHYBUwqnsJY= X-Google-Smtp-Source: AMsMyM5PIYaZ3lwRrrkaNIKK5fx3FY37HHCsIo+hdulqZccPAIrDzgZN3BrmAexxzlNsEoFwwcXjHg== X-Received: by 2002:a05:620a:404c:b0:6da:ecec:a072 with SMTP id i12-20020a05620a404c00b006daececa072mr446116qko.358.1666980873506; Fri, 28 Oct 2022 11:14:33 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y27-20020a37f61b000000b006cf19068261sm3271027qkj.116.2022.10.28.11.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 11:14:32 -0700 (PDT) Sender: Guenter Roeck Date: Fri, 28 Oct 2022 11:14:30 -0700 From: Guenter Roeck To: Nathan Chancellor Cc: Jean Delvare , Nick Desaulniers , Tom Rix , Quan Nguyen , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH -next v2] hwmon: (smpro-hwmon) Improve switch statments in smpro_is_visible() Message-ID: <20221028181430.GA2079477@roeck-us.net> References: <20221027231611.3824800-1-nathan@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027231611.3824800-1-nathan@kernel.org> On Thu, Oct 27, 2022 at 04:16:12PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/hwmon/smpro-hwmon.c:378:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > default: > ^ > drivers/hwmon/smpro-hwmon.c:378:2: note: insert 'break;' to avoid fall-through > default: > ^ > break; > 1 error generated. > > Clang is a little more pedantic than GCC, which does not warn when > falling through to a case that is just break or return. Clang's version > is more in line with the kernel's own stance in deprecated.rst, which > states that all switch/case blocks must end in either break, > fallthrough, continue, goto, or return. > > Add the missing break to silence the warning. Additionally, adjust the > indentation of a break and add a default case to the inner switch > statement. > > Fixes: a87456864cbb ("hwmon: Add Ampere's Altra smpro-hwmon driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/1751 > Signed-off-by: Nathan Chancellor Applied. Thanks, Guenter > --- > > v2: > > * Add missing default case to inner switch statement (Guenter) > * Fix indentation of break in inner switch statement (Guenter) > * Reword commit message to include these changes > > v1: https://lore.kernel.org/20221027195238.1789586-1-nathan@kernel.org/ > > drivers/hwmon/smpro-hwmon.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > > base-commit: 0ffb687b6508c36a17b99bdaf014b38532404182 > > diff --git a/drivers/hwmon/smpro-hwmon.c b/drivers/hwmon/smpro-hwmon.c > index ee54e21c2c12..a76c49dd8438 100644 > --- a/drivers/hwmon/smpro-hwmon.c > +++ b/drivers/hwmon/smpro-hwmon.c > @@ -373,8 +373,11 @@ static umode_t smpro_is_visible(const void *data, enum hwmon_sensor_types type, > ret = regmap_read(hwmon->regmap, temperature[channel].reg, &value); > if (ret || value == 0xFFFF) > return 0; > - break; > + break; > + default: > + break; > } > + break; > default: > break; > }