From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361E962A for ; Fri, 11 Nov 2022 02:36:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 852D3C433C1; Fri, 11 Nov 2022 02:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668134169; bh=8YAxI68VBNqC4Yhe+Mh1bkW30W4rhNNYDmWMxDWvRMo=; h=From:To:Cc:Subject:Date:From; b=gHlNTSyGphI6KqN/tViuRZp7IjrNyx/raQT+Bk+LTLaRAgTJBxMOyS0ZKOvLlCZOd hsqwl7Jo7gndzO8sePOtHGFMzyLuWWKeFQMLOGvpTie/YYHOkhWi3q6HpI0N+IpBiw WFKZXP6XPjBJUfKWUxjpqvdmYrXvV9Qd0IETQ8XXeiRdjcxUhhUsWl3VsvllQPT6jQ ti7sVQNqzpMKquscmaGsRJLcnzp3HlduRS749sotg38dxL87cPVoIQ+0dvCgSzx8E7 X5Wg+JJzYTxChBjYWM2paGEQnzwU6KMx0NMOdEbPyl61B3E0TKPX7SG6momIKaxcBI ECUrUT35D7B4w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Huckleberry , Dan Carpenter , llvm@lists.linux.dev, Nathan Chancellor , Fabio Estevam , Philipp Zabel , Sasha Levin , airlied@gmail.com, daniel@ffwll.ch, shawnguo@kernel.org, ndesaulniers@google.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.14 1/2] drm/imx: imx-tve: Fix return type of imx_tve_connector_mode_valid Date: Thu, 10 Nov 2022 21:36:04 -0500 Message-Id: <20221111023605.228202-1-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Nathan Huckleberry [ Upstream commit fc007fb815ab5395c3962c09b79a1630b0fbed9c ] The mode_valid field in drm_connector_helper_funcs is expected to be of type: enum drm_mode_status (* mode_valid) (struct drm_connector *connector, struct drm_display_mode *mode); The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of imx_tve_connector_mode_valid should be changed from int to enum drm_mode_status. Reported-by: Dan Carpenter Link: https://github.com/ClangBuiltLinux/linux/issues/1703 Cc: llvm@lists.linux.dev Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor Reviewed-by: Fabio Estevam Reviewed-by: Philipp Zabel Signed-off-by: Philipp Zabel Link: https://patchwork.freedesktop.org/patch/msgid/20220913205544.155106-1-nhuck@google.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/imx/imx-tve.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index c22c3e6e9b7a..c4d67fc54c0b 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -243,8 +243,9 @@ static int imx_tve_connector_get_modes(struct drm_connector *connector) return ret; } -static int imx_tve_connector_mode_valid(struct drm_connector *connector, - struct drm_display_mode *mode) +static enum drm_mode_status +imx_tve_connector_mode_valid(struct drm_connector *connector, + struct drm_display_mode *mode) { struct imx_tve *tve = con_to_tve(connector); unsigned long rate; -- 2.35.1