From: Andrew Morton <akpm@linux-foundation.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev, regressions@lists.linux.dev,
lkft-triage@lists.linaro.org, vishal.moola@gmail.com,
Matthew Wilcox <willy@infradead.org>,
Jann Horn <jannh@google.com>
Subject: Re: next: x86: clang: mm/khugepaged.c:1428:45: error: variable 'pmd' is uninitialized when used here
Date: Thu, 24 Nov 2022 11:33:17 -0800 [thread overview]
Message-ID: <20221124113317.37ca142d58b5e7efecd1facf@linux-foundation.org> (raw)
In-Reply-To: <CA+G9fYtMoRLC0-9hnpw6+fb_i-6jqLNQH83Q90JqyXO7aCJwNw@mail.gmail.com>
On Thu, 24 Nov 2022 21:07:48 +0530 Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> LKFT CI system noticed clang-15 build failures on x86_64 and i386.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/build LLVM=1 LLVM_IAS=1
> ARCH=x86_64 SRCARCH=x86 CROSS_COMPILE=x86_64-linux-gnu-
> 'HOSTCC=sccache clang' 'CC=sccache clang'
> mm/khugepaged.c:1428:45: error: variable 'pmd' is uninitialized when
> used here [-Werror,-Wuninitialized]
> page_table_check_pte_clear_range(mm, addr, pmd);
> ^~~
> mm/khugepaged.c:1415:2: note: variable 'pmd' is declared here
> pmd_t pmd;
> ^
Thanks. Due to "mm/khugepaged: fix GUP-fast interaction by freeing
ptes via mmu_gather".
Jann, I'll just do this for now:
--- a/mm/khugepaged.c~mm-khugepaged-fix-gup-fast-interaction-by-freeing-ptes-via-mmu_gather-fix
+++ a/mm/khugepaged.c
@@ -1431,7 +1431,6 @@ static void collapse_and_free_pmd(struct
*/
if (vma->anon_vma)
lockdep_assert_held_write(&vma->anon_vma->root->rwsem);
- page_table_check_pte_clear_range(mm, addr, pmd);
tlb_gather_mmu(&tlb, mm);
pmd = READ_ONCE(*pmdp);
_
please check.
prev parent reply other threads:[~2022-11-24 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 15:37 next: x86: clang: mm/khugepaged.c:1428:45: error: variable 'pmd' is uninitialized when used here Naresh Kamboju
2022-11-24 19:33 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124113317.37ca142d58b5e7efecd1facf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=llvm@lists.linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=regressions@lists.linux.dev \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox