From: Michael Grzeschik <mgr@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-usb@vger.kernel.org
Subject: Re: [usb:usb-testing 2/23] drivers/usb/gadget/function/uvc_v4l2.c:266:3: warning: unannotated fall-through between switch labels
Date: Tue, 29 Nov 2022 11:19:04 +0100 [thread overview]
Message-ID: <20221129101904.GM18924@pengutronix.de> (raw)
In-Reply-To: <Y4W7yKbiKzK4yKoV@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
On Tue, Nov 29, 2022 at 08:59:04AM +0100, Greg Kroah-Hartman wrote:
>On Tue, Nov 29, 2022 at 08:57:19AM +0100, Greg Kroah-Hartman wrote:
>> On Tue, Nov 29, 2022 at 08:55:43AM +0100, Greg Kroah-Hartman wrote:
>> > On Tue, Nov 29, 2022 at 07:22:43AM +0800, kernel test robot wrote:
>> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
>> > > head: 465d4dd073f72a6348577ed0f7aa4aa00c9264bc
>> > > commit: a6f523ee41bfe7ef71110d4ae556339d0520efdd [2/23] usb: gadget: uvc: add validate and fix function for uvc response
>> >
>> > Michael, I'll drop this commit from my tree now, please fix up and
>> > resend.
>>
>> Nevermind, I fixed it up myself, it was trivial.
>
>And now ignore this, I've dropped it again based on Laurent's review.
>
Did you drop it because of the question why this is a good idea?
If so I will improve the commit message. IMHO it totally makes sense to
have some sort of validation in the uvc gadget.
The version v7 he commented on was not the one you took on the
usb-testing tree.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-29 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 23:22 [usb:usb-testing 2/23] drivers/usb/gadget/function/uvc_v4l2.c:266:3: warning: unannotated fall-through between switch labels kernel test robot
2022-11-29 7:55 ` Greg Kroah-Hartman
2022-11-29 7:57 ` Greg Kroah-Hartman
2022-11-29 7:59 ` Greg Kroah-Hartman
2022-11-29 10:19 ` Michael Grzeschik [this message]
2022-11-29 12:10 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129101904.GM18924@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox