From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Robert Moore <robert.moore@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
Len Brown <lenb@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>, Nathan Chancellor <nathan@kernel.org>,
Linux ACPI Mailing List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPICA Mailing List <devel@acpica.org>,
LLVM Mailing List <llvm@lists.linux.dev>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: [PATCH v1 1/2] ACPI: Silence missing prototype warnings
Date: Fri, 23 Dec 2022 21:24:18 +0700 [thread overview]
Message-ID: <20221223142419.3781410-2-ammar.faizi@intel.com> (raw)
In-Reply-To: <20221223142419.3781410-1-ammar.faizi@intel.com>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Compiling with clang-16:
drivers/acpi/acpi_lpit.c:142:6: error: no previous prototype \
for function 'acpi_init_lpit' [-Werror,-Wmissing-prototypes]
drivers/acpi/ioapic.c:212:6: error: no previous prototype \
for function 'pci_ioapic_remove' [-Werror,-Wmissing-prototypes]
drivers/acpi/ioapic.c:229:5: error: no previous prototype \
for function 'acpi_ioapic_remove' [-Werror,-Wmissing-prototypes]
Include "internal.h" to silence them.
Cc: LLVM Mailing List <llvm@lists.linux.dev>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
drivers/acpi/acpi_lpit.c | 1 +
drivers/acpi/ioapic.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c
index 50540d4d4948..3843d2576d3f 100644
--- a/drivers/acpi/acpi_lpit.c
+++ b/drivers/acpi/acpi_lpit.c
@@ -10,6 +10,7 @@
#include <linux/acpi.h>
#include <asm/msr.h>
#include <asm/tsc.h>
+#include "internal.h"
struct lpit_residency_info {
struct acpi_generic_address gaddr;
diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
index a690c7b18623..6677955b4a8e 100644
--- a/drivers/acpi/ioapic.c
+++ b/drivers/acpi/ioapic.c
@@ -24,6 +24,7 @@
#include <linux/acpi.h>
#include <linux/pci.h>
#include <acpi/acpi.h>
+#include "internal.h"
struct acpi_pci_ioapic {
acpi_handle root_handle;
--
Ammar Faizi
next prev parent reply other threads:[~2022-12-23 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 14:24 [PATCH v1 0/2] clang warning cleanups Ammar Faizi
2022-12-23 14:24 ` Ammar Faizi [this message]
2022-12-30 18:13 ` [PATCH v1 1/2] ACPI: Silence missing prototype warnings Rafael J. Wysocki
2022-12-23 14:24 ` [PATCH v1 2/2] ACPICA: Silence 'unused-but-set variable' warning Ammar Faizi
2022-12-30 18:17 ` Rafael J. Wysocki
2022-12-23 15:33 ` [PATCH v1 0/2] clang warning cleanups Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221223142419.3781410-2-ammar.faizi@intel.com \
--to=ammarfaizi2@gnuweeb.org \
--cc=devel@acpica.org \
--cc=gwml@vger.gnuweeb.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox