From: Christoph Hellwig <hch@lst.de>
To: kernel test robot <lkp@intel.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.dk,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, hch@lst.de,
martin.petersen@oracle.com,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv3 2/2] block: save user max_sectors limit
Date: Wed, 28 Dec 2022 16:51:11 +0100 [thread overview]
Message-ID: <20221228155111.GA388@lst.de> (raw)
In-Reply-To: <202212280931.RDVmPBnX-lkp@intel.com>
On Wed, Dec 28, 2022 at 10:04:16AM +0800, kernel test robot wrote:
> >> block/blk-sysfs.c:254:20: warning: comparison of distinct pointer types ('typeof (max_hw_sectors_kb) *' (aka 'unsigned long *') and 'typeof (2560U >> 1) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types]
Seems like the local max_sectors_kb variable also needs to be turned
into an unsigned int from the current unsigned long.
And btw, while I'm getting philosophical during my early morning
coffee here, I wonder if we need to actually get rid of or at least
bump BLK_DEF_MAX_SECTORS. It's pretty ridiculous for modern devices,
and with CDL support that defintion would also include hard drives
eventually.
next prev parent reply other threads:[~2022-12-28 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221227191009.2277326-2-kbusch@meta.com>
2022-12-28 2:04 ` [PATCHv3 2/2] block: save user max_sectors limit kernel test robot
2022-12-28 15:51 ` Christoph Hellwig [this message]
2022-12-28 16:06 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228155111.GA388@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox