From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 084616FBB for ; Tue, 10 Jan 2023 11:51:45 +0000 (UTC) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 30ABjQic021510; Tue, 10 Jan 2023 05:45:26 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 30ABjNkV021509; Tue, 10 Jan 2023 05:45:23 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 10 Jan 2023 05:45:23 -0600 From: Segher Boessenkool To: Nathan Chancellor Cc: Nick Desaulniers , kernel test robot , linux-kbuild@vger.kernel.org, trix@redhat.com, masahiroy@kernel.org, llvm@lists.linux.dev, npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org, nicolas@fjasle.eu Subject: Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS Message-ID: <20230110114523.GP25951@gate.crashing.org> References: <20221228-drop-qunused-arguments-v1-0-658cbc8fc592@kernel.org> <20221228-drop-qunused-arguments-v1-6-658cbc8fc592@kernel.org> <20230109222337.GM25951@gate.crashing.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i On Mon, Jan 09, 2023 at 05:51:23PM -0700, Nathan Chancellor wrote: > So for this patch, I have > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > warns: > > clang-16: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument] > > The compiler's '-s' flag is a linking option (it is passed along to the > linker directly), which means it does nothing when the linker is not > invoked by the compiler. The kernel builds all .o files with either '-c' > or '-S', which do not run the linker, so '-s' can be safely dropped from > ASFLAGS. > > as a new commit message. Is that sufficient for everyone? If so, I'll > adjust the s390 commit to match, as it is the same exact problem. Almost? -S doesn't write .o files, it writes a .s file. To go from an assembler file (.s, or .S if you want to run the C preprocessor on non-C code for some strange reason, the assembler macro facilities are vastly superior) to an object file is just -c as well. > Alternatively, if '-s' should actually remain around, we could move it > to ldflags-y, which is added in patch 7. However, I assume that nobody > has noticed that it has not been doing its job for a while, so it should > be safe to remove. +1 Segher