Re: [PATCH net-next v3 1/6] net/sched: cls_api: Support hardware miss to tc action

kernel test robot
2023-01-19T15:51:02Z

Hi Paul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/Paul-Blakey/net-sched-cls_api-Support-hardware-miss-to-tc-action/20230119-162743
patch link: https://lore.kernel.org/r/20230119082357.21744-2-paulb%40nvidia.com
patch subject: [PATCH net-next v3 1/6] net/sched: cls_api: Support hardware miss to tc action
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230119/202301192343.MPDnhYo1-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/5c85cf394445e1140823351fdfdbf3e541b9abb9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Paul-Blakey/net-sched-cls_api-Support-hardware-miss-to-tc-action/20230119-162743
git checkout 5c85cf394445e1140823351fdfdbf3e541b9abb9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/sched/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/sched/cls_api.c:3224:6: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
if (err)
^~~
net/sched/cls_api.c:3200:9: note: initialize the variable 'err' to silence this warning
int err;
^
= 0
1 warning generated.

vim +/err +3224 net/sched/cls_api.c

3214
3215 exts->action = action;
3216 exts->police = police;
3217
3218 if (!use_action_miss)
3219 return 0;
3220
3221 #if IS_ENABLED(CONFIG_NET_TC_SKB_EXT)
3222 err = tcf_exts_miss_cookie_base_alloc(exts, tp, handle);
3223 #endif
> 3224 if (err)
3225 goto err_miss_alloc;
3226
3227 return 0;
3228
3229 err_miss_alloc:
3230 tcf_exts_destroy(exts);
3231 return err;
3232 }
3233 EXPORT_SYMBOL(tcf_exts_init_ex);
3234

--
0-DAY CI Kernel Test Service