From: kernel test robot <lkp@intel.com>
To: Vinay Gannevaram <quic_vganneva@quicinc.com>, johannes@sipsolutions.net
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] nl80211: Allow authentication frames and set keys on NAN interface
Date: Sat, 28 Jan 2023 21:15:51 +0800 [thread overview]
Message-ID: <202301282105.N0kd49zG-lkp@intel.com> (raw)
In-Reply-To: <1674845256-4300-1-git-send-email-quic_vganneva@quicinc.com>
Hi Vinay,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v6.2-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Vinay-Gannevaram/nl80211-Allow-authentication-frames-and-set-keys-on-NAN-interface/20230128-145815
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/1674845256-4300-1-git-send-email-quic_vganneva%40quicinc.com
patch subject: [PATCH v2] nl80211: Allow authentication frames and set keys on NAN interface
config: mips-buildonly-randconfig-r005-20230123 (https://download.01.org/0day-ci/archive/20230128/202301282105.N0kd49zG-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/954d2dd8f85ced417476083a99011b8920d68161
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Vinay-Gannevaram/nl80211-Allow-authentication-frames-and-set-keys-on-NAN-interface/20230128-145815
git checkout 954d2dd8f85ced417476083a99011b8920d68161
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash net/wireless/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/wireless/nl80211.c:1555:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
case NL80211_IFTYPE_UNSPECIFIED:
^
net/wireless/nl80211.c:1555:2: note: insert '__attribute__((fallthrough));' to silence this warning
case NL80211_IFTYPE_UNSPECIFIED:
^
__attribute__((fallthrough));
net/wireless/nl80211.c:1555:2: note: insert 'break;' to avoid fall-through
case NL80211_IFTYPE_UNSPECIFIED:
^
break;
net/wireless/nl80211.c:12262:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
net/wireless/nl80211.c:12262:2: note: insert '__attribute__((fallthrough));' to silence this warning
default:
^
__attribute__((fallthrough));
net/wireless/nl80211.c:12262:2: note: insert 'break;' to avoid fall-through
default:
^
break;
net/wireless/nl80211.c:12322:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
net/wireless/nl80211.c:12322:2: note: insert '__attribute__((fallthrough));' to silence this warning
default:
^
__attribute__((fallthrough));
net/wireless/nl80211.c:12322:2: note: insert 'break;' to avoid fall-through
default:
^
break;
net/wireless/nl80211.c:12462:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
net/wireless/nl80211.c:12462:2: note: insert '__attribute__((fallthrough));' to silence this warning
default:
^
__attribute__((fallthrough));
net/wireless/nl80211.c:12462:2: note: insert 'break;' to avoid fall-through
default:
^
break;
4 warnings generated.
vim +1555 net/wireless/nl80211.c
fffd0934b9390f Johannes Berg 2009-07-08 1531
fffd0934b9390f Johannes Berg 2009-07-08 1532 static int nl80211_key_allowed(struct wireless_dev *wdev)
fffd0934b9390f Johannes Berg 2009-07-08 1533 {
fffd0934b9390f Johannes Berg 2009-07-08 1534 ASSERT_WDEV_LOCK(wdev);
fffd0934b9390f Johannes Berg 2009-07-08 1535
fffd0934b9390f Johannes Berg 2009-07-08 1536 switch (wdev->iftype) {
fffd0934b9390f Johannes Berg 2009-07-08 1537 case NL80211_IFTYPE_AP:
fffd0934b9390f Johannes Berg 2009-07-08 1538 case NL80211_IFTYPE_AP_VLAN:
074ac8df9f93f2 Johannes Berg 2010-09-16 1539 case NL80211_IFTYPE_P2P_GO:
ff973af74aa693 Thomas Pedersen 2011-05-03 1540 case NL80211_IFTYPE_MESH_POINT:
fffd0934b9390f Johannes Berg 2009-07-08 1541 break;
fffd0934b9390f Johannes Berg 2009-07-08 1542 case NL80211_IFTYPE_ADHOC:
7b0a0e3c3a8826 Johannes Berg 2022-04-14 1543 if (wdev->u.ibss.current_bss)
7b0a0e3c3a8826 Johannes Berg 2022-04-14 1544 return 0;
7b0a0e3c3a8826 Johannes Berg 2022-04-14 1545 return -ENOLINK;
fffd0934b9390f Johannes Berg 2009-07-08 1546 case NL80211_IFTYPE_STATION:
074ac8df9f93f2 Johannes Berg 2010-09-16 1547 case NL80211_IFTYPE_P2P_CLIENT:
7b0a0e3c3a8826 Johannes Berg 2022-04-14 1548 if (wdev->connected)
7b0a0e3c3a8826 Johannes Berg 2022-04-14 1549 return 0;
fffd0934b9390f Johannes Berg 2009-07-08 1550 return -ENOLINK;
954d2dd8f85ced Vinay Gannevaram 2023-01-28 1551 case NL80211_IFTYPE_NAN:
954d2dd8f85ced Vinay Gannevaram 2023-01-28 1552 if (wiphy_ext_feature_isset(wdev->wiphy,
954d2dd8f85ced Vinay Gannevaram 2023-01-28 1553 NL80211_EXT_FEATURE_SECURE_NAN))
954d2dd8f85ced Vinay Gannevaram 2023-01-28 1554 return 0;
de4fcbadde68e3 Johannes Berg 2014-10-31 @1555 case NL80211_IFTYPE_UNSPECIFIED:
6e0bd6c35b021d Rostislav Lisovy 2014-11-03 1556 case NL80211_IFTYPE_OCB:
de4fcbadde68e3 Johannes Berg 2014-10-31 1557 case NL80211_IFTYPE_MONITOR:
de4fcbadde68e3 Johannes Berg 2014-10-31 1558 case NL80211_IFTYPE_P2P_DEVICE:
de4fcbadde68e3 Johannes Berg 2014-10-31 1559 case NL80211_IFTYPE_WDS:
de4fcbadde68e3 Johannes Berg 2014-10-31 1560 case NUM_NL80211_IFTYPES:
fffd0934b9390f Johannes Berg 2009-07-08 1561 return -EINVAL;
fffd0934b9390f Johannes Berg 2009-07-08 1562 }
fffd0934b9390f Johannes Berg 2009-07-08 1563
fffd0934b9390f Johannes Berg 2009-07-08 1564 return 0;
fffd0934b9390f Johannes Berg 2009-07-08 1565 }
fffd0934b9390f Johannes Berg 2009-07-08 1566
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
prev parent reply other threads:[~2023-01-28 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1674845256-4300-1-git-send-email-quic_vganneva@quicinc.com>
2023-01-28 12:44 ` [PATCH v2] nl80211: Allow authentication frames and set keys on NAN interface kernel test robot
2023-01-28 13:15 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301282105.N0kd49zG-lkp@intel.com \
--to=lkp@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_vganneva@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox