From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73715685; Tue, 7 Feb 2023 17:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675792004; x=1707328004; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cvomHj0RShettTKXKbHKv4JtucegQHC6xUsgmmTAmMg=; b=UyFNSXzDb/7qsfhUIey4fPnrv7fbwdxNszxLeRUyrtIy3wNPYkkS4+3A zfWkvoE2kPVzQz2v7iEJgoAoYIifHv3VKJ4el3sllfLa1acrnvbQdkzCc p5d9PvomjyN/I1k6tZ6p90DG+DtDl1Ave0HXENrQhTPaUF0txxN8tqCap 94ZDvG/MZvU+M79qqA7Mebqxs9casmkxKZuRUNL5Ozz6uTTI8OXo2qMIh o4r9ewhToOPXxRvMkkmvlLnuE7u2yzmVXPd2/iV8CKe0GQuA4sSYxbN+5 /O1XFn2OWwGMZ89YG4Fuci2BMZyV8H4MG5dUTnA1fPJJAWEr6m3FIEris A==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="329596462" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="329596462" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 09:46:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="755703035" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="755703035" Received: from lkp-server01.sh.intel.com (HELO 4455601a8d94) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 07 Feb 2023 09:46:25 -0800 Received: from kbuild by 4455601a8d94 with local (Exim 4.96) (envelope-from ) id 1pPS2y-0003kk-0u; Tue, 07 Feb 2023 17:46:24 +0000 Date: Wed, 8 Feb 2023 01:46:17 +0800 From: kernel test robot To: Andy Shevchenko Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH v3 12/12] gpiolib: Clean up headers Message-ID: <202302080102.DkyEbYmt-lkp@intel.com> References: <20230207142952.51844-13-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230207142952.51844-13-andriy.shevchenko@linux.intel.com> Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on brgl/gpio/for-next] [cannot apply to powerpc/next powerpc/fixes soc/for-next linus/master v6.2-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpiolib-remove-empty-asm-gpio-h-files/20230207-223652 base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next patch link: https://lore.kernel.org/r/20230207142952.51844-13-andriy.shevchenko%40linux.intel.com patch subject: [PATCH v3 12/12] gpiolib: Clean up headers config: hexagon-randconfig-r041-20230205 (https://download.01.org/0day-ci/archive/20230208/202302080102.DkyEbYmt-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db0e6591612b53910a1b366863348bdb9d7d2fb1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1b29af54a98628e27cdabe2554fbf29b75a1c18b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/gpiolib-remove-empty-asm-gpio-h-files/20230207-223652 git checkout 1b29af54a98628e27cdabe2554fbf29b75a1c18b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpio/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): In file included from drivers/gpio/gpio-regmap.c:8: In file included from include/linux/gpio/driver.h:6: In file included from include/linux/irqchip/chained_irq.h:10: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __raw_readb(PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ In file included from drivers/gpio/gpio-regmap.c:8: In file included from include/linux/gpio/driver.h:6: In file included from include/linux/irqchip/chained_irq.h:10: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) ^ In file included from drivers/gpio/gpio-regmap.c:8: In file included from include/linux/gpio/driver.h:6: In file included from include/linux/irqchip/chained_irq.h:10: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writeb(value, PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ >> drivers/gpio/gpio-regmap.c:256:33: error: call to undeclared function 'dev_name'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] chip->label = config->label ?: dev_name(config->parent); ^ >> drivers/gpio/gpio-regmap.c:256:30: warning: pointer/integer type mismatch in conditional expression ('const char *' and 'int') [-Wconditional-type-mismatch] chip->label = config->label ?: dev_name(config->parent); ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpio/gpio-regmap.c:329:8: error: call to undeclared function 'devm_add_action_or_reset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] ret = devm_add_action_or_reset(dev, devm_gpio_regmap_unregister, gpio); ^ 7 warnings and 2 errors generated. vim +/dev_name +256 drivers/gpio/gpio-regmap.c ebe363197e525f Michael Walle 2020-05-28 191 ebe363197e525f Michael Walle 2020-05-28 192 /** ebe363197e525f Michael Walle 2020-05-28 193 * gpio_regmap_register() - Register a generic regmap GPIO controller ebe363197e525f Michael Walle 2020-05-28 194 * @config: configuration for gpio_regmap ebe363197e525f Michael Walle 2020-05-28 195 * ebe363197e525f Michael Walle 2020-05-28 196 * Return: A pointer to the registered gpio_regmap or ERR_PTR error value. ebe363197e525f Michael Walle 2020-05-28 197 */ ebe363197e525f Michael Walle 2020-05-28 198 struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config) ebe363197e525f Michael Walle 2020-05-28 199 { ebe363197e525f Michael Walle 2020-05-28 200 struct gpio_regmap *gpio; ebe363197e525f Michael Walle 2020-05-28 201 struct gpio_chip *chip; ebe363197e525f Michael Walle 2020-05-28 202 int ret; ebe363197e525f Michael Walle 2020-05-28 203 ebe363197e525f Michael Walle 2020-05-28 204 if (!config->parent) ebe363197e525f Michael Walle 2020-05-28 205 return ERR_PTR(-EINVAL); ebe363197e525f Michael Walle 2020-05-28 206 ebe363197e525f Michael Walle 2020-05-28 207 if (!config->ngpio) ebe363197e525f Michael Walle 2020-05-28 208 return ERR_PTR(-EINVAL); ebe363197e525f Michael Walle 2020-05-28 209 ebe363197e525f Michael Walle 2020-05-28 210 /* we need at least one */ ebe363197e525f Michael Walle 2020-05-28 211 if (!config->reg_dat_base && !config->reg_set_base) ebe363197e525f Michael Walle 2020-05-28 212 return ERR_PTR(-EINVAL); ebe363197e525f Michael Walle 2020-05-28 213 ebe363197e525f Michael Walle 2020-05-28 214 /* if we have a direction register we need both input and output */ ebe363197e525f Michael Walle 2020-05-28 215 if ((config->reg_dir_out_base || config->reg_dir_in_base) && ebe363197e525f Michael Walle 2020-05-28 216 (!config->reg_dat_base || !config->reg_set_base)) ebe363197e525f Michael Walle 2020-05-28 217 return ERR_PTR(-EINVAL); ebe363197e525f Michael Walle 2020-05-28 218 ebe363197e525f Michael Walle 2020-05-28 219 /* we don't support having both registers simultaneously for now */ ebe363197e525f Michael Walle 2020-05-28 220 if (config->reg_dir_out_base && config->reg_dir_in_base) ebe363197e525f Michael Walle 2020-05-28 221 return ERR_PTR(-EINVAL); ebe363197e525f Michael Walle 2020-05-28 222 ebe363197e525f Michael Walle 2020-05-28 223 gpio = kzalloc(sizeof(*gpio), GFP_KERNEL); ebe363197e525f Michael Walle 2020-05-28 224 if (!gpio) ebe363197e525f Michael Walle 2020-05-28 225 return ERR_PTR(-ENOMEM); ebe363197e525f Michael Walle 2020-05-28 226 ebe363197e525f Michael Walle 2020-05-28 227 gpio->parent = config->parent; 9b3c47f124b607 Michael Walle 2021-06-05 228 gpio->driver_data = config->drvdata; ebe363197e525f Michael Walle 2020-05-28 229 gpio->regmap = config->regmap; ebe363197e525f Michael Walle 2020-05-28 230 gpio->ngpio_per_reg = config->ngpio_per_reg; ebe363197e525f Michael Walle 2020-05-28 231 gpio->reg_stride = config->reg_stride; ebe363197e525f Michael Walle 2020-05-28 232 gpio->reg_mask_xlate = config->reg_mask_xlate; ebe363197e525f Michael Walle 2020-05-28 233 gpio->reg_dat_base = config->reg_dat_base; ebe363197e525f Michael Walle 2020-05-28 234 gpio->reg_set_base = config->reg_set_base; ebe363197e525f Michael Walle 2020-05-28 235 gpio->reg_clr_base = config->reg_clr_base; ebe363197e525f Michael Walle 2020-05-28 236 gpio->reg_dir_in_base = config->reg_dir_in_base; ebe363197e525f Michael Walle 2020-05-28 237 gpio->reg_dir_out_base = config->reg_dir_out_base; ebe363197e525f Michael Walle 2020-05-28 238 ebe363197e525f Michael Walle 2020-05-28 239 /* if not set, assume there is only one register */ ebe363197e525f Michael Walle 2020-05-28 240 if (!gpio->ngpio_per_reg) ebe363197e525f Michael Walle 2020-05-28 241 gpio->ngpio_per_reg = config->ngpio; ebe363197e525f Michael Walle 2020-05-28 242 ebe363197e525f Michael Walle 2020-05-28 243 /* if not set, assume they are consecutive */ ebe363197e525f Michael Walle 2020-05-28 244 if (!gpio->reg_stride) ebe363197e525f Michael Walle 2020-05-28 245 gpio->reg_stride = 1; ebe363197e525f Michael Walle 2020-05-28 246 ebe363197e525f Michael Walle 2020-05-28 247 if (!gpio->reg_mask_xlate) ebe363197e525f Michael Walle 2020-05-28 248 gpio->reg_mask_xlate = gpio_regmap_simple_xlate; ebe363197e525f Michael Walle 2020-05-28 249 ebe363197e525f Michael Walle 2020-05-28 250 chip = &gpio->gpio_chip; ebe363197e525f Michael Walle 2020-05-28 251 chip->parent = config->parent; f21ecad451c9b3 Andy Shevchenko 2021-12-23 252 chip->fwnode = config->fwnode; ebe363197e525f Michael Walle 2020-05-28 253 chip->base = -1; ebe363197e525f Michael Walle 2020-05-28 254 chip->ngpio = config->ngpio; ebe363197e525f Michael Walle 2020-05-28 255 chip->names = config->names; ebe363197e525f Michael Walle 2020-05-28 @256 chip->label = config->label ?: dev_name(config->parent); 297a44f664a8ac Michael Walle 2023-01-05 257 chip->can_sleep = regmap_might_sleep(config->regmap); ebe363197e525f Michael Walle 2020-05-28 258 ebe363197e525f Michael Walle 2020-05-28 259 chip->get = gpio_regmap_get; ebe363197e525f Michael Walle 2020-05-28 260 if (gpio->reg_set_base && gpio->reg_clr_base) ebe363197e525f Michael Walle 2020-05-28 261 chip->set = gpio_regmap_set_with_clear; ebe363197e525f Michael Walle 2020-05-28 262 else if (gpio->reg_set_base) ebe363197e525f Michael Walle 2020-05-28 263 chip->set = gpio_regmap_set; ebe363197e525f Michael Walle 2020-05-28 264 ebe363197e525f Michael Walle 2020-05-28 265 chip->get_direction = gpio_regmap_get_direction; 8978277c229b95 William Breathitt Gray 2022-12-27 266 if (gpio->reg_dir_in_base || gpio->reg_dir_out_base) { ebe363197e525f Michael Walle 2020-05-28 267 chip->direction_input = gpio_regmap_direction_input; ebe363197e525f Michael Walle 2020-05-28 268 chip->direction_output = gpio_regmap_direction_output; ebe363197e525f Michael Walle 2020-05-28 269 } ebe363197e525f Michael Walle 2020-05-28 270 ebe363197e525f Michael Walle 2020-05-28 271 ret = gpiochip_add_data(chip, gpio); ebe363197e525f Michael Walle 2020-05-28 272 if (ret < 0) ebe363197e525f Michael Walle 2020-05-28 273 goto err_free_gpio; ebe363197e525f Michael Walle 2020-05-28 274 ebe363197e525f Michael Walle 2020-05-28 275 if (config->irq_domain) { ebe363197e525f Michael Walle 2020-05-28 276 ret = gpiochip_irqchip_add_domain(chip, config->irq_domain); ebe363197e525f Michael Walle 2020-05-28 277 if (ret) ebe363197e525f Michael Walle 2020-05-28 278 goto err_remove_gpiochip; ebe363197e525f Michael Walle 2020-05-28 279 } ebe363197e525f Michael Walle 2020-05-28 280 ebe363197e525f Michael Walle 2020-05-28 281 return gpio; ebe363197e525f Michael Walle 2020-05-28 282 ebe363197e525f Michael Walle 2020-05-28 283 err_remove_gpiochip: ebe363197e525f Michael Walle 2020-05-28 284 gpiochip_remove(chip); ebe363197e525f Michael Walle 2020-05-28 285 err_free_gpio: ebe363197e525f Michael Walle 2020-05-28 286 kfree(gpio); ebe363197e525f Michael Walle 2020-05-28 287 return ERR_PTR(ret); ebe363197e525f Michael Walle 2020-05-28 288 } ebe363197e525f Michael Walle 2020-05-28 289 EXPORT_SYMBOL_GPL(gpio_regmap_register); ebe363197e525f Michael Walle 2020-05-28 290 ebe363197e525f Michael Walle 2020-05-28 291 /** ebe363197e525f Michael Walle 2020-05-28 292 * gpio_regmap_unregister() - Unregister a generic regmap GPIO controller ebe363197e525f Michael Walle 2020-05-28 293 * @gpio: gpio_regmap device to unregister ebe363197e525f Michael Walle 2020-05-28 294 */ ebe363197e525f Michael Walle 2020-05-28 295 void gpio_regmap_unregister(struct gpio_regmap *gpio) ebe363197e525f Michael Walle 2020-05-28 296 { ebe363197e525f Michael Walle 2020-05-28 297 gpiochip_remove(&gpio->gpio_chip); ebe363197e525f Michael Walle 2020-05-28 298 kfree(gpio); ebe363197e525f Michael Walle 2020-05-28 299 } ebe363197e525f Michael Walle 2020-05-28 300 EXPORT_SYMBOL_GPL(gpio_regmap_unregister); ebe363197e525f Michael Walle 2020-05-28 301 40e568f9c88db8 Matti Vaittinen 2021-06-03 302 static void devm_gpio_regmap_unregister(void *res) ebe363197e525f Michael Walle 2020-05-28 303 { 40e568f9c88db8 Matti Vaittinen 2021-06-03 304 gpio_regmap_unregister(res); ebe363197e525f Michael Walle 2020-05-28 305 } ebe363197e525f Michael Walle 2020-05-28 306 ebe363197e525f Michael Walle 2020-05-28 307 /** ebe363197e525f Michael Walle 2020-05-28 308 * devm_gpio_regmap_register() - resource managed gpio_regmap_register() ebe363197e525f Michael Walle 2020-05-28 309 * @dev: device that is registering this GPIO device ebe363197e525f Michael Walle 2020-05-28 310 * @config: configuration for gpio_regmap ebe363197e525f Michael Walle 2020-05-28 311 * ebe363197e525f Michael Walle 2020-05-28 312 * Managed gpio_regmap_register(). For generic regmap GPIO device registered by ebe363197e525f Michael Walle 2020-05-28 313 * this function, gpio_regmap_unregister() is automatically called on driver ebe363197e525f Michael Walle 2020-05-28 314 * detach. See gpio_regmap_register() for more information. ebe363197e525f Michael Walle 2020-05-28 315 * ebe363197e525f Michael Walle 2020-05-28 316 * Return: A pointer to the registered gpio_regmap or ERR_PTR error value. ebe363197e525f Michael Walle 2020-05-28 317 */ ebe363197e525f Michael Walle 2020-05-28 318 struct gpio_regmap *devm_gpio_regmap_register(struct device *dev, ebe363197e525f Michael Walle 2020-05-28 319 const struct gpio_regmap_config *config) ebe363197e525f Michael Walle 2020-05-28 320 { 40e568f9c88db8 Matti Vaittinen 2021-06-03 321 struct gpio_regmap *gpio; 40e568f9c88db8 Matti Vaittinen 2021-06-03 322 int ret; ebe363197e525f Michael Walle 2020-05-28 323 ebe363197e525f Michael Walle 2020-05-28 324 gpio = gpio_regmap_register(config); 40e568f9c88db8 Matti Vaittinen 2021-06-03 325 40e568f9c88db8 Matti Vaittinen 2021-06-03 326 if (IS_ERR(gpio)) 40e568f9c88db8 Matti Vaittinen 2021-06-03 327 return gpio; 40e568f9c88db8 Matti Vaittinen 2021-06-03 328 40e568f9c88db8 Matti Vaittinen 2021-06-03 @329 ret = devm_add_action_or_reset(dev, devm_gpio_regmap_unregister, gpio); 40e568f9c88db8 Matti Vaittinen 2021-06-03 330 if (ret) 40e568f9c88db8 Matti Vaittinen 2021-06-03 331 return ERR_PTR(ret); ebe363197e525f Michael Walle 2020-05-28 332 ebe363197e525f Michael Walle 2020-05-28 333 return gpio; ebe363197e525f Michael Walle 2020-05-28 334 } ebe363197e525f Michael Walle 2020-05-28 335 EXPORT_SYMBOL_GPL(devm_gpio_regmap_register); ebe363197e525f Michael Walle 2020-05-28 336 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests