* Re: [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault
[not found] <6733f2fac24b674d9f60dc1093de30513c099629.1678212067.git.boris@bur.io>
@ 2023-03-09 7:36 ` kernel test robot
2023-03-09 8:39 ` kernel test robot
2023-03-09 10:43 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-03-09 7:36 UTC (permalink / raw)
To: Boris Burkov; +Cc: llvm, oe-kbuild-all
Hi Boris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kdave/for-next]
[also build test ERROR on linus/master v6.3-rc1 next-20230309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Boris-Burkov/btrfs-fix-dio-continue-after-short-write-due-to-buffer-page-fault/20230308-044956
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link: https://lore.kernel.org/r/6733f2fac24b674d9f60dc1093de30513c099629.1678212067.git.boris%40bur.io
patch subject: [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault
config: riscv-randconfig-r042-20230308 (https://download.01.org/0day-ci/archive/20230309/202303091543.12BtMYMB-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/938364315c6a1c0055382359a2d94d4d069a273c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Boris-Burkov/btrfs-fix-dio-continue-after-short-write-due-to-buffer-page-fault/20230308-044956
git checkout 938364315c6a1c0055382359a2d94d4d069a273c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash fs/btrfs/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303091543.12BtMYMB-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/btrfs/inode.c:7001:12: error: call to undeclared function 'btrfs_alloc_ordered_extent'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
^
>> fs/btrfs/inode.c:7001:10: error: incompatible integer to pointer conversion assigning to 'struct btrfs_ordered_extent *' from 'int' [-Wint-conversion]
ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
vim +/btrfs_alloc_ordered_extent +7001 fs/btrfs/inode.c
6978
6979 static struct extent_map *btrfs_create_dio_extent(struct btrfs_inode *inode,
6980 struct btrfs_dio_data *dio_data,
6981 const u64 start,
6982 const u64 len,
6983 const u64 orig_start,
6984 const u64 block_start,
6985 const u64 block_len,
6986 const u64 orig_block_len,
6987 const u64 ram_bytes,
6988 const int type)
6989 {
6990 struct extent_map *em = NULL;
6991 struct btrfs_ordered_extent *ordered;
6992
6993 if (type != BTRFS_ORDERED_NOCOW) {
6994 em = create_io_em(inode, start, len, orig_start, block_start,
6995 block_len, orig_block_len, ram_bytes,
6996 BTRFS_COMPRESS_NONE, /* compress_type */
6997 type);
6998 if (IS_ERR(em))
6999 goto out;
7000 }
> 7001 ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
7002 block_start, block_len, 0,
7003 (1 << type) |
7004 (1 << BTRFS_ORDERED_DIRECT),
7005 BTRFS_COMPRESS_NONE);
7006 if (IS_ERR(ordered)) {
7007 if (em) {
7008 free_extent_map(em);
7009 btrfs_drop_extent_map_range(inode, start,
7010 start + len - 1, false);
7011 }
7012 em = ERR_PTR(PTR_ERR(ordered));
7013 } else {
7014 ASSERT(!dio_data->ordered);
7015 dio_data->ordered = ordered;
7016 }
7017 out:
7018
7019 return em;
7020 }
7021
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault
[not found] <6733f2fac24b674d9f60dc1093de30513c099629.1678212067.git.boris@bur.io>
2023-03-09 7:36 ` [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault kernel test robot
@ 2023-03-09 8:39 ` kernel test robot
2023-03-09 10:43 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-03-09 8:39 UTC (permalink / raw)
To: Boris Burkov; +Cc: llvm, oe-kbuild-all
Hi Boris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kdave/for-next]
[also build test WARNING on linus/master v6.3-rc1 next-20230309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Boris-Burkov/btrfs-fix-dio-continue-after-short-write-due-to-buffer-page-fault/20230308-044956
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link: https://lore.kernel.org/r/6733f2fac24b674d9f60dc1093de30513c099629.1678212067.git.boris%40bur.io
patch subject: [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault
config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20230309/202303091632.k53VZjyD-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/938364315c6a1c0055382359a2d94d4d069a273c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Boris-Burkov/btrfs-fix-dio-continue-after-short-write-due-to-buffer-page-fault/20230308-044956
git checkout 938364315c6a1c0055382359a2d94d4d069a273c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/btrfs/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303091632.k53VZjyD-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/btrfs/inode.c:7001:12: error: implicit declaration of function 'btrfs_alloc_ordered_extent' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
^
>> fs/btrfs/inode.c:7001:10: warning: incompatible integer to pointer conversion assigning to 'struct btrfs_ordered_extent *' from 'int' [-Wint-conversion]
ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
vim +7001 fs/btrfs/inode.c
6978
6979 static struct extent_map *btrfs_create_dio_extent(struct btrfs_inode *inode,
6980 struct btrfs_dio_data *dio_data,
6981 const u64 start,
6982 const u64 len,
6983 const u64 orig_start,
6984 const u64 block_start,
6985 const u64 block_len,
6986 const u64 orig_block_len,
6987 const u64 ram_bytes,
6988 const int type)
6989 {
6990 struct extent_map *em = NULL;
6991 struct btrfs_ordered_extent *ordered;
6992
6993 if (type != BTRFS_ORDERED_NOCOW) {
6994 em = create_io_em(inode, start, len, orig_start, block_start,
6995 block_len, orig_block_len, ram_bytes,
6996 BTRFS_COMPRESS_NONE, /* compress_type */
6997 type);
6998 if (IS_ERR(em))
6999 goto out;
7000 }
> 7001 ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
7002 block_start, block_len, 0,
7003 (1 << type) |
7004 (1 << BTRFS_ORDERED_DIRECT),
7005 BTRFS_COMPRESS_NONE);
7006 if (IS_ERR(ordered)) {
7007 if (em) {
7008 free_extent_map(em);
7009 btrfs_drop_extent_map_range(inode, start,
7010 start + len - 1, false);
7011 }
7012 em = ERR_PTR(PTR_ERR(ordered));
7013 } else {
7014 ASSERT(!dio_data->ordered);
7015 dio_data->ordered = ordered;
7016 }
7017 out:
7018
7019 return em;
7020 }
7021
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault
[not found] <6733f2fac24b674d9f60dc1093de30513c099629.1678212067.git.boris@bur.io>
2023-03-09 7:36 ` [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault kernel test robot
2023-03-09 8:39 ` kernel test robot
@ 2023-03-09 10:43 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-03-09 10:43 UTC (permalink / raw)
To: Boris Burkov; +Cc: llvm, oe-kbuild-all
Hi Boris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kdave/for-next]
[also build test ERROR on linus/master v6.3-rc1 next-20230309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Boris-Burkov/btrfs-fix-dio-continue-after-short-write-due-to-buffer-page-fault/20230308-044956
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link: https://lore.kernel.org/r/6733f2fac24b674d9f60dc1093de30513c099629.1678212067.git.boris%40bur.io
patch subject: [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault
config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20230309/202303091846.eSPpkHU6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/938364315c6a1c0055382359a2d94d4d069a273c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Boris-Burkov/btrfs-fix-dio-continue-after-short-write-due-to-buffer-page-fault/20230308-044956
git checkout 938364315c6a1c0055382359a2d94d4d069a273c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303091846.eSPpkHU6-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/btrfs/inode.c:7001:12: error: implicit declaration of function 'btrfs_alloc_ordered_extent' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
^
fs/btrfs/inode.c:7001:10: warning: incompatible integer to pointer conversion assigning to 'struct btrfs_ordered_extent *' from 'int' [-Wint-conversion]
ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
vim +/btrfs_alloc_ordered_extent +7001 fs/btrfs/inode.c
6978
6979 static struct extent_map *btrfs_create_dio_extent(struct btrfs_inode *inode,
6980 struct btrfs_dio_data *dio_data,
6981 const u64 start,
6982 const u64 len,
6983 const u64 orig_start,
6984 const u64 block_start,
6985 const u64 block_len,
6986 const u64 orig_block_len,
6987 const u64 ram_bytes,
6988 const int type)
6989 {
6990 struct extent_map *em = NULL;
6991 struct btrfs_ordered_extent *ordered;
6992
6993 if (type != BTRFS_ORDERED_NOCOW) {
6994 em = create_io_em(inode, start, len, orig_start, block_start,
6995 block_len, orig_block_len, ram_bytes,
6996 BTRFS_COMPRESS_NONE, /* compress_type */
6997 type);
6998 if (IS_ERR(em))
6999 goto out;
7000 }
> 7001 ordered = btrfs_alloc_ordered_extent(inode, start, len, len,
7002 block_start, block_len, 0,
7003 (1 << type) |
7004 (1 << BTRFS_ORDERED_DIRECT),
7005 BTRFS_COMPRESS_NONE);
7006 if (IS_ERR(ordered)) {
7007 if (em) {
7008 free_extent_map(em);
7009 btrfs_drop_extent_map_range(inode, start,
7010 start + len - 1, false);
7011 }
7012 em = ERR_PTR(PTR_ERR(ordered));
7013 } else {
7014 ASSERT(!dio_data->ordered);
7015 dio_data->ordered = ordered;
7016 }
7017 out:
7018
7019 return em;
7020 }
7021
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread