* [PATCH] net: cxgb3: remove unused fl_to_qset function
@ 2023-03-19 17:24 Tom Rix
2023-03-19 17:45 ` Horatiu Vultur
2023-03-21 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Tom Rix @ 2023-03-19 17:24 UTC (permalink / raw)
To: rajur, davem, edumazet, kuba, pabeni, nathan, ndesaulniers
Cc: netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function
'fl_to_qset' [-Werror,-Wunused-function]
static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
index 62dfbdd33365..efa7f401529e 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
@@ -166,11 +166,6 @@ static u8 flit_desc_map[] = {
#endif
};
-static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
-{
- return container_of(q, struct sge_qset, fl[qidx]);
-}
-
static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q)
{
return container_of(q, struct sge_qset, rspq);
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: cxgb3: remove unused fl_to_qset function
2023-03-19 17:24 [PATCH] net: cxgb3: remove unused fl_to_qset function Tom Rix
@ 2023-03-19 17:45 ` Horatiu Vultur
2023-03-20 12:29 ` Tom Rix
2023-03-21 3:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 5+ messages in thread
From: Horatiu Vultur @ 2023-03-19 17:45 UTC (permalink / raw)
To: Tom Rix
Cc: rajur, davem, edumazet, kuba, pabeni, nathan, ndesaulniers,
netdev, linux-kernel, llvm
The 03/19/2023 13:24, Tom Rix wrote:
Hi Tom,
>
> clang with W=1 reports
> drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function
> 'fl_to_qset' [-Werror,-Wunused-function]
> static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
> ^
> This function is not used, so remove it.
Don't forget to mention in the subject which tree is targeting this
patch.
Other than that looks OK.
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> index 62dfbdd33365..efa7f401529e 100644
> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = {
> #endif
> };
>
> -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
> -{
> - return container_of(q, struct sge_qset, fl[qidx]);
> -}
> -
> static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q)
> {
> return container_of(q, struct sge_qset, rspq);
> --
> 2.27.0
>
--
/Horatiu
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: cxgb3: remove unused fl_to_qset function
2023-03-19 17:45 ` Horatiu Vultur
@ 2023-03-20 12:29 ` Tom Rix
2023-03-20 13:37 ` Leon Romanovsky
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2023-03-20 12:29 UTC (permalink / raw)
To: Horatiu Vultur
Cc: rajur, davem, edumazet, kuba, pabeni, nathan, ndesaulniers,
netdev, linux-kernel, llvm
On 3/19/23 10:45 AM, Horatiu Vultur wrote:
> The 03/19/2023 13:24, Tom Rix wrote:
>
> Hi Tom,
>
>> clang with W=1 reports
>> drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function
>> 'fl_to_qset' [-Werror,-Wunused-function]
>> static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
>> ^
>> This function is not used, so remove it.
> Don't forget to mention in the subject which tree is targeting this
> patch.
This and all my similar fixes/cleanup are against -next.
What prefix would you like to see ?
Tom
> Other than that looks OK.
>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
>> index 62dfbdd33365..efa7f401529e 100644
>> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
>> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
>> @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = {
>> #endif
>> };
>>
>> -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
>> -{
>> - return container_of(q, struct sge_qset, fl[qidx]);
>> -}
>> -
>> static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q)
>> {
>> return container_of(q, struct sge_qset, rspq);
>> --
>> 2.27.0
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: cxgb3: remove unused fl_to_qset function
2023-03-20 12:29 ` Tom Rix
@ 2023-03-20 13:37 ` Leon Romanovsky
0 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2023-03-20 13:37 UTC (permalink / raw)
To: Tom Rix
Cc: Horatiu Vultur, rajur, davem, edumazet, kuba, pabeni, nathan,
ndesaulniers, netdev, linux-kernel, llvm
On Mon, Mar 20, 2023 at 05:29:51AM -0700, Tom Rix wrote:
>
> On 3/19/23 10:45 AM, Horatiu Vultur wrote:
> > The 03/19/2023 13:24, Tom Rix wrote:
> >
> > Hi Tom,
> >
> > > clang with W=1 reports
> > > drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function
> > > 'fl_to_qset' [-Werror,-Wunused-function]
> > > static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
> > > ^
> > > This function is not used, so remove it.
> > Don't forget to mention in the subject which tree is targeting this
> > patch.
>
> This and all my similar fixes/cleanup are against -next.
>
> What prefix would you like to see ?
net-next
Thanks
>
> Tom
>
> > Other than that looks OK.
> >
> > Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> >
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > ---
> > > drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> > > index 62dfbdd33365..efa7f401529e 100644
> > > --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
> > > +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> > > @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = {
> > > #endif
> > > };
> > >
> > > -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
> > > -{
> > > - return container_of(q, struct sge_qset, fl[qidx]);
> > > -}
> > > -
> > > static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q)
> > > {
> > > return container_of(q, struct sge_qset, rspq);
> > > --
> > > 2.27.0
> > >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: cxgb3: remove unused fl_to_qset function
2023-03-19 17:24 [PATCH] net: cxgb3: remove unused fl_to_qset function Tom Rix
2023-03-19 17:45 ` Horatiu Vultur
@ 2023-03-21 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-21 3:10 UTC (permalink / raw)
To: Tom Rix
Cc: rajur, davem, edumazet, kuba, pabeni, nathan, ndesaulniers,
netdev, linux-kernel, llvm
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 19 Mar 2023 13:24:33 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function
> 'fl_to_qset' [-Werror,-Wunused-function]
> static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
> ^
> This function is not used, so remove it.
>
> [...]
Here is the summary with links:
- net: cxgb3: remove unused fl_to_qset function
https://git.kernel.org/netdev/net-next/c/a08df15eab0c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-21 3:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 17:24 [PATCH] net: cxgb3: remove unused fl_to_qset function Tom Rix
2023-03-19 17:45 ` Horatiu Vultur
2023-03-20 12:29 ` Tom Rix
2023-03-20 13:37 ` Leon Romanovsky
2023-03-21 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).