* [PATCH] hwmon: remove unused superio_outb function
@ 2023-03-23 21:15 Tom Rix
2023-03-24 6:39 ` Juerg Haefliger
2023-03-25 13:51 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-23 21:15 UTC (permalink / raw)
To: juergh, jdelvare, linux, nathan, ndesaulniers
Cc: linux-hwmon, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/hwmon/vt1211.c:198:20: error: unused function
'superio_outb' [-Werror,-Wunused-function]
static inline void superio_outb(int sio_cip, int reg, int val)
^
This function is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/hwmon/vt1211.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/hwmon/vt1211.c b/drivers/hwmon/vt1211.c
index 4a5e911d26eb..fcd4be7a5a85 100644
--- a/drivers/hwmon/vt1211.c
+++ b/drivers/hwmon/vt1211.c
@@ -195,12 +195,6 @@ struct vt1211_data {
/* VT1211 logical device numbers */
#define SIO_VT1211_LDN_HWMON 0x0b /* HW monitor */
-static inline void superio_outb(int sio_cip, int reg, int val)
-{
- outb(reg, sio_cip);
- outb(val, sio_cip + 1);
-}
-
static inline int superio_inb(int sio_cip, int reg)
{
outb(reg, sio_cip);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: remove unused superio_outb function
2023-03-23 21:15 [PATCH] hwmon: remove unused superio_outb function Tom Rix
@ 2023-03-24 6:39 ` Juerg Haefliger
2023-03-25 13:51 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Juerg Haefliger @ 2023-03-24 6:39 UTC (permalink / raw)
To: Tom Rix
Cc: jdelvare, linux, nathan, ndesaulniers, linux-hwmon, linux-kernel,
llvm
------- Original Message -------
On Thursday, March 23rd, 2023 at 22:15, Tom Rix <trix@redhat.com> wrote:
>
>
> clang with W=1 reports
> drivers/hwmon/vt1211.c:198:20: error: unused function
> 'superio_outb' [-Werror,-Wunused-function]
> static inline void superio_outb(int sio_cip, int reg, int val)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix trix@redhat.com
Looks good.
Acked-by: Juerg Haefliger <juergh@proton.me>
...Juerg
> ---
> drivers/hwmon/vt1211.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/hwmon/vt1211.c b/drivers/hwmon/vt1211.c
> index 4a5e911d26eb..fcd4be7a5a85 100644
> --- a/drivers/hwmon/vt1211.c
> +++ b/drivers/hwmon/vt1211.c
> @@ -195,12 +195,6 @@ struct vt1211_data {
> /* VT1211 logical device numbers /
> #define SIO_VT1211_LDN_HWMON 0x0b / HW monitor */
>
> -static inline void superio_outb(int sio_cip, int reg, int val)
> -{
> - outb(reg, sio_cip);
> - outb(val, sio_cip + 1);
> -}
> -
> static inline int superio_inb(int sio_cip, int reg)
> {
> outb(reg, sio_cip);
> --
> 2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: remove unused superio_outb function
2023-03-23 21:15 [PATCH] hwmon: remove unused superio_outb function Tom Rix
2023-03-24 6:39 ` Juerg Haefliger
@ 2023-03-25 13:51 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-03-25 13:51 UTC (permalink / raw)
To: Tom Rix
Cc: juergh, jdelvare, nathan, ndesaulniers, linux-hwmon, linux-kernel,
llvm
On Thu, Mar 23, 2023 at 05:15:35PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/hwmon/vt1211.c:198:20: error: unused function
> 'superio_outb' [-Werror,-Wunused-function]
> static inline void superio_outb(int sio_cip, int reg, int val)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Acked-by: Juerg Haefliger <juergh@proton.me>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-25 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-23 21:15 [PATCH] hwmon: remove unused superio_outb function Tom Rix
2023-03-24 6:39 ` Juerg Haefliger
2023-03-25 13:51 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox