From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Tom Rix <trix@redhat.com>
Cc: linkinjeon@kernel.org, sfrench@samba.org,
senozhatsky@chromium.org, tom@talpey.com, nathan@kernel.org,
ndesaulniers@google.com, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] ksmbd: remove unused is_char_allowed function
Date: Sat, 25 Mar 2023 10:20:22 +0900 [thread overview]
Message-ID: <20230325012022.GH3271889@google.com> (raw)
In-Reply-To: <20230324173056.2652725-1-trix@redhat.com>
On (23/03/24 13:30), Tom Rix wrote:
>
> clang with W=1 reports
> fs/ksmbd/unicode.c:122:19: error: unused function
> 'is_char_allowed' [-Werror,-Wunused-function]
> static inline int is_char_allowed(char *ch)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
We have a copy of that function in fs/ksmbd/misc.c.
next prev parent reply other threads:[~2023-03-25 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 17:30 [PATCH] ksmbd: remove unused is_char_allowed function Tom Rix
2023-03-25 1:20 ` Sergey Senozhatsky [this message]
2023-03-25 9:00 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230325012022.GH3271889@google.com \
--to=senozhatsky@chromium.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sfrench@samba.org \
--cc=tom@talpey.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox