* Re: [PATCH] arm64: Disable EL2 traps for BRBE instructions executed in EL1 [not found] <20230324055127.2228330-1-anshuman.khandual@arm.com> @ 2023-03-25 0:37 ` kernel test robot 2023-03-27 6:08 ` Anshuman Khandual 0 siblings, 1 reply; 3+ messages in thread From: kernel test robot @ 2023-03-25 0:37 UTC (permalink / raw) To: Anshuman Khandual, linux-arm-kernel Cc: llvm, oe-kbuild-all, Anshuman Khandual, Catalin Marinas, Will Deacon, Mark Brown, Marc Zyngier, linux-kernel Hi Anshuman, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on arm/for-next arm/fixes kvmarm/next soc/for-next xilinx-xlnx/master linus/master v6.3-rc3 next-20230324] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/arm64-Disable-EL2-traps-for-BRBE-instructions-executed-in-EL1/20230324-135312 base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core patch link: https://lore.kernel.org/r/20230324055127.2228330-1-anshuman.khandual%40arm.com patch subject: [PATCH] arm64: Disable EL2 traps for BRBE instructions executed in EL1 config: arm64-randconfig-r001-20230322 (https://download.01.org/0day-ci/archive/20230325/202303250802.KytExIHw-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/457bbac085c7f83be1a63b54f6caf32b820503eb git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Anshuman-Khandual/arm64-Disable-EL2-traps-for-BRBE-instructions-executed-in-EL1/20230324-135312 git checkout 457bbac085c7f83be1a63b54f6caf32b820503eb # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303250802.KytExIHw-lkp@intel.com/ All errors (new ones prefixed by >>): >> <instantiation>:36:14: error: expected compatible register or logical immediate orr x0, x0, #HFGITR_EL2_nBRBIALL ^ <instantiation>:10:2: note: while in macro instantiation __init_el2_fgt ^ arch/arm64/kernel/head.S:577:2: note: while in macro instantiation init_el2_state ^ <instantiation>:37:14: error: expected compatible register or logical immediate orr x0, x0, #HFGITR_EL2_nBRBINJ ^ <instantiation>:10:2: note: while in macro instantiation __init_el2_fgt ^ arch/arm64/kernel/head.S:577:2: note: while in macro instantiation init_el2_state ^ -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Disable EL2 traps for BRBE instructions executed in EL1 2023-03-25 0:37 ` [PATCH] arm64: Disable EL2 traps for BRBE instructions executed in EL1 kernel test robot @ 2023-03-27 6:08 ` Anshuman Khandual 2023-03-29 5:52 ` Liu, Yujie 0 siblings, 1 reply; 3+ messages in thread From: Anshuman Khandual @ 2023-03-27 6:08 UTC (permalink / raw) To: kernel test robot, linux-arm-kernel Cc: llvm, oe-kbuild-all, Catalin Marinas, Will Deacon, Mark Brown, Marc Zyngier, linux-kernel On 3/25/23 06:07, kernel test robot wrote: > All errors (new ones prefixed by >>): > >>> <instantiation>:36:14: error: expected compatible register or logical immediate > orr x0, x0, #HFGITR_EL2_nBRBIALL > ^ > <instantiation>:10:2: note: while in macro instantiation > __init_el2_fgt > ^ > arch/arm64/kernel/head.S:577:2: note: while in macro instantiation > init_el2_state > ^ > <instantiation>:37:14: error: expected compatible register or logical immediate > orr x0, x0, #HFGITR_EL2_nBRBINJ > ^ > <instantiation>:10:2: note: while in macro instantiation > __init_el2_fgt > ^ > arch/arm64/kernel/head.S:577:2: note: while in macro instantiation > init_el2_state > ^ I guess these build errors are caused by unavailability of the pre-requisite patches from Mark Brown, in this test environment ? https://lore.kernel.org/all/20230306-arm64-fgt-reg-gen-v3-0-decba93cbaab@kernel.org/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Disable EL2 traps for BRBE instructions executed in EL1 2023-03-27 6:08 ` Anshuman Khandual @ 2023-03-29 5:52 ` Liu, Yujie 0 siblings, 0 replies; 3+ messages in thread From: Liu, Yujie @ 2023-03-29 5:52 UTC (permalink / raw) To: linux-arm-kernel@lists.infradead.org, anshuman.khandual@arm.com, lkp Cc: maz@kernel.org, broonie@kernel.org, llvm@lists.linux.dev, will@kernel.org, oe-kbuild-all@lists.linux.dev, catalin.marinas@arm.com, linux-kernel@vger.kernel.org On Mon, 2023-03-27 at 11:38 +0530, Anshuman Khandual wrote: > On 3/25/23 06:07, kernel test robot wrote: > > All errors (new ones prefixed by >>): > > > > > > <instantiation>:36:14: error: expected compatible register or logical immediate > > orr x0, x0, #HFGITR_EL2_nBRBIALL > > ^ > > <instantiation>:10:2: note: while in macro instantiation > > __init_el2_fgt > > ^ > > arch/arm64/kernel/head.S:577:2: note: while in macro instantiation > > init_el2_state > > ^ > > <instantiation>:37:14: error: expected compatible register or logical immediate > > orr x0, x0, #HFGITR_EL2_nBRBINJ > > ^ > > <instantiation>:10:2: note: while in macro instantiation > > __init_el2_fgt > > ^ > > arch/arm64/kernel/head.S:577:2: note: while in macro instantiation > > init_el2_state > > ^ > > I guess these build errors are caused by unavailability of the pre-requisite > patches from Mark Brown, in this test environment ? > > https://lore.kernel.org/all/20230306-arm64-fgt-reg-gen-v3-0-decba93cbaab@kernel.org/ Thanks for the information. We noticed that the base and prerequisite patches are mentioned in the commit message: --- This patch applies on v6.3-rc3, after the following patch series from Mark https://lore.kernel.org/all/20230306-arm64-fgt-reg-gen-v3-0-decba93cbaab@kernel.org/ The robot couldn't understand above description, and it is recommended to use `git format-patch --base` to generate base info. Please refer to the documents in: https://git-scm.com/docs/git-format-patch#_base_tree_information For this case, the correct order of patches would be: arm64: Disable EL2 traps for BRBE instructions executed in EL1 arm64/sysreg: Convert HFGITR_EL2 to automatic generation arm64/sysreg: Convert HFG[RW]TR_EL2 to automatic generation e8d018dd0257 Linux 6.3-rc3 Please checkout to the patch and do `git format-patch --base e8d018dd0257 -1`, it will generate base info in the footer of the patch: base-commit: e8d018dd0257f744ca50a729e3d042cf2ec9da65 prerequisite-patch-id: 6f448444c7a40a44146d4ecbfa57190ae30a257f prerequisite-patch-id: 484c605fa9d35d776eda3c47ab95a24841712885 Then the robot can parse this info to select base and apply prerequisite patches as expected. -- Best Regards, Yujie ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-29 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230324055127.2228330-1-anshuman.khandual@arm.com>
2023-03-25 0:37 ` [PATCH] arm64: Disable EL2 traps for BRBE instructions executed in EL1 kernel test robot
2023-03-27 6:08 ` Anshuman Khandual
2023-03-29 5:52 ` Liu, Yujie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox