public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [djiang:cxl-qtg 12/23] drivers/cxl/core/port.c:2045:6: warning: variable 'devices' set but not used
Date: Sat, 8 Apr 2023 09:14:32 +0800	[thread overview]
Message-ID: <202304080913.dZb5ztze-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git cxl-qtg
head:   5c305908f705279678135d3adf13cf2165c0609c
commit: 064b21698b2e5653b5547c639a895141a402edd4 [12/23] cxl: Add helper function that calculate QoS values for PCI path
config: arm-randconfig-r046-20230407 (https://download.01.org/0day-ci/archive/20230408/202304080913.dZb5ztze-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 2c57868e2e877f73c339796c3374ae660bb77f0d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git/commit/?id=064b21698b2e5653b5547c639a895141a402edd4
        git remote add djiang https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git
        git fetch --no-tags djiang cxl-qtg
        git checkout 064b21698b2e5653b5547c639a895141a402edd4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/cxl/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304080913.dZb5ztze-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/cxl/core/port.c:2045:6: warning: variable 'devices' set but not used [-Wunused-but-set-variable]
           int devices = 0;
               ^
   1 warning generated.


vim +/devices +2045 drivers/cxl/core/port.c

  2028	
  2029	/**
  2030	 * cxl_port_get_downstream_qos - retrieve QoS data for PCIE downstream path
  2031	 * @port: endpoint cxl_port
  2032	 * @bandwidth: writeback value for min bandwidth
  2033	 * @latency: writeback value for total latency
  2034	 *
  2035	 * Return: Errno on failure, 0 on success.
  2036	 */
  2037	int cxl_port_get_downstream_qos(struct cxl_port *port, u64 *bandwidth,
  2038					u64 *latency)
  2039	{
  2040		u64 min_bw = ULONG_MAX;
  2041		struct pci_dev *pdev;
  2042		struct cxl_port *p;
  2043		struct device *dev;
  2044		u64 total_lat = 0;
> 2045		int devices = 0;
  2046		u64 lat;
  2047	
  2048		/* Grab the device that is the PCI device for CXL memdev */
  2049		dev = port->uport->parent;
  2050		/* Skip if it's not PCI, most likely a cxl_test device */
  2051		if (!dev_is_pci(dev))
  2052			return 0;
  2053	
  2054		pdev = to_pci_dev(dev);
  2055		min_bw = pcie_bandwidth_available(pdev, NULL, NULL, NULL);
  2056		if (min_bw == 0)
  2057			return -ENXIO;
  2058	
  2059		/* convert to MB/s from Mb/s */
  2060		min_bw >>= 3;
  2061	
  2062		p = port;
  2063		do {
  2064			struct cxl_dport *dport;
  2065	
  2066			lat = cxl_pci_get_latency(pdev);
  2067			if (lat < 0)
  2068				return lat;
  2069	
  2070			total_lat += lat;
  2071			devices++;
  2072	
  2073			dport = p->parent_dport;
  2074			if (!dport)
  2075				break;
  2076	
  2077			p = dport->port;
  2078			dev = p->uport;
  2079			if (!dev_is_pci(dev))
  2080				break;
  2081			pdev = to_pci_dev(dev);
  2082		} while (1);
  2083	
  2084		*bandwidth = min_bw;
  2085		*latency = total_lat;
  2086		return 0;
  2087	}
  2088	EXPORT_SYMBOL_NS_GPL(cxl_port_get_downstream_qos, CXL);
  2089	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

                 reply	other threads:[~2023-04-08  1:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202304080913.dZb5ztze-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox