* Re: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console
[not found] <43d7f8d6e4b45a1a76fceef2d117bbc3954bc0bf.1681994221.git.chris@chrisdown.name>
@ 2023-04-21 0:18 ` kernel test robot
2023-04-21 8:59 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-04-21 0:18 UTC (permalink / raw)
To: Chris Down, linux-kernel
Cc: llvm, oe-kbuild-all, Petr Mladek, Greg Kroah-Hartman,
Sergey Senozhatsky, Steven Rostedt, John Ogness,
Geert Uytterhoeven, kernel-team
Hi Chris,
kernel test robot noticed the following build errors:
[auto build test ERROR on cb0856346a60fe3eb837ba5e73588a41f81ac05f]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Down/printk-Do-not-delay-messages-which-aren-t-solicited-by-any-console/20230420-204202
base: cb0856346a60fe3eb837ba5e73588a41f81ac05f
patch link: https://lore.kernel.org/r/43d7f8d6e4b45a1a76fceef2d117bbc3954bc0bf.1681994221.git.chris%40chrisdown.name
patch subject: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console
config: x86_64-randconfig-a013-20230417 (https://download.01.org/0day-ci/archive/20230421/202304210846.3xN0Ge3m-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/db9fb81bc5f175ef48cb317c24da85d0f6d4391d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chris-Down/printk-Do-not-delay-messages-which-aren-t-solicited-by-any-console/20230420-204202
git checkout db9fb81bc5f175ef48cb317c24da85d0f6d4391d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs// kernel/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304210846.3xN0Ge3m-lkp@intel.com/
All errors (new ones prefixed by >>):
>> kernel/printk/printk.c:1298:3: error: expected ')'
return;
^
kernel/printk/printk.c:1297:5: note: to match this '('
if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
^
1 error generated.
vim +1298 kernel/printk/printk.c
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1291
db9fb81bc5f175 kernel/printk/printk.c Chris Down 2023-04-20 1292 static void boot_delay_msec(void)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1293 {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1294 unsigned long long k;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1295 unsigned long timeout;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1296
ff48cd26fc4889 kernel/printk/printk.c Thomas Gleixner 2017-05-16 1297 if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 @1298 return;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1299
3a3b6ed2235f2f kernel/printk.c Dave Young 2009-09-22 1300 k = (unsigned long long)loops_per_msec * boot_delay;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1301
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1302 timeout = jiffies + msecs_to_jiffies(boot_delay);
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1303 while (k) {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1304 k--;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1305 cpu_relax();
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1306 /*
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1307 * use (volatile) jiffies to prevent
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1308 * compiler reduction; loop termination via jiffies
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1309 * is secondary and may or may not happen.
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1310 */
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1311 if (time_after(jiffies, timeout))
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1312 break;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1313 touch_nmi_watchdog();
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1314 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1315 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1316 #else
db9fb81bc5f175 kernel/printk/printk.c Chris Down 2023-04-20 1317 static inline void boot_delay_msec(void)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1318 {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1319 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1320 #endif
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1321
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console
[not found] <43d7f8d6e4b45a1a76fceef2d117bbc3954bc0bf.1681994221.git.chris@chrisdown.name>
2023-04-21 0:18 ` [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console kernel test robot
@ 2023-04-21 8:59 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-04-21 8:59 UTC (permalink / raw)
To: Chris Down, linux-kernel
Cc: llvm, oe-kbuild-all, Petr Mladek, Greg Kroah-Hartman,
Sergey Senozhatsky, Steven Rostedt, John Ogness,
Geert Uytterhoeven, kernel-team
Hi Chris,
kernel test robot noticed the following build errors:
[auto build test ERROR on cb0856346a60fe3eb837ba5e73588a41f81ac05f]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Down/printk-Do-not-delay-messages-which-aren-t-solicited-by-any-console/20230420-204202
base: cb0856346a60fe3eb837ba5e73588a41f81ac05f
patch link: https://lore.kernel.org/r/43d7f8d6e4b45a1a76fceef2d117bbc3954bc0bf.1681994221.git.chris%40chrisdown.name
patch subject: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console
config: i386-randconfig-a011 (https://download.01.org/0day-ci/archive/20230421/202304211628.wQn1SxkT-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/db9fb81bc5f175ef48cb317c24da85d0f6d4391d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chris-Down/printk-Do-not-delay-messages-which-aren-t-solicited-by-any-console/20230420-204202
git checkout db9fb81bc5f175ef48cb317c24da85d0f6d4391d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304211628.wQn1SxkT-lkp@intel.com/
All errors (new ones prefixed by >>):
>> kernel/printk/printk.c:1297:2: error: unterminated function-like macro invocation
if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
^
include/linux/compiler.h:56:9: note: macro 'if' defined here
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
>> kernel/printk/printk.c:4272:24: error: expected '}'
#endif /* CONFIG_SMP */
^
kernel/printk/printk.c:1293:1: note: to match this '{'
{
^
2 errors generated.
vim +1297 kernel/printk/printk.c
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1291
db9fb81bc5f175 kernel/printk/printk.c Chris Down 2023-04-20 1292 static void boot_delay_msec(void)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1293 {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1294 unsigned long long k;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1295 unsigned long timeout;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1296
ff48cd26fc4889 kernel/printk/printk.c Thomas Gleixner 2017-05-16 @1297 if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1298 return;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1299
3a3b6ed2235f2f kernel/printk.c Dave Young 2009-09-22 1300 k = (unsigned long long)loops_per_msec * boot_delay;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1301
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1302 timeout = jiffies + msecs_to_jiffies(boot_delay);
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1303 while (k) {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1304 k--;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1305 cpu_relax();
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1306 /*
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1307 * use (volatile) jiffies to prevent
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1308 * compiler reduction; loop termination via jiffies
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1309 * is secondary and may or may not happen.
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1310 */
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1311 if (time_after(jiffies, timeout))
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1312 break;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1313 touch_nmi_watchdog();
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1314 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1315 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1316 #else
db9fb81bc5f175 kernel/printk/printk.c Chris Down 2023-04-20 1317 static inline void boot_delay_msec(void)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1318 {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1319 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1320 #endif
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1321
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 2+ messages in thread