From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 68D4DA926; Sat, 22 Apr 2023 21:31:06 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1pqKoq-0004RI-00; Sat, 22 Apr 2023 23:30:56 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 03F14C0135; Sat, 22 Apr 2023 23:30:42 +0200 (CEST) Date: Sat, 22 Apr 2023 23:30:42 +0200 From: Thomas Bogendoerfer To: Nathan Chancellor Cc: ndesaulniers@google.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, Naresh Kamboju Subject: Re: [PATCH v2 0/2] MIPS: Fix check_bugs() modpost warning Message-ID: <20230422213042.GA7318@alpha.franken.de> References: <20230419-mips-check_bugs-init-attribute-v2-0-60a7ee65d4bf@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230419-mips-check_bugs-init-attribute-v2-0-60a7ee65d4bf@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) On Fri, Apr 21, 2023 at 09:11:25AM -0700, Nathan Chancellor wrote: > Hi all, > > This series fixes a modpost warning visible in -next from check_bugs() > and helps avoid a potential, albeit unlikely, warning from > check_bugs_early(). > > --- > Changes in v2: > - Now two separate patches: one to avoid current check_bugs() warning > and one to avoid potential check_bugs_early() warning. > - Sink body of check_bugs_early() into setup_arch() directly, rather > than marking it as __init (Nick). > - Add Naresh's reported-by to patch 1, which came after v1 was sent. > - Reword commit messages to note that there is not a problem at run time > because check_bugs() and check_bugs_early(), while not marked __init, > are only called from __init functions; modpost does not know this > though, hence the warning. > - Link to v1: https://lore.kernel.org/r/20230419-mips-check_bugs-init-attribute-v1-1-91e6eed55b89@kernel.org > > --- > Nathan Chancellor (2): > MIPS: Mark check_bugs() as __init > MIPS: Sink body of check_bugs_early() into its only call site > > arch/mips/include/asm/bugs.h | 8 +------- > arch/mips/kernel/setup.c | 3 ++- > 2 files changed, 3 insertions(+), 8 deletions(-) > --- > base-commit: 6a8f57ae2eb07ab39a6f0ccad60c760743051026 > change-id: 20230419-mips-check_bugs-init-attribute-026103bdb255 > > Best regards, > -- > Nathan Chancellor series applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]