Re: [RFC RESEND 1/3] mfd: Add support for UP board CPLD/FPGA

[kernel test robot <lkp@intel.com>]

Hi larry.lai,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 4fe89d07dcc2804c8b562f6c7896a45643d34b2f]

url:    https://github.com/intel-lab-lkp/linux/commits/larry-lai/mfd-Add-support-for-UP-board-CPLD-FPGA/20230425-232744
base:   4fe89d07dcc2804c8b562f6c7896a45643d34b2f
patch link:    https://lore.kernel.org/r/20230425152135.30745-2-larry.lai%40yunjingtech.com
patch subject: [RFC RESEND 1/3] mfd: Add support for UP board CPLD/FPGA
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20230502/202305022231.zyZXagsH-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cb16ef420038f2bede2deb3878b529f0e6ea7729
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review larry-lai/mfd-Add-support-for-UP-board-CPLD-FPGA/20230425-232744
        git checkout cb16ef420038f2bede2deb3878b529f0e6ea7729
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305022231.zyZXagsH-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/mfd/upboard-fpga.c:448:49: warning: data argument not used by format string [-Wformat-extra-args]
                   dev_err(fpga->dev, "Failed to add GPIO LEDs", ret);
                                      ~~~~~~~~~~~~~~~~~~~~~~~~~  ^
   include/linux/dev_printk.h:144:65: note: expanded from macro 'dev_err'
           dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
                                                                  ~~~     ^
   include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
                   _p_func(dev, fmt, ##__VA_ARGS__);                       \
                                ~~~    ^
>> drivers/mfd/upboard-fpga.c:486:20: error: assigning to 'struct regmap_config *' from 'const struct regmap_config *const' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           fpga->cpld_config = fpga_data->cpld_config;
                             ^ ~~~~~~~~~~~~~~~~~~~~~~
   1 warning and 1 error generated.


vim +486 drivers/mfd/upboard-fpga.c

   465	
   466	static int __init upboard_fpga_probe(struct platform_device *pdev)
   467	{
   468		struct upboard_fpga *fpga;
   469		const struct acpi_device_id *id;
   470		const struct upboard_fpga_data *fpga_data;
   471		int ret;
   472		struct device *dev = &pdev->dev;
   473	
   474		id = acpi_match_device(upboard_fpga_acpi_match, dev);
   475		if (!id)
   476			return -ENODEV;
   477	
   478		fpga_data = (const struct upboard_fpga_data *) id->driver_data;
   479	
   480		fpga = devm_kzalloc(dev, sizeof(*fpga), GFP_KERNEL);
   481		if (!fpga)
   482			return -ENOMEM;
   483	
   484		platform_set_drvdata(pdev, fpga);
   485		fpga->regmap = devm_regmap_init(dev, NULL, fpga, fpga_data->cpld_config);
 > 486		fpga->cpld_config = fpga_data->cpld_config;
   487	
   488		if (IS_ERR(fpga->regmap))
   489			return PTR_ERR(fpga->regmap);
   490	
   491		ret = upboard_fpga_gpio_init(fpga);
   492		if (ret) {
   493			/*
   494			 * This is for compatiable with some upboards w/o FPGA firmware,
   495			 * so just showing debug info and do not return directly.
   496			 */
   497			dev_warn(dev, "Failed to initialize FPGA common GPIOs: %d", ret);
   498		} else {
   499			upboard_fpga_show_firmware_info(fpga);
   500		}
   501	
   502		/* register GPIO LEDs */
   503		ret = upboard_led_gpio_register(fpga);
   504		if (ret) {
   505			/*
   506			 * This is for compatiable with some upboards w/o LEDs.
   507			 */
   508			dev_warn(dev, "Failed to register LEDs: %d", ret);
   509		}
   510	
   511		return devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO,
   512					    fpga_data->cells,
   513					    fpga_data->ncells,
   514					    NULL, 0, NULL);
   515	}
   516	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests