From: Tian Lan <tilan7663@gmail.com>
To: axboe@kernel.dk
Cc: lkp@intel.com, linux-block@vger.kernel.org, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, tian.lan@twosigma.com,
tilan7663@gmail.com
Subject: Re: [PATCH 1/1] blk-mq: fix blk_mq_hw_ctx active request accounting
Date: Sat, 13 May 2023 15:11:18 -0400 [thread overview]
Message-ID: <20230513191118.331583-1-tilan7663@gmail.com> (raw)
In-Reply-To: <202305140021.WvuGBjaZ-lkp@intel.com>
Hi Jens,
>> The fact that you didn't even compile this not withstanding, why
>> not just move the existing check from blk_mq_free_request() to
>> __blk_mq_free_request()?
Could you please review the change again when you have a chance, I made the
change that you suggested earlier. I apologize for the broken patch submitted
earlier, we did test the change on our production host and able to confirm the
change did address the active request leaking issue. It was totally my fault
for not proofreading the change before submitting it to the upstream.
Best,
Tian
prev parent reply other threads:[~2023-05-13 19:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230513141234.8395-1-tilan7663@gmail.com>
2023-05-13 16:41 ` [PATCH 1/1] blk-mq: fix blk_mq_hw_ctx active request accounting kernel test robot
2023-05-13 19:05 ` Tian Lan
2023-05-13 20:54 ` Simon Horman
2023-05-13 21:15 ` Jens Axboe
2023-05-13 22:11 ` Tian Lan
2023-05-14 1:39 ` Jens Axboe
2023-05-15 12:28 ` Tian Lan
2023-05-13 22:12 ` Tian Lan
2023-05-14 1:52 ` Jens Axboe
2023-05-14 12:20 ` Ming Lei
2023-06-03 22:39 ` [PATCH] " Tian Lan
2023-06-04 0:47 ` Ming Lei
2023-06-03 22:39 ` [PATCH 1/1] " Tian Lan
2023-05-14 14:22 ` Ming Lei
2023-05-14 14:28 ` Tian Lan
2023-05-14 14:53 ` [PATCH] " Tian Lan
2023-05-15 5:54 ` Hannes Reinecke
2023-05-15 12:26 ` Tian Lan
2023-05-25 2:12 ` Ming Lei
2023-06-03 23:20 ` [PATCH 1/1] " Jens Axboe
2023-05-14 12:08 ` Ming Lei
2023-05-14 14:12 ` Tian Lan
2023-05-14 14:15 ` Ming Lei
2023-05-13 19:11 ` Tian Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230513191118.331583-1-tilan7663@gmail.com \
--to=tilan7663@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tian.lan@twosigma.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox