* Re: [PATCH 5/6] kexec: add helper __crash_shrink_memory() [not found] <20230527123439.772-6-thunder.leizhen@huawei.com> @ 2023-05-28 0:08 ` kernel test robot 2023-05-29 0:37 ` Leizhen (ThunderTown) 0 siblings, 1 reply; 2+ messages in thread From: kernel test robot @ 2023-05-28 0:08 UTC (permalink / raw) To: Zhen Lei, Eric Biederman, Baoquan He, kexec, linux-kernel Cc: llvm, oe-kbuild-all, Zhen Lei, Michael Holzheu, Andrew Morton, Linux Memory Management List, Amerigo Wang Hi Zhen, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on linus/master v6.4-rc3 next-20230525] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zhen-Lei/kexec-fix-a-memory-leak-in-crash_shrink_memory/20230527-203821 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230527123439.772-6-thunder.leizhen%40huawei.com patch subject: [PATCH 5/6] kexec: add helper __crash_shrink_memory() config: riscv-randconfig-r042-20230526 (https://download.01.org/0day-ci/archive/20230528/202305280717.Pw06aLkz-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 4faf3aaf28226a4e950c103a14f6fc1d1fdabb1b) reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/dea97cef503d26e05d0e11818ae44176056ddf64 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zhen-Lei/kexec-fix-a-memory-leak-in-crash_shrink_memory/20230527-203821 git checkout dea97cef503d26e05d0e11818ae44176056ddf64 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202305280717.Pw06aLkz-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/kexec_core.c:1108:5: warning: no previous prototype for function '__crash_shrink_memory' [-Wmissing-prototypes] int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) ^ kernel/kexec_core.c:1108:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) ^ static 1 warning generated. vim +/__crash_shrink_memory +1108 kernel/kexec_core.c 1107 > 1108 int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) 1109 { 1110 struct resource *ram_res; 1111 1112 ram_res = kzalloc(sizeof(*ram_res), GFP_KERNEL); 1113 if (!ram_res) 1114 return -ENOMEM; 1115 1116 ram_res->start = old_res->start + new_size; 1117 ram_res->end = old_res->end; 1118 ram_res->flags = IORESOURCE_BUSY | IORESOURCE_SYSTEM_RAM; 1119 ram_res->name = "System RAM"; 1120 1121 if (!new_size) { 1122 release_resource(old_res); 1123 old_res->start = 0; 1124 old_res->end = 0; 1125 } else { 1126 crashk_res.end = ram_res->start - 1; 1127 } 1128 1129 crash_free_reserved_phys_range(ram_res->start, ram_res->end); 1130 insert_resource(&iomem_resource, ram_res); 1131 1132 return 0; 1133 } 1134 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 5/6] kexec: add helper __crash_shrink_memory() 2023-05-28 0:08 ` [PATCH 5/6] kexec: add helper __crash_shrink_memory() kernel test robot @ 2023-05-29 0:37 ` Leizhen (ThunderTown) 0 siblings, 0 replies; 2+ messages in thread From: Leizhen (ThunderTown) @ 2023-05-29 0:37 UTC (permalink / raw) To: kernel test robot, Eric Biederman, Baoquan He, kexec, linux-kernel Cc: llvm, oe-kbuild-all, Michael Holzheu, Andrew Morton, Linux Memory Management List, Amerigo Wang On 2023/5/28 8:08, kernel test robot wrote: > Hi Zhen, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > [also build test WARNING on linus/master v6.4-rc3 next-20230525] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Zhen-Lei/kexec-fix-a-memory-leak-in-crash_shrink_memory/20230527-203821 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20230527123439.772-6-thunder.leizhen%40huawei.com > patch subject: [PATCH 5/6] kexec: add helper __crash_shrink_memory() > config: riscv-randconfig-r042-20230526 (https://download.01.org/0day-ci/archive/20230528/202305280717.Pw06aLkz-lkp@intel.com/config) > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 4faf3aaf28226a4e950c103a14f6fc1d1fdabb1b) > reproduce (this is a W=1 build): > mkdir -p ~/bin > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install riscv cross compiling tool for clang build > # apt-get install binutils-riscv64-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/dea97cef503d26e05d0e11818ae44176056ddf64 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Zhen-Lei/kexec-fix-a-memory-leak-in-crash_shrink_memory/20230527-203821 > git checkout dea97cef503d26e05d0e11818ae44176056ddf64 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202305280717.Pw06aLkz-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> kernel/kexec_core.c:1108:5: warning: no previous prototype for function '__crash_shrink_memory' [-Wmissing-prototypes] > int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) > ^ > kernel/kexec_core.c:1108:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) > ^ > static > 1 warning generated. Yes, thanks, a 'static' should be added. > > > vim +/__crash_shrink_memory +1108 kernel/kexec_core.c > > 1107 >> 1108 int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) > 1109 { > 1110 struct resource *ram_res; > 1111 > 1112 ram_res = kzalloc(sizeof(*ram_res), GFP_KERNEL); > 1113 if (!ram_res) > 1114 return -ENOMEM; > 1115 > 1116 ram_res->start = old_res->start + new_size; > 1117 ram_res->end = old_res->end; > 1118 ram_res->flags = IORESOURCE_BUSY | IORESOURCE_SYSTEM_RAM; > 1119 ram_res->name = "System RAM"; > 1120 > 1121 if (!new_size) { > 1122 release_resource(old_res); > 1123 old_res->start = 0; > 1124 old_res->end = 0; > 1125 } else { > 1126 crashk_res.end = ram_res->start - 1; > 1127 } > 1128 > 1129 crash_free_reserved_phys_range(ram_res->start, ram_res->end); > 1130 insert_resource(&iomem_resource, ram_res); > 1131 > 1132 return 0; > 1133 } > 1134 > -- Regards, Zhen Lei ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-29 0:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230527123439.772-6-thunder.leizhen@huawei.com>
2023-05-28 0:08 ` [PATCH 5/6] kexec: add helper __crash_shrink_memory() kernel test robot
2023-05-29 0:37 ` Leizhen (ThunderTown)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox