* Re: [PATCH 3/6] ALSA: emu10k1: actually disassemble DSP instructions in /proc
[not found] <20230526101659.437969-4-oswald.buddenhagen@gmx.de>
@ 2023-05-28 0:08 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-05-28 0:08 UTC (permalink / raw)
To: Oswald Buddenhagen, alsa-devel
Cc: llvm, oe-kbuild-all, Takashi Iwai, Jaroslav Kysela
Hi Oswald,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on tiwai-sound/for-linus linus/master v6.4-rc3 next-20230525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Oswald-Buddenhagen/ALSA-emu10k1-hide-absent-2nd-pointer-offset-register-set-from-proc/20230526-182102
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link: https://lore.kernel.org/r/20230526101659.437969-4-oswald.buddenhagen%40gmx.de
patch subject: [PATCH 3/6] ALSA: emu10k1: actually disassemble DSP instructions in /proc
config: x86_64-randconfig-a014-20230528 (https://download.01.org/0day-ci/archive/20230528/202305280731.yycJIsaL-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/13e0e28f29ed98ae73420158c2a879c4e32c694a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Oswald-Buddenhagen/ALSA-emu10k1-hide-absent-2nd-pointer-offset-register-set-from-proc/20230526-182102
git checkout 13e0e28f29ed98ae73420158c2a879c4e32c694a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/pci/emu10k1/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305280731.yycJIsaL-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> sound/pci/emu10k1/emuproc.c:417:41: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
" " + 30 - clamp(65 - len, 0, 30),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
include/sound/info.h:107:54: note: expanded from macro 'snd_iprintf'
seq_printf((struct seq_file *)(buf)->buffer, fmt, ##args)
^~~~
sound/pci/emu10k1/emuproc.c:417:41: note: use array indexing to silence this warning
" " + 30 - clamp(65 - len, 0, 30),
^
& [
include/sound/info.h:107:54: note: expanded from macro 'snd_iprintf'
seq_printf((struct seq_file *)(buf)->buffer, fmt, ##args)
^
1 warning generated.
vim +/int +417 sound/pci/emu10k1/emuproc.c
380
381 static void snd_emu10k1_proc_acode_read(struct snd_info_entry *entry,
382 struct snd_info_buffer *buffer)
383 {
384 u32 pc;
385 struct snd_emu10k1 *emu = entry->private_data;
386 static const char * const insns[16] = {
387 "MAC0", "MAC1", "MAC2", "MAC3", "MACINT0", "MACINT1", "ACC3", "MACMV",
388 "ANDXOR", "TSTNEG", "LIMITGE", "LIMITLT", "LOG", "EXP", "INTERP", "SKIP",
389 };
390
391 snd_iprintf(buffer, "FX8010 Instruction List '%s'\n", emu->fx8010.name);
392 snd_iprintf(buffer, " Code dump :\n");
393 for (pc = 0; pc < (emu->audigy ? 1024 : 512); pc++) {
394 u32 low, high;
395 int len;
396 char buf[100];
397 char *bufp = buf;
398
399 low = snd_emu10k1_efx_read(emu, pc * 2);
400 high = snd_emu10k1_efx_read(emu, pc * 2 + 1);
401 if (emu->audigy) {
402 bufp += sprintf(bufp, " %-7s ", insns[(high >> 24) & 0x0f]);
403 bufp += disasm_audigy_reg(bufp, (high >> 12) & 0x7ff, "");
404 bufp += disasm_audigy_reg(bufp, (high >> 0) & 0x7ff, ", ");
405 bufp += disasm_audigy_reg(bufp, (low >> 12) & 0x7ff, ", ");
406 bufp += disasm_audigy_reg(bufp, (low >> 0) & 0x7ff, ", ");
407 } else {
408 bufp += sprintf(bufp, " %-7s ", insns[(high >> 20) & 0x0f]);
409 bufp += disasm_sblive_reg(bufp, (high >> 10) & 0x3ff, "");
410 bufp += disasm_sblive_reg(bufp, (high >> 0) & 0x3ff, ", ");
411 bufp += disasm_sblive_reg(bufp, (low >> 10) & 0x3ff, ", ");
412 bufp += disasm_sblive_reg(bufp, (low >> 0) & 0x3ff, ", ");
413 }
414 len = (int)(ptrdiff_t)(bufp - buf);
415 snd_iprintf(buffer, "%s %s /* 0x%04x: 0x%08x%08x */\n",
416 buf,
> 417 " " + 30 - clamp(65 - len, 0, 30),
418 pc, high, low);
419 }
420 }
421
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread