[axboe-block:for-6.5/block 65/74] drivers/md/raid1.c:1151:4: warning: incompatible pointer to integer conversion passing 'struct page *' to parameter of type 'unsigned long'

kernel test robot
2023-05-31T23:31:47Z

tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-6.5/block
head: 8e8fedab1194ef90e007636eb3d224c4f8e979a7
commit: 6473bc325644b9c8473e6c92bfb520a68dce1e12 [65/74] md: check for failure when adding pages in alloc_behind_master_bio
config: i386-randconfig-r026-20230531 (https://download.01.org/0day-ci/archive/20230601/202306010709.iZLreXv6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=6473bc325644b9c8473e6c92bfb520a68dce1e12
git remote add axboe-block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
git fetch --no-tags axboe-block for-6.5/block
git checkout 6473bc325644b9c8473e6c92bfb520a68dce1e12
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/md/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306010709.iZLreXv6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/md/raid1.c:1151:4: warning: incompatible pointer to integer conversion passing 'struct page *' to parameter of type 'unsigned long' [-Wint-conversion]
free_page(page);
^~~~~~~~~~~~~~~
include/linux/gfp.h:320:36: note: expanded from macro 'free_page'
#define free_page(addr) free_pages((addr), 0)
^~~~~~
include/linux/gfp.h:303:38: note: passing argument to parameter 'addr' here
extern void free_pages(unsigned long addr, unsigned int order);
^
1 warning generated.

vim +1151 drivers/md/raid1.c

1122
1123 static void alloc_behind_master_bio(struct r1bio *r1_bio,
1124 struct bio *bio)
1125 {
1126 int size = bio->bi_iter.bi_size;
1127 unsigned vcnt = (size + PAGE_SIZE - 1) >> PAGE_SHIFT;
1128 int i = 0;
1129 struct bio *behind_bio = NULL;
1130
1131 behind_bio = bio_alloc_bioset(NULL, vcnt, 0, GFP_NOIO,
1132 &r1_bio->mddev->bio_set);
1133 if (!behind_bio)
1134 return;
1135
1136 /* discard op, we don't support writezero/writesame yet */
1137 if (!bio_has_data(bio)) {
1138 behind_bio->bi_iter.bi_size = size;
1139 goto skip_copy;
1140 }
1141
1142 while (i < vcnt && size) {
1143 struct page *page;
1144 int len = min_t(int, PAGE_SIZE, size);
1145
1146 page = alloc_page(GFP_NOIO);
1147 if (unlikely(!page))
1148 goto free_pages;
1149
1150 if (!bio_add_page(behind_bio, page, len, 0)) {
> 1151 free_page(page);
1152 goto free_pages;
1153 }
1154
1155 size -= len;
1156 i++;
1157 }
1158
1159 bio_copy_data(behind_bio, bio);
1160 skip_copy:
1161 r1_bio->behind_master_bio = behind_bio;
1162 set_bit(R1BIO_BehindIO, &r1_bio->state);
1163
1164 return;
1165
1166 free_pages:
1167 pr_debug("%dB behind alloc failed, doing sync I/O\n",
1168 bio->bi_iter.bi_size);
1169 bio_free_pages(behind_bio);
1170 bio_put(behind_bio);
1171 }
1172

--
0-DAY CI Kernel Test Service