From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94514AD38 for ; Mon, 12 Jun 2023 14:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Rk8v+7kKodlj+QyW1PLHimqi/kwmEy+ooh8DhXxGMfo=; b=cCetaJ92daXjWoUXGnXBaLp3G6 bfsOQ1OWAcEFEJY4ZyCfhLwYZhNtlBf2Q7eU5R0SwM+OVsv5Js6EZajuBVSOtdg3OzxRcoS0/pGsK rN7uHzgtVMTdhoztYnTdwDjksS6LY2Ug0o+8ErBQnX4BinayqXaLoz+MIZ1p7Jz65BjQUB0b64sQh 978qcWTKz5Hquf/2s6rk6wXFOCc8XdIjjElQn1T2wzOthUodNWdIl8tRw3zq0t2uDPSB0mVxHdHIA ElLTgPNN/1E14vY/pxD9iJDXzQ39Ifc3ndqahbL/6RYEzca06s/q4F2o0fBvtbMq60B9iaqPCEw+M f7IMNJiA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q8izf-008uDP-0Q; Mon, 12 Jun 2023 14:58:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E807230031B; Mon, 12 Jun 2023 16:58:05 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id CC3B821F7F9D1; Mon, 12 Jun 2023 16:58:05 +0200 (CEST) Date: Mon, 12 Jun 2023 16:58:05 +0200 From: Peter Zijlstra To: Dan Carpenter Cc: torvalds@linux-foundation.org, keescook@chromium.org, gregkh@linuxfoundation.org, pbonzini@redhat.com, masahiroy@kernel.org, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu, catalin.marinas@arm.com, will@kernel.org, vkoul@kernel.org, trix@redhat.com, ojeda@kernel.org, mingo@redhat.com, longman@redhat.com, boqun.feng@gmail.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, joel@joelfernandes.org, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, john.johansen@canonical.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, llvm@lists.linux.dev, linux-perf-users@vger.kernel.org, rcu@vger.kernel.org, linux-security-module@vger.kernel.org, tglx@linutronix.de, ravi.bangoria@amd.com, error27@gmail.com, luc.vanoostenryck@gmail.com Subject: Re: [PATCH v3 26/57] perf: Simplify event_function*() Message-ID: <20230612145805.GD83892@hirez.programming.kicks-ass.net> References: <20230612090713.652690195@infradead.org> <20230612093539.371360635@infradead.org> <1cbdae4a-d6ad-4dd8-aa75-9e226c4416fe@kadam.mountain> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cbdae4a-d6ad-4dd8-aa75-9e226c4416fe@kadam.mountain> On Mon, Jun 12, 2023 at 05:46:47PM +0300, Dan Carpenter wrote: > On Mon, Jun 12, 2023 at 11:07:39AM +0200, Peter Zijlstra wrote: > > @@ -224,17 +243,15 @@ static int event_function(void *info) > > int ret = 0; > > > > lockdep_assert_irqs_disabled(); > > + guard(perf_ctx_lock)(cpuctx, task_ctx); > > > > - perf_ctx_lock(cpuctx, task_ctx); > > /* > > * Since we do the IPI call without holding ctx->lock things can have > > * changed, double check we hit the task we set out to hit. > > */ > > if (ctx->task) { > > - if (ctx->task != current) { > > - ret = -ESRCH; > > - goto unlock; > > - } > > + if (ctx->task != current) > > + return -ESRCH; > > > > /* > > * We only use event_function_call() on established contexts, > > @@ -254,8 +271,6 @@ static int event_function(void *info) > > } > > > > efs->func(event, cpuctx, ctx, efs->data); > > -unlock: > > - perf_ctx_unlock(cpuctx, task_ctx); > > > > return ret; > > > We can change this to a return 0; and get rid of the "ret" variable. This and the previous one, done!