From: Kees Cook <keescook@chromium.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>, Tom Rix <trix@redhat.com>,
linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix CFI failures with GCOV_PROFILE_ALL
Date: Fri, 23 Jun 2023 09:32:40 -0700 [thread overview]
Message-ID: <202306230932.539C9DC0@keescook> (raw)
In-Reply-To: <20230623001140.1111494-4-samitolvanen@google.com>
On Fri, Jun 23, 2023 at 12:11:41AM +0000, Sami Tolvanen wrote:
> Hi folks,
>
> The following two patches fix CFI failures with GCOV_PROFILE_ALL,
> where the compiler injects indirectly called functions to object
> files that otherwise contain no executable code, and are not
> processed by objtool or don't have CFI enabled. This results in
> missing or incorrect type hashes during boot and when modules are
> loaded.
>
> Sami Tolvanen (2):
> kbuild: Fix CFI failures with GCOV
> kbuild: Disable GCOV for *.mod.o
>
> init/Makefile | 1 +
> scripts/Makefile.modfinal | 2 +-
> scripts/Makefile.vmlinux | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
Nice hunting!
Reviewed-by: Kees Cook <keescook@chromium.org>
Should these get Cc: stable tags maybe?
--
Kees Cook
next prev parent reply other threads:[~2023-06-23 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 0:11 [PATCH 0/2] Fix CFI failures with GCOV_PROFILE_ALL Sami Tolvanen
2023-06-23 0:11 ` [PATCH 1/2] kbuild: Fix CFI failures with GCOV Sami Tolvanen
2023-06-23 0:11 ` [PATCH 2/2] kbuild: Disable GCOV for *.mod.o Sami Tolvanen
2023-06-23 9:13 ` [PATCH 0/2] Fix CFI failures with GCOV_PROFILE_ALL Peter Zijlstra
2023-06-23 16:32 ` Kees Cook [this message]
2023-06-23 20:38 ` Sami Tolvanen
2023-06-24 8:43 ` Masahiro Yamada
2023-06-23 17:47 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306230932.539C9DC0@keescook \
--to=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox