From: kernel test robot <lkp@intel.com>
To: Qais Yousef <qyousef@layalina.io>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [qais-yousef:remove-margins 2/2] kernel/sched/fair.c:165:15: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int
Date: Wed, 19 Jul 2023 13:04:33 +0800 [thread overview]
Message-ID: <202307191211.oFljVu7F-lkp@intel.com> (raw)
tree: https://github.com/qais-yousef/linux remove-margins
head: f49a0141f6fa8e9f6dd3b8cacae3531f90c74343
commit: f49a0141f6fa8e9f6dd3b8cacae3531f90c74343 [2/2] sched/fair: Remove magic margin in fits_capacity()
config: powerpc-randconfig-r026-20230718 (https://download.01.org/0day-ci/archive/20230719/202307191211.oFljVu7F-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230719/202307191211.oFljVu7F-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307191211.oFljVu7F-lkp@intel.com/
All errors (new ones prefixed by >>):
>> kernel/sched/fair.c:165:15: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
165 | static inline fits_capacity(unsigned long util, unsigned long capacity)
| ~~~~~~~~~~~~~ ^
| int
>> kernel/sched/fair.c:167:9: error: call to undeclared function 'approximate_util_avg'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
167 | return approximate_util_avg(util, TICK_NSEC) < capacity;
| ^
2 errors generated.
vim +/int +165 kernel/sched/fair.c
150
151 /*
152 * The util will fit the capacity if it has enough headroom to grow within the
153 * next tick - which is when any load balancing activity happens to do the
154 * correction.
155 *
156 * If util stays within the capacity before tick has elapsed, then it should be
157 * fine. If not, then a correction action must happen shortly after it starts
158 * running, hence we treat it as !fit.
159 *
160 * TODO: TICK is not actually accurate enough. balance_interval is the correct
161 * one to use as the next load balance doesn't not happen religiously at tick.
162 * Accessing balance_interval might be tricky and will require some refactoring
163 * first.
164 */
> 165 static inline fits_capacity(unsigned long util, unsigned long capacity)
166 {
> 167 return approximate_util_avg(util, TICK_NSEC) < capacity;
168 }
169
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-07-19 5:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307191211.oFljVu7F-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=qyousef@layalina.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).