Re: [RFC PATCH v2 1/3] powerpc/eeh: Synchronization for safety

Re: [RFC PATCH v2 1/3] powerpc/eeh: Synchronization for safety

[kernel test robot]

Hi Ganesh,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes awilliam-vfio/next awilliam-vfio/for-linus akpm-mm/mm-everything linus/master v6.5-rc3 next-20230726]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ganesh-Goudar/powerpc-eeh-Synchronization-for-safety/20230724-150512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20230724070020.239173-2-ganeshgr%40linux.ibm.com
patch subject: [RFC PATCH v2 1/3] powerpc/eeh: Synchronization for safety
config: powerpc-powernv_defconfig (https://download.01.org/0day-ci/archive/20230727/202307270301.SCREaz0f-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230727/202307270301.SCREaz0f-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307270301.SCREaz0f-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/powerpc/kernel/eeh_driver.c:310:18: error: no previous prototype for function 'pdev_cache_list_create' [-Werror,-Wmissing-prototypes]
     310 | struct pci_dev **pdev_cache_list_create(struct eeh_pe *root)
         |                  ^
   arch/powerpc/kernel/eeh_driver.c:310:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     310 | struct pci_dev **pdev_cache_list_create(struct eeh_pe *root)
         | ^
         | static 
>> arch/powerpc/kernel/eeh_driver.c:579:16: error: unused variable 'flags' [-Werror,-Wunused-variable]
     579 |         unsigned long flags;
         |                       ^
   2 errors generated.


vim +/pdev_cache_list_create +310 arch/powerpc/kernel/eeh_driver.c

   309	
 > 310	struct pci_dev **pdev_cache_list_create(struct eeh_pe *root)
   311	{
   312		struct eeh_pe *pe;
   313		struct eeh_dev *edev, *tmp;
   314		struct pci_dev **pdevs;
   315		int i, n;
   316	
   317		n = 0;
   318		eeh_for_each_pe(root, pe) eeh_pe_for_each_dev(pe, edev, tmp) {
   319			if (edev->pdev)
   320				n++;
   321		}
   322		pdevs = kmalloc(sizeof(*pdevs) * (n + 1), GFP_KERNEL);
   323		if (WARN_ON_ONCE(!pdevs))
   324			return NULL;
   325		i = 0;
   326		eeh_for_each_pe(root, pe) eeh_pe_for_each_dev(pe, edev, tmp) {
   327			if (i < n) {
   328				get_device(&edev->pdev->dev);
   329				pdevs[i++] = edev->pdev;
   330			}
   331		}
   332		if (WARN_ON_ONCE(i < n))
   333			n = i;
   334		pdevs[n] = NULL; /* terminator */
   335		return pdevs;
   336	}
   337	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki