* [stable:linux-4.19.y 2317/9999] lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
@ 2023-07-31 3:56 kernel test robot
2023-08-01 20:15 ` Nick Desaulniers
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2023-07-31 3:56 UTC (permalink / raw)
To: Fangrui Song
Cc: llvm, oe-kbuild-all, Greg Kroah-Hartman, Nathan Chancellor,
Nick Desaulniers, Masahiro Yamada
Hi Fangrui,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y
head: 767049cead76cf699707290d5aeefb3e4d0d5b43
commit: 69c122751164c3c343eea205fd5c3e1d5132f967 [2317/9999] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation
config: mips-randconfig-r036-20230731 (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307311111.jPEdYIJR-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/net/netdevsim/netdev.c:167:35: warning: unused variable 'nsim_switchdev_ops' [-Wunused-const-variable]
167 | static const struct switchdev_ops nsim_switchdev_ops = {
| ^
1 warning generated.
--
>> lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
652 | : "=l" ((USItype)(w0)), \
| ~~~~~~~~~~^~~
>> lib/mpi/generic_mpih-mul2.c:49:3: error: invalid output constraint '=h' in asm
49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
| ^
lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
653 | "=h" ((USItype)(w1)) \
| ^
2 errors generated.
--
lib/mpi/generic_mpih-mul3.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
652 | : "=l" ((USItype)(w0)), \
| ~~~~~~~~~~^~~
>> lib/mpi/generic_mpih-mul3.c:49:3: error: invalid output constraint '=h' in asm
49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
| ^
lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
653 | "=h" ((USItype)(w1)) \
| ^
2 errors generated.
--
>> lib/mpi/mpih-div.c:142:20: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
142 | umul_ppmm(n1, n0, d0, q);
| ~~~~~~~~~~~~~~^~~~~~~~~~
lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
652 | : "=l" ((USItype)(w0)), \
| ~~~~~~~~~~^~~
>> lib/mpi/mpih-div.c:142:6: error: invalid output constraint '=h' in asm
142 | umul_ppmm(n1, n0, d0, q);
| ^
lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
653 | "=h" ((USItype)(w1)) \
| ^
lib/mpi/mpih-div.c:205:20: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
205 | umul_ppmm(n1, n0, d1, q);
| ~~~~~~~~~~~~~~^~~~~~~~~~
lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
652 | : "=l" ((USItype)(w0)), \
| ~~~~~~~~~~^~~
lib/mpi/mpih-div.c:205:6: error: invalid output constraint '=h' in asm
205 | umul_ppmm(n1, n0, d1, q);
| ^
lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
653 | "=h" ((USItype)(w1)) \
| ^
4 errors generated.
--
>> lib/mpi/generic_mpih-mul1.c:50:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
50 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
652 | : "=l" ((USItype)(w0)), \
| ~~~~~~~~~~^~~
>> lib/mpi/generic_mpih-mul1.c:50:3: error: invalid output constraint '=h' in asm
50 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
| ^
lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
653 | "=h" ((USItype)(w1)) \
| ^
2 errors generated.
vim +49 lib/mpi/generic_mpih-mul2.c
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 31
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 32 mpi_limb_t
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 33 mpihelp_addmul_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 34 mpi_size_t s1_size, mpi_limb_t s2_limb)
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 35 {
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 36 mpi_limb_t cy_limb;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 37 mpi_size_t j;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 38 mpi_limb_t prod_high, prod_low;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 39 mpi_limb_t x;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 40
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 41 /* The loop counter and index J goes from -SIZE to -1. This way
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 42 * the loop becomes faster. */
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 43 j = -s1_size;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 44 res_ptr -= j;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 45 s1_ptr -= j;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 46
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 47 cy_limb = 0;
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 48 do {
cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 @49 umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
:::::: The code at line 49 was first introduced by commit
:::::: cdec9cb5167ab1113ba9c58e395f664d9d3f9acb crypto: GnuPG based MPI lib - source files (part 1)
:::::: TO: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
:::::: CC: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [stable:linux-4.19.y 2317/9999] lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
2023-07-31 3:56 [stable:linux-4.19.y 2317/9999] lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions kernel test robot
@ 2023-08-01 20:15 ` Nick Desaulniers
2023-08-01 20:26 ` Nathan Chancellor
2023-08-01 20:27 ` Florian Fainelli
0 siblings, 2 replies; 5+ messages in thread
From: Nick Desaulniers @ 2023-08-01 20:15 UTC (permalink / raw)
To: Florian Fainelli
Cc: Fangrui Song, llvm, oe-kbuild-all, Greg Kroah-Hartman,
Nathan Chancellor, Masahiro Yamada, kernel test robot
On Sun, Jul 30, 2023 at 8:57 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi Fangrui,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y
> head: 767049cead76cf699707290d5aeefb3e4d0d5b43
> commit: 69c122751164c3c343eea205fd5c3e1d5132f967 [2317/9999] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation
These aren't a result of Fangrui's change. Fangrui's change probably
allows this config to mostly build, modulo the below error in
lib/mpi/generic_mpih-mul2.c.
> config: mips-randconfig-r036-20230731 (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> reproduce: (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202307311111.jPEdYIJR-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
> >> drivers/net/netdevsim/netdev.c:167:35: warning: unused variable 'nsim_switchdev_ops' [-Wunused-const-variable]
> 167 | static const struct switchdev_ops nsim_switchdev_ops = {
> | ^
> 1 warning generated.
^ fixed by
commit e58df56c8564 ("netdevsim: Implement ndo_get_port_parent_id()")
in v5.1-rc1 (this report is against 4.19.y)
Florian, does it make sense for the stable maintainers to cherry-pick
e58df56c8564 to 4.19.y in isolation?
> --
> >> lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
> 49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Looks like randconfig found and outstanding issue. Filed:
https://github.com/ClangBuiltLinux/linux/issues/1898 to follow up+fix.
> lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
> 652 | : "=l" ((USItype)(w0)), \
> | ~~~~~~~~~~^~~
> >> lib/mpi/generic_mpih-mul2.c:49:3: error: invalid output constraint '=h' in asm
> 49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> | ^
> lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
> 653 | "=h" ((USItype)(w1)) \
> | ^
> 2 errors generated.
> --
> lib/mpi/generic_mpih-mul3.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
> 49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
> 652 | : "=l" ((USItype)(w0)), \
> | ~~~~~~~~~~^~~
> >> lib/mpi/generic_mpih-mul3.c:49:3: error: invalid output constraint '=h' in asm
> 49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> | ^
> lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
> 653 | "=h" ((USItype)(w1)) \
> | ^
> 2 errors generated.
> --
> >> lib/mpi/mpih-div.c:142:20: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
> 142 | umul_ppmm(n1, n0, d0, q);
> | ~~~~~~~~~~~~~~^~~~~~~~~~
> lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
> 652 | : "=l" ((USItype)(w0)), \
> | ~~~~~~~~~~^~~
> >> lib/mpi/mpih-div.c:142:6: error: invalid output constraint '=h' in asm
> 142 | umul_ppmm(n1, n0, d0, q);
> | ^
> lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
> 653 | "=h" ((USItype)(w1)) \
> | ^
> lib/mpi/mpih-div.c:205:20: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
> 205 | umul_ppmm(n1, n0, d1, q);
> | ~~~~~~~~~~~~~~^~~~~~~~~~
> lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
> 652 | : "=l" ((USItype)(w0)), \
> | ~~~~~~~~~~^~~
> lib/mpi/mpih-div.c:205:6: error: invalid output constraint '=h' in asm
> 205 | umul_ppmm(n1, n0, d1, q);
> | ^
> lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
> 653 | "=h" ((USItype)(w1)) \
> | ^
> 4 errors generated.
> --
> >> lib/mpi/generic_mpih-mul1.c:50:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
> 50 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm'
> 652 | : "=l" ((USItype)(w0)), \
> | ~~~~~~~~~~^~~
> >> lib/mpi/generic_mpih-mul1.c:50:3: error: invalid output constraint '=h' in asm
> 50 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> | ^
> lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm'
> 653 | "=h" ((USItype)(w1)) \
> | ^
> 2 errors generated.
>
>
> vim +49 lib/mpi/generic_mpih-mul2.c
>
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 31
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 32 mpi_limb_t
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 33 mpihelp_addmul_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 34 mpi_size_t s1_size, mpi_limb_t s2_limb)
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 35 {
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 36 mpi_limb_t cy_limb;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 37 mpi_size_t j;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 38 mpi_limb_t prod_high, prod_low;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 39 mpi_limb_t x;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 40
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 41 /* The loop counter and index J goes from -SIZE to -1. This way
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 42 * the loop becomes faster. */
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 43 j = -s1_size;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 44 res_ptr -= j;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 45 s1_ptr -= j;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 46
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 47 cy_limb = 0;
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 48 do {
> cdec9cb5167ab1 Dmitry Kasatkin 2011-08-31 @49 umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
>
> :::::: The code at line 49 was first introduced by commit
> :::::: cdec9cb5167ab1113ba9c58e395f664d9d3f9acb crypto: GnuPG based MPI lib - source files (part 1)
>
> :::::: TO: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
> :::::: CC: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [stable:linux-4.19.y 2317/9999] lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
2023-08-01 20:15 ` Nick Desaulniers
@ 2023-08-01 20:26 ` Nathan Chancellor
2023-08-16 16:16 ` Greg Kroah-Hartman
2023-08-01 20:27 ` Florian Fainelli
1 sibling, 1 reply; 5+ messages in thread
From: Nathan Chancellor @ 2023-08-01 20:26 UTC (permalink / raw)
To: Nick Desaulniers, Greg Kroah-Hartman, Sasha Levin
Cc: Florian Fainelli, Fangrui Song, llvm, oe-kbuild-all,
Masahiro Yamada, kernel test robot
On Tue, Aug 01, 2023 at 01:15:30PM -0700, Nick Desaulniers wrote:
> On Sun, Jul 30, 2023 at 8:57 PM kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Fangrui,
> >
> > First bad commit (maybe != root cause):
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y
> > head: 767049cead76cf699707290d5aeefb3e4d0d5b43
> > commit: 69c122751164c3c343eea205fd5c3e1d5132f967 [2317/9999] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation
>
> These aren't a result of Fangrui's change. Fangrui's change probably
> allows this config to mostly build, modulo the below error in
> lib/mpi/generic_mpih-mul2.c.
>
> > config: mips-randconfig-r036-20230731 (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/config)
> > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> > reproduce: (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202307311111.jPEdYIJR-lkp@intel.com/
> >
> > All error/warnings (new ones prefixed by >>):
> >
> > >> drivers/net/netdevsim/netdev.c:167:35: warning: unused variable 'nsim_switchdev_ops' [-Wunused-const-variable]
> > 167 | static const struct switchdev_ops nsim_switchdev_ops = {
> > | ^
> > 1 warning generated.
>
> ^ fixed by
> commit e58df56c8564 ("netdevsim: Implement ndo_get_port_parent_id()")
> in v5.1-rc1 (this report is against 4.19.y)
> Florian, does it make sense for the stable maintainers to cherry-pick
> e58df56c8564 to 4.19.y in isolation?
>
> > --
> > >> lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
> > 49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> > | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Looks like randconfig found and outstanding issue. Filed:
> https://github.com/ClangBuiltLinux/linux/issues/1898 to follow up+fix.
Actually, this is fixed with commit b0c091ae04f6 ("lib/mpi: Eliminate
unused umul_ppmm definitions for MIPS"), which applies cleanly to 4.19
and should be fine because 4.19 contains commit cafa0010cd51 ("Raise the
minimum required gcc version to 4.6").
Greg and Sasha, could b0c091ae04f6 be applied to 4.19 to resolve this
randconfig failure?
Cheers,
Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [stable:linux-4.19.y 2317/9999] lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
2023-08-01 20:26 ` Nathan Chancellor
@ 2023-08-16 16:16 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-16 16:16 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Nick Desaulniers, Sasha Levin, Florian Fainelli, Fangrui Song,
llvm, oe-kbuild-all, Masahiro Yamada, kernel test robot
On Tue, Aug 01, 2023 at 01:26:02PM -0700, Nathan Chancellor wrote:
> On Tue, Aug 01, 2023 at 01:15:30PM -0700, Nick Desaulniers wrote:
> > On Sun, Jul 30, 2023 at 8:57 PM kernel test robot <lkp@intel.com> wrote:
> > >
> > > Hi Fangrui,
> > >
> > > First bad commit (maybe != root cause):
> > >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y
> > > head: 767049cead76cf699707290d5aeefb3e4d0d5b43
> > > commit: 69c122751164c3c343eea205fd5c3e1d5132f967 [2317/9999] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation
> >
> > These aren't a result of Fangrui's change. Fangrui's change probably
> > allows this config to mostly build, modulo the below error in
> > lib/mpi/generic_mpih-mul2.c.
> >
> > > config: mips-randconfig-r036-20230731 (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/config)
> > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> > > reproduce: (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202307311111.jPEdYIJR-lkp@intel.com/
> > >
> > > All error/warnings (new ones prefixed by >>):
> > >
> > > >> drivers/net/netdevsim/netdev.c:167:35: warning: unused variable 'nsim_switchdev_ops' [-Wunused-const-variable]
> > > 167 | static const struct switchdev_ops nsim_switchdev_ops = {
> > > | ^
> > > 1 warning generated.
> >
> > ^ fixed by
> > commit e58df56c8564 ("netdevsim: Implement ndo_get_port_parent_id()")
> > in v5.1-rc1 (this report is against 4.19.y)
> > Florian, does it make sense for the stable maintainers to cherry-pick
> > e58df56c8564 to 4.19.y in isolation?
> >
> > > --
> > > >> lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
> > > 49 | umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb);
> > > | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Looks like randconfig found and outstanding issue. Filed:
> > https://github.com/ClangBuiltLinux/linux/issues/1898 to follow up+fix.
>
> Actually, this is fixed with commit b0c091ae04f6 ("lib/mpi: Eliminate
> unused umul_ppmm definitions for MIPS"), which applies cleanly to 4.19
> and should be fine because 4.19 contains commit cafa0010cd51 ("Raise the
> minimum required gcc version to 4.6").
>
> Greg and Sasha, could b0c091ae04f6 be applied to 4.19 to resolve this
> randconfig failure?
Sure, I've applied this now to 4.19.y and 4.14.y for the next round of
releases.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable:linux-4.19.y 2317/9999] lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions
2023-08-01 20:15 ` Nick Desaulniers
2023-08-01 20:26 ` Nathan Chancellor
@ 2023-08-01 20:27 ` Florian Fainelli
1 sibling, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2023-08-01 20:27 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Fangrui Song, llvm, oe-kbuild-all, Greg Kroah-Hartman,
Nathan Chancellor, Masahiro Yamada, kernel test robot
On 8/1/23 13:15, Nick Desaulniers wrote:
> On Sun, Jul 30, 2023 at 8:57 PM kernel test robot <lkp@intel.com> wrote:
>>
>> Hi Fangrui,
>>
>> First bad commit (maybe != root cause):
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y
>> head: 767049cead76cf699707290d5aeefb3e4d0d5b43
>> commit: 69c122751164c3c343eea205fd5c3e1d5132f967 [2317/9999] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation
>
> These aren't a result of Fangrui's change. Fangrui's change probably
> allows this config to mostly build, modulo the below error in
> lib/mpi/generic_mpih-mul2.c.
>
>> config: mips-randconfig-r036-20230731 (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/config)
>> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
>> reproduce: (https://download.01.org/0day-ci/archive/20230731/202307311111.jPEdYIJR-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202307311111.jPEdYIJR-lkp@intel.com/
>>
>> All error/warnings (new ones prefixed by >>):
>>
>>>> drivers/net/netdevsim/netdev.c:167:35: warning: unused variable 'nsim_switchdev_ops' [-Wunused-const-variable]
>> 167 | static const struct switchdev_ops nsim_switchdev_ops = {
>> | ^
>> 1 warning generated.
>
> ^ fixed by
> commit e58df56c8564 ("netdevsim: Implement ndo_get_port_parent_id()")
> in v5.1-rc1 (this report is against 4.19.y)
> Florian, does it make sense for the stable maintainers to cherry-pick
> e58df56c8564 to 4.19.y in isolation?
In isolation no, because you will get a build failure because
netdevice_ops has no ndo_get_port_parent_id member. The complete patch
set was 12 patches:
https://lore.kernel.org/all/20190205235326.14600-1-f.fainelli@gmail.com/
which is too big for a stable candidate. IMHO the simplest way is to
mark the structure as __maybe_unused since this configured has
CONFIG_NET_SWITCHDEV=n presumably?
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-16 16:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-31 3:56 [stable:linux-4.19.y 2317/9999] lib/mpi/generic_mpih-mul2.c:49:24: error: invalid use of a cast in a inline asm context requiring an lvalue: remove the cast or build with -fheinous-gnu-extensions kernel test robot
2023-08-01 20:15 ` Nick Desaulniers
2023-08-01 20:26 ` Nathan Chancellor
2023-08-16 16:16 ` Greg Kroah-Hartman
2023-08-01 20:27 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox