Re: [PATCH v7 7/7] nvmem: core: Expose cells through sysfs

Re: [PATCH v7 7/7] nvmem: core: Expose cells through sysfs

[kernel test robot]

Hi Miquel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.5-rc4 next-20230801]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Miquel-Raynal/nvmem-core-Create-all-cells-before-adding-the-nvmem-device/20230802-022331
base:   char-misc/char-misc-testing
patch link:    https://lore.kernel.org/r/20230801182132.1058707-8-miquel.raynal%40bootlin.com
patch subject: [PATCH v7 7/7] nvmem: core: Expose cells through sysfs
config: x86_64-randconfig-x005-20230731 (https://download.01.org/0day-ci/archive/20230802/202308021505.FG8g7tZG-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230802/202308021505.FG8g7tZG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308021505.FG8g7tZG-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/nvmem/core.c:2264:1: warning: unused label 'del_cells' [-Wunused-label]
   del_cells:
   ^~~~~~~~~~
   1 warning generated.


vim +/del_cells +2264 drivers/nvmem/core.c

  2261	
  2262		return 0;
  2263	
> 2264	del_cells:
  2265		nvmem_device_remove_all_cells(nvmem);
  2266	put_layout:
  2267		nvmem_layout_put(nvmem->layout);
  2268		return ret;
  2269	}
  2270	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH v7 7/7] nvmem: core: Expose cells through sysfs

[Miquel Raynal]

Hello,

lkp@intel.com wrote on Wed, 2 Aug 2023 15:40:10 +0800:

> Hi Miquel,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on char-misc/char-misc-testing]
> [also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.5-rc4 next-20230801]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Miquel-Raynal/nvmem-core-Create-all-cells-before-adding-the-nvmem-device/20230802-022331
> base:   char-misc/char-misc-testing
> patch link:    https://lore.kernel.org/r/20230801182132.1058707-8-miquel.raynal%40bootlin.com
> patch subject: [PATCH v7 7/7] nvmem: core: Expose cells through sysfs
> config: x86_64-randconfig-x005-20230731 (https://download.01.org/0day-ci/archive/20230802/202308021505.FG8g7tZG-lkp@intel.com/config)
> compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
> reproduce: (https://download.01.org/0day-ci/archive/20230802/202308021505.FG8g7tZG-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308021505.FG8g7tZG-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/nvmem/core.c:2264:1: warning: unused label 'del_cells' [-Wunused-label]  
>    del_cells:
>    ^~~~~~~~~~
>    1 warning generated.

This warning triggers with CONFIG_NVMEM_SYSFS=n, I'll fix that.
I'll wait a bit anyway to get some feedback about the new approach.

> 
> 
> vim +/del_cells +2264 drivers/nvmem/core.c
> 
>   2261	
>   2262		return 0;
>   2263	
> > 2264	del_cells:  
>   2265		nvmem_device_remove_all_cells(nvmem);
>   2266	put_layout:
>   2267		nvmem_layout_put(nvmem->layout);
>   2268		return ret;
>   2269	}
>   2270	
> 


Thanks,
Miquèl