Re: [PATCH] media: mediatek: vcodec: Consider vdecsys presence in reg range check

Re: [PATCH] media: mediatek: vcodec: Consider vdecsys presence in reg range check

[kernel test robot]

Hi Nícolas,

kernel test robot noticed the following build errors:

[auto build test ERROR on v6.5-rc6]
[also build test ERROR on linus/master]
[cannot apply to media-tree/master next-20230816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/N-colas-F-R-A-Prado/media-mediatek-vcodec-Consider-vdecsys-presence-in-reg-range-check/20230816-145454
base:   v6.5-rc6
patch link:    https://lore.kernel.org/r/20230725204043.569799-1-nfraprado%40collabora.com
patch subject: [PATCH] media: mediatek: vcodec: Consider vdecsys presence in reg range check
config: arm64-randconfig-r014-20230816 (https://download.01.org/0day-ci/archive/20230816/202308161708.NEoSnIHR-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230816/202308161708.NEoSnIHR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308161708.NEoSnIHR-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c:90:8: error: use of undeclared identifier 'has_vdecsys_reg'
      90 |             (!has_vdecsys_reg && reg_num > NUM_MAX_VDEC_REG_BASE - 1)) {
         |               ^
   1 error generated.


vim +/has_vdecsys_reg +90 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c

    80	
    81	static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev)
    82	{
    83		struct platform_device *pdev = dev->plat_dev;
    84		int reg_num, i;
    85	
    86		/* Sizeof(u32) * 4 bytes for each register base. */
    87		reg_num = of_property_count_elems_of_size(pdev->dev.of_node, "reg",
    88							  sizeof(u32) * 4);
    89		if (reg_num <= 0 || reg_num > NUM_MAX_VDEC_REG_BASE ||
  > 90		    (!has_vdecsys_reg && reg_num > NUM_MAX_VDEC_REG_BASE - 1)) {
    91			dev_err(&pdev->dev, "Invalid register property size: %d\n", reg_num);
    92			return -EINVAL;
    93		}
    94	
    95		for (i = 0; i < reg_num; i++) {
    96			dev->reg_base[i] = devm_platform_ioremap_resource(pdev, i);
    97			if (IS_ERR(dev->reg_base[i]))
    98				return PTR_ERR(dev->reg_base[i]);
    99	
   100			mtk_v4l2_debug(2, "reg[%d] base=%p", i, dev->reg_base[i]);
   101		}
   102	
   103		return 0;
   104	}
   105	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki