From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1189AEA0; Fri, 8 Sep 2023 01:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694137248; x=1725673248; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=worUBMND55vJNbyBeHPqUxOWqBelkEKW/vFbtwAy0vY=; b=R2kVjlKDCmofC1nIM/MYRxvIEStvlgyloHK9nI8Q/QDvLz7ZYuHdQipH +jUWccyxqq8I1tx5f73IhD1qoM0SbpyXxI09i0N4WQc8p7iFNaii8wxoS bu+iEPHJ9tDXNY23IZg4JQBg/DioOTkQulet4bWIl2GWOsqGF+ZrJn0nl WVdo5s6tzpkUzinV301DM4sI1vyPs5xFjEqHu/2/H9QDoliMMogSJ/i18 IteAgNek8GmyDlv5Nf66lodKQnDLsK2bdsRDP/MqGoLpJ3SSonOTxtfYL dhkved3Et98xnK6LXcb/U3GDEwT/jB41evQX4YiZEXzYZudEtAAmWuKfr g==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="380261304" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="380261304" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 18:40:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="807771527" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="807771527" Received: from lkp-server01.sh.intel.com (HELO 59b3c6e06877) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 07 Sep 2023 18:40:43 -0700 Received: from kbuild by 59b3c6e06877 with local (Exim 4.96) (envelope-from ) id 1qeQUD-0001nh-0N; Fri, 08 Sep 2023 01:40:41 +0000 Date: Fri, 8 Sep 2023 09:40:36 +0800 From: kernel test robot To: Kyle Zeng , Paolo Abeni , dsahern@kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, davem@davemloft.net, netdev@vger.kernel.org, ssuryaextr@gmail.com Subject: Re: [PATCH] fix null-deref in ipv4_link_failure Message-ID: <202309080905.JnJFQ6YN-lkp@intel.com> References: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Kyle, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.5 next-20230907] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kyle-Zeng/fix-null-deref-in-ipv4_link_failure/20230908-065510 base: linus/master patch link: https://lore.kernel.org/r/ZPpUfm%2FHhFet3ejH%40westworld patch subject: [PATCH] fix null-deref in ipv4_link_failure config: um-allnoconfig (https://download.01.org/0day-ci/archive/20230908/202309080905.JnJFQ6YN-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230908/202309080905.JnJFQ6YN-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309080905.JnJFQ6YN-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from net/ipv4/route.c:67: In file included from include/linux/memblock.h:13: In file included from arch/um/include/asm/dma.h:5: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 547 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from net/ipv4/route.c:67: In file included from include/linux/memblock.h:13: In file included from arch/um/include/asm/dma.h:5: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from net/ipv4/route.c:67: In file included from include/linux/memblock.h:13: In file included from arch/um/include/asm/dma.h:5: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 584 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 692 | readsb(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 700 | readsw(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 708 | readsl(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 717 | writesb(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 726 | writesw(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 735 | writesl(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ net/ipv4/route.c:880:6: warning: variable 'log_martians' set but not used [-Wunused-but-set-variable] 880 | int log_martians; | ^ >> net/ipv4/route.c:1235:38: error: use of undeclared identifier 'net' 1235 | res = __ip_options_compile(dev_net(net), &opt, skb, NULL); | ^ 13 warnings and 1 error generated. vim +/net +1235 net/ipv4/route.c 1213 1214 static void ipv4_send_dest_unreach(struct sk_buff *skb) 1215 { 1216 struct ip_options opt; 1217 int res; 1218 struct net_device *dev; 1219 1220 /* Recompile ip options since IPCB may not be valid anymore. 1221 * Also check we have a reasonable ipv4 header. 1222 */ 1223 if (!pskb_network_may_pull(skb, sizeof(struct iphdr)) || 1224 ip_hdr(skb)->version != 4 || ip_hdr(skb)->ihl < 5) 1225 return; 1226 1227 memset(&opt, 0, sizeof(opt)); 1228 if (ip_hdr(skb)->ihl > 5) { 1229 if (!pskb_network_may_pull(skb, ip_hdr(skb)->ihl * 4)) 1230 return; 1231 opt.optlen = ip_hdr(skb)->ihl * 4 - sizeof(struct iphdr); 1232 1233 rcu_read_lock(); 1234 dev = skb->dev ? skb->dev : skb_rtable(skb)->dst.dev; > 1235 res = __ip_options_compile(dev_net(net), &opt, skb, NULL); 1236 rcu_read_unlock(); 1237 1238 if (res) 1239 return; 1240 } 1241 __icmp_send(skb, ICMP_DEST_UNREACH, ICMP_HOST_UNREACH, 0, &opt); 1242 } 1243 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki