From: kernel test robot <lkp@intel.com>
To: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH net-next 5/6] microchip: lan865x: add driver support for Microchip's LAN865X MACPHY
Date: Tue, 12 Sep 2023 06:40:21 +0800 [thread overview]
Message-ID: <202309120628.2Mkm0paw-lkp@intel.com> (raw)
In-Reply-To: <20230908142919.14849-6-Parthiban.Veerasooran@microchip.com>
Hi Parthiban,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Parthiban-Veerasooran/net-ethernet-implement-OPEN-Alliance-control-transaction-interface/20230908-224352
base: net-next/main
patch link: https://lore.kernel.org/r/20230908142919.14849-6-Parthiban.Veerasooran%40microchip.com
patch subject: [RFC PATCH net-next 5/6] microchip: lan865x: add driver support for Microchip's LAN865X MACPHY
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230912/202309120628.2Mkm0paw-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309120628.2Mkm0paw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309120628.2Mkm0paw-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/microchip/../oa_tc6.c:133:5: warning: no previous prototype for function 'oa_tc6_perform_ctrl' [-Wmissing-prototypes]
int oa_tc6_perform_ctrl(struct oa_tc6 *tc6, u32 addr, u32 val[], u8 len,
^
drivers/net/ethernet/microchip/../oa_tc6.c:133:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int oa_tc6_perform_ctrl(struct oa_tc6 *tc6, u32 addr, u32 val[], u8 len,
^
static
1 warning generated.
vim +/oa_tc6_perform_ctrl +133 drivers/net/ethernet/microchip/../oa_tc6.c
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 132
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 @133 int oa_tc6_perform_ctrl(struct oa_tc6 *tc6, u32 addr, u32 val[], u8 len,
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 134 bool wnr, bool ctrl_prot)
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 135 {
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 136 u8 *tx_buf;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 137 u8 *rx_buf;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 138 u16 size;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 139 u16 pos;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 140 int ret;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 141
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 142 if (ctrl_prot)
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 143 size = (TC6_HDR_SIZE * 2) + (len * (TC6_HDR_SIZE * 2));
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 144 else
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 145 size = (TC6_HDR_SIZE * 2) + (len * TC6_HDR_SIZE);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 146
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 147 tx_buf = kzalloc(size, GFP_KERNEL);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 148 if (!tx_buf)
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 149 return -ENOMEM;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 150
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 151 rx_buf = kzalloc(size, GFP_KERNEL);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 152 if (!rx_buf) {
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 153 ret = -ENOMEM;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 154 goto err_rx_buf_kzalloc;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 155 }
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 156
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 157 /* Prepare control command */
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 158 oa_tc6_prepare_ctrl_buf(tc6, addr, val, len, wnr, tx_buf, ctrl_prot);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 159
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 160 /* Perform SPI transfer */
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 161 ret = oa_tc6_spi_transfer(tc6->spi, tx_buf, rx_buf, size);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 162 if (ret)
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 163 goto err_ctrl;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 164
2dc8ae856934a3 Parthiban Veerasooran 2023-09-08 165 /* In case of reset write, the echoed control command doesn't have any
2dc8ae856934a3 Parthiban Veerasooran 2023-09-08 166 * valid data. So no need to check for error.
2dc8ae856934a3 Parthiban Veerasooran 2023-09-08 167 */
2dc8ae856934a3 Parthiban Veerasooran 2023-09-08 168 if (addr != OA_TC6_RESET) {
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 169 /* Check echoed/received control reply */
2dc8ae856934a3 Parthiban Veerasooran 2023-09-08 170 ret = oa_tc6_check_control(tc6, tx_buf, rx_buf, len, wnr,
2dc8ae856934a3 Parthiban Veerasooran 2023-09-08 171 ctrl_prot);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 172 if (ret)
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 173 goto err_ctrl;
2dc8ae856934a3 Parthiban Veerasooran 2023-09-08 174 }
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 175
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 176 if (!wnr) {
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 177 /* Copy read data from the rx data in case of ctrl read */
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 178 for (u8 i = 0; i < len; i++) {
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 179 if (!ctrl_prot) {
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 180 pos = (TC6_HDR_SIZE * 2) + (i * TC6_HDR_SIZE);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 181 val[i] = be32_to_cpu(*(u32 *)&rx_buf[pos]);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 182 } else {
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 183 pos = (TC6_HDR_SIZE * 2) +
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 184 (i * (TC6_HDR_SIZE * 2));
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 185 val[i] = be32_to_cpu(*(u32 *)&rx_buf[pos]);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 186 }
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 187 }
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 188 }
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 189
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 190 err_ctrl:
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 191 kfree(rx_buf);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 192 err_rx_buf_kzalloc:
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 193 kfree(tx_buf);
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 194 return ret;
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 195 }
9c44fe1a3412d9 Parthiban Veerasooran 2023-09-08 196
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2023-09-11 22:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230908142919.14849-6-Parthiban.Veerasooran@microchip.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309120628.2Mkm0paw-lkp@intel.com \
--to=lkp@intel.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox