Re: [PATCH v2 09/10] hwrng: stm32 - rework power management sequences

Re: [PATCH v2 09/10] hwrng: stm32 - rework power management sequences

[kernel test robot]

Hi Gatien,

kernel test robot noticed the following build warnings:

[auto build test WARNING on atorgue-stm32/stm32-next]
[also build test WARNING on robh/for-next herbert-crypto-2.6/master herbert-cryptodev-2.6/master linus/master v6.6-rc1 next-20230912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gatien-Chevallier/dt-bindings-rng-introduce-new-compatible-for-STM32MP13x/20230912-051851
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link:    https://lore.kernel.org/r/20230911120203.774632-10-gatien.chevallier%40foss.st.com
patch subject: [PATCH v2 09/10] hwrng: stm32 - rework power management sequences
config: arm64-randconfig-r003-20230912 (https://download.01.org/0day-ci/archive/20230912/202309122017.GsJspucF-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309122017.GsJspucF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309122017.GsJspucF-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/char/hw_random/stm32-rng.c:472:21: warning: attribute declaration must precede definition [-Wignored-attributes]
     472 | static const struct __maybe_unused dev_pm_ops stm32_rng_pm_ops = {
         |                     ^
   include/linux/compiler_attributes.h:344:56: note: expanded from macro '__maybe_unused'
     344 | #define __maybe_unused                  __attribute__((__unused__))
         |                                                        ^
   include/linux/pm.h:286:8: note: previous definition is here
     286 | struct dev_pm_ops {
         |        ^
   1 warning generated.


vim +472 drivers/char/hw_random/stm32-rng.c

   471	
 > 472	static const struct __maybe_unused dev_pm_ops stm32_rng_pm_ops = {
   473		SET_RUNTIME_PM_OPS(stm32_rng_runtime_suspend,
   474				   stm32_rng_runtime_resume, NULL)
   475		SET_SYSTEM_SLEEP_PM_OPS(stm32_rng_suspend,
   476					stm32_rng_resume)
   477	};
   478	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki