Re: [RFC bpf-next v3 07/11] bpf, net: switch to storing struct_ops in btf

Re: [RFC bpf-next v3 07/11] bpf, net: switch to storing struct_ops in btf

[kernel test robot]

Hi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/thinker-li-gmail-com/bpf-refactory-struct_ops-type-initialization-to-a-function/20230921-000546
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230920155923.151136-8-thinker.li%40gmail.com
patch subject: [RFC bpf-next v3 07/11] bpf, net: switch to storing struct_ops in btf
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230924/202309241144.PiijQmZj-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230924/202309241144.PiijQmZj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309241144.PiijQmZj-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> net/ipv4/bpf_tcp_ca.c:300:15: error: call to undeclared function 'register_bpf_struct_ops'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           ret = ret ?: register_bpf_struct_ops(&bpf_tcp_ca_ops_mod);
                        ^
   1 error generated.
--
>> kernel/bpf/bpf_struct_ops.c:252:8: error: call to undeclared function 'register_bpf_struct_ops'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           ret = register_bpf_struct_ops(&bpf_testmod_struct_ops);
                 ^
>> kernel/bpf/bpf_struct_ops.c:258:5: warning: no previous prototype for function 'register_bpf_struct_ops' [-Wmissing-prototypes]
   int register_bpf_struct_ops(struct bpf_struct_ops_mod *mod)
       ^
   kernel/bpf/bpf_struct_ops.c:258:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int register_bpf_struct_ops(struct bpf_struct_ops_mod *mod)
   ^
   static 
   1 warning and 1 error generated.


vim +/register_bpf_struct_ops +300 net/ipv4/bpf_tcp_ca.c

   292	
   293	static int __init bpf_tcp_ca_kfunc_init(void)
   294	{
   295		int ret;
   296	
   297		BTF_STRUCT_OPS_TYPE_EMIT(tcp_congestion_ops);
   298	
   299		ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_STRUCT_OPS, &bpf_tcp_ca_kfunc_set);
 > 300		ret = ret ?: register_bpf_struct_ops(&bpf_tcp_ca_ops_mod);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki