* Re: [PATCH v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind [not found] <20230928103227.250550-1-ruansy.fnst@fujitsu.com> @ 2023-10-01 1:43 ` kernel test robot 2023-10-02 11:57 ` Shiyang Ruan 0 siblings, 1 reply; 2+ messages in thread From: kernel test robot @ 2023-10-01 1:43 UTC (permalink / raw) To: Shiyang Ruan, linux-fsdevel, nvdimm, linux-xfs, linux-mm Cc: llvm, oe-kbuild-all, dan.j.williams, willy, jack, akpm, djwong, mcgrof, chandanbabu Hi Shiyang, kernel test robot noticed the following build errors: url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20230928-183310/Shiyang-Ruan/xfs-fix-the-calculation-for-end-and-length/20230629-161913 base: the 2th patch of https://lore.kernel.org/r/20230629081651.253626-3-ruansy.fnst%40fujitsu.com patch link: https://lore.kernel.org/r/20230928103227.250550-1-ruansy.fnst%40fujitsu.com patch subject: [PATCH v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231001/202310010955.feI4HCwZ-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310010955.feI4HCwZ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202310010955.feI4HCwZ-lkp@intel.com/ All errors (new ones prefixed by >>): >> fs/xfs/xfs_notify_failure.c:127:27: error: use of undeclared identifier 'FREEZE_HOLDER_KERNEL' error = freeze_super(sb, FREEZE_HOLDER_KERNEL); ^ fs/xfs/xfs_notify_failure.c:143:26: error: use of undeclared identifier 'FREEZE_HOLDER_KERNEL' error = thaw_super(sb, FREEZE_HOLDER_KERNEL); ^ >> fs/xfs/xfs_notify_failure.c:153:17: error: use of undeclared identifier 'FREEZE_HOLDER_USERSPACE' thaw_super(sb, FREEZE_HOLDER_USERSPACE); ^ 3 errors generated. vim +/FREEZE_HOLDER_KERNEL +127 fs/xfs/xfs_notify_failure.c 119 120 static int 121 xfs_dax_notify_failure_freeze( 122 struct xfs_mount *mp) 123 { 124 struct super_block *sb = mp->m_super; 125 int error; 126 > 127 error = freeze_super(sb, FREEZE_HOLDER_KERNEL); 128 if (error) 129 xfs_emerg(mp, "already frozen by kernel, err=%d", error); 130 131 return error; 132 } 133 134 static void 135 xfs_dax_notify_failure_thaw( 136 struct xfs_mount *mp, 137 bool kernel_frozen) 138 { 139 struct super_block *sb = mp->m_super; 140 int error; 141 142 if (kernel_frozen) { 143 error = thaw_super(sb, FREEZE_HOLDER_KERNEL); 144 if (error) 145 xfs_emerg(mp, "still frozen after notify failure, err=%d", 146 error); 147 } 148 149 /* 150 * Also thaw userspace call anyway because the device is about to be 151 * removed immediately. 152 */ > 153 thaw_super(sb, FREEZE_HOLDER_USERSPACE); 154 } 155 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind 2023-10-01 1:43 ` [PATCH v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind kernel test robot @ 2023-10-02 11:57 ` Shiyang Ruan 0 siblings, 0 replies; 2+ messages in thread From: Shiyang Ruan @ 2023-10-02 11:57 UTC (permalink / raw) To: kernel test robot Cc: llvm, oe-kbuild-all, dan.j.williams, willy, jack, akpm, djwong, mcgrof, chandanbabu, linux-fsdevel, nvdimm, linux-xfs, linux-mm 在 2023/10/1 9:43, kernel test robot 写道: > Hi Shiyang, > > kernel test robot noticed the following build errors: > > > > url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20230928-183310/Shiyang-Ruan/xfs-fix-the-calculation-for-end-and-length/20230629-161913 > base: the 2th patch of https://lore.kernel.org/r/20230629081651.253626-3-ruansy.fnst%40fujitsu.com > patch link: https://lore.kernel.org/r/20230928103227.250550-1-ruansy.fnst%40fujitsu.com > patch subject: [PATCH v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind > config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231001/202310010955.feI4HCwZ-lkp@intel.com/config) > compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310010955.feI4HCwZ-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202310010955.feI4HCwZ-lkp@intel.com/ > > All errors (new ones prefixed by >>): > >>> fs/xfs/xfs_notify_failure.c:127:27: error: use of undeclared identifier 'FREEZE_HOLDER_KERNEL' > error = freeze_super(sb, FREEZE_HOLDER_KERNEL); > ^ > fs/xfs/xfs_notify_failure.c:143:26: error: use of undeclared identifier 'FREEZE_HOLDER_KERNEL' > error = thaw_super(sb, FREEZE_HOLDER_KERNEL); > ^ >>> fs/xfs/xfs_notify_failure.c:153:17: error: use of undeclared identifier 'FREEZE_HOLDER_USERSPACE' > thaw_super(sb, FREEZE_HOLDER_USERSPACE); > ^ > 3 errors generated. > The two enums has been introduced since 880b9577855e ("fs: distinguish between user initiated freeze and kernel initiated freeze"), v6.6-rc1. I also compiled my patches based on v6.6-rc1 with your config file, it passed with no error. So, which kernel version were you testing? -- Thanks, Ruan. > > vim +/FREEZE_HOLDER_KERNEL +127 fs/xfs/xfs_notify_failure.c > > 119 > 120 static int > 121 xfs_dax_notify_failure_freeze( > 122 struct xfs_mount *mp) > 123 { > 124 struct super_block *sb = mp->m_super; > 125 int error; > 126 > > 127 error = freeze_super(sb, FREEZE_HOLDER_KERNEL); > 128 if (error) > 129 xfs_emerg(mp, "already frozen by kernel, err=%d", error); > 130 > 131 return error; > 132 } > 133 > 134 static void > 135 xfs_dax_notify_failure_thaw( > 136 struct xfs_mount *mp, > 137 bool kernel_frozen) > 138 { > 139 struct super_block *sb = mp->m_super; > 140 int error; > 141 > 142 if (kernel_frozen) { > 143 error = thaw_super(sb, FREEZE_HOLDER_KERNEL); > 144 if (error) > 145 xfs_emerg(mp, "still frozen after notify failure, err=%d", > 146 error); > 147 } > 148 > 149 /* > 150 * Also thaw userspace call anyway because the device is about to be > 151 * removed immediately. > 152 */ > > 153 thaw_super(sb, FREEZE_HOLDER_USERSPACE); > 154 } > 155 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-02 11:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230928103227.250550-1-ruansy.fnst@fujitsu.com>
2023-10-01 1:43 ` [PATCH v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind kernel test robot
2023-10-02 11:57 ` Shiyang Ruan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox