From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AED042C1C for ; Fri, 6 Oct 2023 20:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EsXlfWcD" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3ae65e8eb45so1681911b6e.1 for ; Fri, 06 Oct 2023 13:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696623777; x=1697228577; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=v8kAE0L3XYT2zduhiLheo6/OoQQtkbHtadi2JLu6gYg=; b=EsXlfWcDkF7d8EuSgiFYgTX5HS3WpRXG0NVBIHqMHzpGJ4Mtp+T5U9HbW3dbsa8vEY 1pdQqgDxhQUqucGXeQF5Df+kQkEWulMW93lSWiWjlNAb848+s4u4AC1TWK1lT9HN26GH /nEz9zKoXOSZXAz2Kd4LKq5j5PYgoV6jLPb6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696623777; x=1697228577; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v8kAE0L3XYT2zduhiLheo6/OoQQtkbHtadi2JLu6gYg=; b=h593w4dxpDgifJlvU8kUWXvRLbVvKUtZ5wztBALg7v/ZZbyOOPDazmGyDNlXESrfch vrTzxB2ph42QvphktkUGnPJyGnL5OdATMVbWeabBYUKwJ7OwNVfHKyR3IOt89JpJBYSN N7UG0Lz7rJZ8sD4o7wHaj/LG10YeBm7fUMM9DchpiELoWa9j/iJkuHdn414ucOx3nHrW NlotXTMULU3/xiMkFS3JAtsRS7QkVrhh6cIotlmMo+6vJ46VCYZQUIpnvbUUpKPuQuKL whASV+nTjfeOioJuqXCrZYQszfTX2nQOVAvoKmsftCJo90HGWY/1z7zi5WWydKUyTomG S9kw== X-Gm-Message-State: AOJu0YyV8Gkp3avw6zkNM2Dn2ulP6a9KsrGSdtt4960csqRF+Unco9bA yQ2eRKb2JFJlJRMJSyPdErIgFg== X-Google-Smtp-Source: AGHT+IFJgYFdXQLoiEQmx+lFHyuC0qUrDFQKLIKGfw/wrLmvAN6GJdpM5ZD/9ihDG8TtTiEFnZjYhg== X-Received: by 2002:a05:6358:9691:b0:164:8742:525 with SMTP id o17-20020a056358969100b0016487420525mr1346056rwa.17.1696623777190; Fri, 06 Oct 2023 13:22:57 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 19-20020a17090a1a1300b00273744e6eccsm4271576pjk.12.2023.10.06.13.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 13:22:56 -0700 (PDT) Date: Fri, 6 Oct 2023 13:22:55 -0700 From: Kees Cook To: Martin =?utf-8?Q?Povi=C5=A1er?= , Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , asahi@lists.linux.dev, alsa-devel@alsa-project.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH] ASoC: apple: mca: Annotate struct mca_data with __counted_by Message-ID: <202310061321.E7247C52B@keescook> References: <20230922175050.work.819-kees@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230922175050.work.819-kees@kernel.org> On Fri, Sep 22, 2023 at 10:50:50AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct mca_data. Friendly ping. Mark, can you pick this up please? Thanks! -Kees > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: "Martin PoviĊĦer" > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: asahi@lists.linux.dev > Cc: alsa-devel@alsa-project.org > Signed-off-by: Kees Cook > --- > sound/soc/apple/mca.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c > index ce77934f3eef..99e547ef95e6 100644 > --- a/sound/soc/apple/mca.c > +++ b/sound/soc/apple/mca.c > @@ -161,7 +161,7 @@ struct mca_data { > struct mutex port_mutex; > > int nclusters; > - struct mca_cluster clusters[]; > + struct mca_cluster clusters[] __counted_by(nclusters); > }; > > static void mca_modify(struct mca_cluster *cl, int regoffset, u32 mask, u32 val) > -- > 2.34.1 > -- Kees Cook