From: kernel test robot <lkp@intel.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [linyunsheng:page_frag_unify_rfc 2/4] net/core/skbuff.c:301:15: error: use of undeclared identifier '__napi_alloc_frag_align'; did you mean 'napi_alloc_frag_align'?
Date: Sun, 29 Oct 2023 03:31:53 +0800 [thread overview]
Message-ID: <202310290310.LCXWanPj-lkp@intel.com> (raw)
tree: https://github.com/gestionlin/linux.git page_frag_unify_rfc
head: 7675d2f57391bcfccc739671a7b3b2a40acfc595
commit: 1ec6b07022b1485c830aa4c58fd4154ba67306cf [2/4] mm/page_alloc: modify page_frag_alloc_align() to accept align as an argument
config: um-allnoconfig (https://download.01.org/0day-ci/archive/20231029/202310290310.LCXWanPj-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231029/202310290310.LCXWanPj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310290310.LCXWanPj-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from net/core/skbuff.c:41:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:5:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from net/core/skbuff.c:41:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:5:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from net/core/skbuff.c:41:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:5:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
692 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
700 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
708 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
717 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
726 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
735 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
>> net/core/skbuff.c:301:15: error: use of undeclared identifier '__napi_alloc_frag_align'; did you mean 'napi_alloc_frag_align'?
301 | EXPORT_SYMBOL(__napi_alloc_frag_align);
| ^~~~~~~~~~~~~~~~~~~~~~~
| napi_alloc_frag_align
include/linux/export.h:86:44: note: expanded from macro 'EXPORT_SYMBOL'
86 | #define EXPORT_SYMBOL(sym) _EXPORT_SYMBOL(sym, "")
| ^
include/linux/export.h:83:54: note: expanded from macro '_EXPORT_SYMBOL'
83 | #define _EXPORT_SYMBOL(sym, license) __EXPORT_SYMBOL(sym, license, "")
| ^
include/linux/export.h:74:16: note: expanded from macro '__EXPORT_SYMBOL'
74 | extern typeof(sym) sym; \
| ^
net/core/skbuff.c:293:7: note: 'napi_alloc_frag_align' declared here
293 | void *napi_alloc_frag_align(unsigned int fragsz, unsigned int align)
| ^
>> net/core/skbuff.c:322:15: error: use of undeclared identifier '__netdev_alloc_frag_align'; did you mean 'netdev_alloc_frag_align'?
322 | EXPORT_SYMBOL(__netdev_alloc_frag_align);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| netdev_alloc_frag_align
include/linux/export.h:86:44: note: expanded from macro 'EXPORT_SYMBOL'
86 | #define EXPORT_SYMBOL(sym) _EXPORT_SYMBOL(sym, "")
| ^
include/linux/export.h:83:54: note: expanded from macro '_EXPORT_SYMBOL'
83 | #define _EXPORT_SYMBOL(sym, license) __EXPORT_SYMBOL(sym, license, "")
| ^
include/linux/export.h:74:16: note: expanded from macro '__EXPORT_SYMBOL'
74 | extern typeof(sym) sym; \
| ^
net/core/skbuff.c:303:7: note: 'netdev_alloc_frag_align' declared here
303 | void *netdev_alloc_frag_align(unsigned int fragsz, unsigned int align)
| ^
12 warnings and 2 errors generated.
vim +301 net/core/skbuff.c
dbae2b062824fc Paolo Abeni 2022-09-28 292
1ec6b07022b148 Yunsheng Lin 2023-10-28 293 void *napi_alloc_frag_align(unsigned int fragsz, unsigned int align)
50fad4b543b30e Alexander Lobakin 2021-02-13 294 {
50fad4b543b30e Alexander Lobakin 2021-02-13 295 struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
50fad4b543b30e Alexander Lobakin 2021-02-13 296
50fad4b543b30e Alexander Lobakin 2021-02-13 297 fragsz = SKB_DATA_ALIGN(fragsz);
50fad4b543b30e Alexander Lobakin 2021-02-13 298
1ec6b07022b148 Yunsheng Lin 2023-10-28 299 return page_frag_alloc_align(&nc->page, fragsz, GFP_ATOMIC, align);
50fad4b543b30e Alexander Lobakin 2021-02-13 300 }
50fad4b543b30e Alexander Lobakin 2021-02-13 @301 EXPORT_SYMBOL(__napi_alloc_frag_align);
50fad4b543b30e Alexander Lobakin 2021-02-13 302
1ec6b07022b148 Yunsheng Lin 2023-10-28 303 void *netdev_alloc_frag_align(unsigned int fragsz, unsigned int align)
50fad4b543b30e Alexander Lobakin 2021-02-13 304 {
50fad4b543b30e Alexander Lobakin 2021-02-13 305 void *data;
50fad4b543b30e Alexander Lobakin 2021-02-13 306
50fad4b543b30e Alexander Lobakin 2021-02-13 307 fragsz = SKB_DATA_ALIGN(fragsz);
afa79d08c6c8e1 Changbin Du 2021-08-13 308 if (in_hardirq() || irqs_disabled()) {
32e3573f739209 Yajun Deng 2021-09-14 309 struct page_frag_cache *nc = this_cpu_ptr(&netdev_alloc_cache);
32e3573f739209 Yajun Deng 2021-09-14 310
1ec6b07022b148 Yunsheng Lin 2023-10-28 311 data = page_frag_alloc_align(nc, fragsz, GFP_ATOMIC, align);
50fad4b543b30e Alexander Lobakin 2021-02-13 312 } else {
32e3573f739209 Yajun Deng 2021-09-14 313 struct napi_alloc_cache *nc;
32e3573f739209 Yajun Deng 2021-09-14 314
50fad4b543b30e Alexander Lobakin 2021-02-13 315 local_bh_disable();
32e3573f739209 Yajun Deng 2021-09-14 316 nc = this_cpu_ptr(&napi_alloc_cache);
1ec6b07022b148 Yunsheng Lin 2023-10-28 317 data = page_frag_alloc_align(&nc->page, fragsz, GFP_ATOMIC, align);
50fad4b543b30e Alexander Lobakin 2021-02-13 318 local_bh_enable();
50fad4b543b30e Alexander Lobakin 2021-02-13 319 }
50fad4b543b30e Alexander Lobakin 2021-02-13 320 return data;
50fad4b543b30e Alexander Lobakin 2021-02-13 321 }
50fad4b543b30e Alexander Lobakin 2021-02-13 @322 EXPORT_SYMBOL(__netdev_alloc_frag_align);
50fad4b543b30e Alexander Lobakin 2021-02-13 323
:::::: The code at line 301 was first introduced by commit
:::::: 50fad4b543b30e9323da485d4090c3a94b2b6271 skbuff: move NAPI cache declarations upper in the file
:::::: TO: Alexander Lobakin <alobakin@pm.me>
:::::: CC: David S. Miller <davem@davemloft.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-10-28 19:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310290310.LCXWanPj-lkp@intel.com \
--to=lkp@intel.com \
--cc=linyunsheng@huawei.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox