* Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor [not found] <20231027074545.6055-3-subhajit.ghosh@tweaklogic.com> @ 2023-11-05 14:22 ` kernel test robot 2023-11-06 10:07 ` Andy Shevchenko 0 siblings, 1 reply; 2+ messages in thread From: kernel test robot @ 2023-11-05 14:22 UTC (permalink / raw) To: Subhajit Ghosh, Jonathan Cameron, Lars-Peter Clausen, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matti Vaittinen, Matti Vaittinen, Andy Shevchenko, Paul Gazzillo Cc: llvm, oe-kbuild-all, Subhajit Ghosh, Matt Ranostay, Stefan Windfeldt-Prytz, linux-iio, devicetree, linux-kernel Hi Subhajit, kernel test robot noticed the following build warnings: [auto build test WARNING on 611da07b89fdd53f140d7b33013f255bf0ed8f34] url: https://github.com/intel-lab-lkp/linux/commits/Subhajit-Ghosh/dt-bindings-iio-light-Avago-APDS9306/20231027-154954 base: 611da07b89fdd53f140d7b33013f255bf0ed8f34 patch link: https://lore.kernel.org/r/20231027074545.6055-3-subhajit.ghosh%40tweaklogic.com patch subject: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor config: powerpc64-allyesconfig (https://download.01.org/0day-ci/archive/20231105/202311052102.1GrBH0gk-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311052102.1GrBH0gk-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311052102.1GrBH0gk-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/iio/light/apds9306.c:598:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] 598 | return ret; | ^~~ drivers/iio/light/apds9306.c:593:9: note: initialize the variable 'ret' to silence this warning 593 | int ret, intg_old, gain_old, gain_new, gain_new_closest; | ^ | = 0 1 warning generated. vim +/ret +598 drivers/iio/light/apds9306.c 589 590 static int apds9306_intg_time_set(struct apds9306_data *data, int val2) 591 { 592 struct device *dev = data->dev; 593 int ret, intg_old, gain_old, gain_new, gain_new_closest; 594 bool ok; 595 596 if (!iio_gts_valid_time(&data->gts, val2)) { 597 dev_err(dev, "Unsupported integration time %u\n", val2); > 598 return ret; 599 } 600 601 intg_old = iio_gts_find_int_time_by_sel(&data->gts, 602 data->intg_time_idx); 603 if (ret < 0) 604 return ret; 605 606 if (intg_old == val2) 607 return 0; 608 609 gain_old = iio_gts_find_gain_by_sel(&data->gts, data->gain_idx); 610 if (gain_old < 0) 611 return gain_old; 612 613 ret = iio_gts_find_new_gain_by_old_gain_time(&data->gts, gain_old, 614 intg_old, val2, &gain_new); 615 if (gain_new < 0) { 616 dev_err(dev, "Unsupported gain with time\n"); 617 return gain_new; 618 } 619 620 gain_new_closest = iio_find_closest_gain_low(&data->gts, gain_new, &ok); 621 if (gain_new_closest < 0) { 622 gain_new_closest = iio_gts_get_min_gain(&data->gts); 623 if (gain_new_closest < 0) 624 return gain_new_closest < 0; 625 } 626 if (!ok) 627 dev_dbg(dev, "Unable to find optimum gain, setting minimum"); 628 629 ret = iio_gts_find_sel_by_int_time(&data->gts, val2); 630 if (ret < 0) 631 return ret; 632 633 ret = apds9306_intg_time_set_hw(data, ret); 634 if (ret) 635 return ret; 636 637 ret = iio_gts_find_sel_by_gain(&data->gts, gain_new_closest); 638 if (ret < 0) 639 return ret; 640 641 return apds9306_gain_set_hw(data, ret); 642 } 643 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor 2023-11-05 14:22 ` [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor kernel test robot @ 2023-11-06 10:07 ` Andy Shevchenko 0 siblings, 0 replies; 2+ messages in thread From: Andy Shevchenko @ 2023-11-06 10:07 UTC (permalink / raw) To: kernel test robot Cc: Subhajit Ghosh, Jonathan Cameron, Lars-Peter Clausen, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matti Vaittinen, Matti Vaittinen, Paul Gazzillo, llvm, oe-kbuild-all, Matt Ranostay, Stefan Windfeldt-Prytz, linux-iio, devicetree, linux-kernel On Sun, Nov 05, 2023 at 10:22:07PM +0800, kernel test robot wrote: > >> drivers/iio/light/apds9306.c:598:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] > 598 | return ret; > | ^~~ > drivers/iio/light/apds9306.c:593:9: note: initialize the variable 'ret' to silence this warning > 593 | int ret, intg_old, gain_old, gain_new, gain_new_closest; > | ^ > | = 0 > 1 warning generated. Bad advice, just use correct error code instead of ret. > 590 static int apds9306_intg_time_set(struct apds9306_data *data, int val2) > 591 { > 592 struct device *dev = data->dev; > 593 int ret, intg_old, gain_old, gain_new, gain_new_closest; > 594 bool ok; > 595 > 596 if (!iio_gts_valid_time(&data->gts, val2)) { > 597 dev_err(dev, "Unsupported integration time %u\n", val2); > > 598 return ret; > 599 } > 600 > 601 intg_old = iio_gts_find_int_time_by_sel(&data->gts, > 602 data->intg_time_idx); > 603 if (ret < 0) > 604 return ret; > 605 > 606 if (intg_old == val2) > 607 return 0; > 608 > 609 gain_old = iio_gts_find_gain_by_sel(&data->gts, data->gain_idx); > 610 if (gain_old < 0) > 611 return gain_old; > 612 > 613 ret = iio_gts_find_new_gain_by_old_gain_time(&data->gts, gain_old, > 614 intg_old, val2, &gain_new); > 615 if (gain_new < 0) { > 616 dev_err(dev, "Unsupported gain with time\n"); > 617 return gain_new; > 618 } > 619 > 620 gain_new_closest = iio_find_closest_gain_low(&data->gts, gain_new, &ok); > 621 if (gain_new_closest < 0) { > 622 gain_new_closest = iio_gts_get_min_gain(&data->gts); > 623 if (gain_new_closest < 0) > 624 return gain_new_closest < 0; > 625 } > 626 if (!ok) > 627 dev_dbg(dev, "Unable to find optimum gain, setting minimum"); > 628 > 629 ret = iio_gts_find_sel_by_int_time(&data->gts, val2); > 630 if (ret < 0) > 631 return ret; > 632 > 633 ret = apds9306_intg_time_set_hw(data, ret); > 634 if (ret) > 635 return ret; > 636 > 637 ret = iio_gts_find_sel_by_gain(&data->gts, gain_new_closest); > 638 if (ret < 0) > 639 return ret; > 640 > 641 return apds9306_gain_set_hw(data, ret); > 642 } -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-06 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231027074545.6055-3-subhajit.ghosh@tweaklogic.com>
2023-11-05 14:22 ` [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor kernel test robot
2023-11-06 10:07 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox