* Re: [PATCH v1 2/2] scsi: ufs: core: Add sysfs node for UFS RTC update
[not found] <20231109125217.185462-3-beanhuo@iokpp.de>
@ 2023-11-12 2:02 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-11-12 2:02 UTC (permalink / raw)
To: Bean Huo, avri.altman, bvanassche, alim.akhtar, jejb,
martin.petersen, stanley.chu, mani, quic_cang, quic_asutoshd,
beanhuo
Cc: llvm, oe-kbuild-all, linux-scsi, linux-kernel, mikebi, lporzio
Hi Bean,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.6 next-20231110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bean-Huo/scsi-ufs-core-Add-UFS-RTC-support/20231110-051048
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20231109125217.185462-3-beanhuo%40iokpp.de
patch subject: [PATCH v1 2/2] scsi: ufs: core: Add sysfs node for UFS RTC update
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20231112/202311120923.S1Zbpb0s-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231112/202311120923.S1Zbpb0s-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311120923.S1Zbpb0s-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/ufs/core/ufs-sysfs.c:276:6: warning: variable 'resume_period_update' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
276 | if (!hba->dev_info.rtc_update_period && ms > 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ufs/core/ufs-sysfs.c:281:6: note: uninitialized use occurs here
281 | if (resume_period_update)
| ^~~~~~~~~~~~~~~~~~~~
drivers/ufs/core/ufs-sysfs.c:276:2: note: remove the 'if' if its condition is always true
276 | if (!hba->dev_info.rtc_update_period && ms > 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
277 | resume_period_update = true;
| ~~~~~~~~~~~~~~~~
>> drivers/ufs/core/ufs-sysfs.c:276:6: warning: variable 'resume_period_update' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
276 | if (!hba->dev_info.rtc_update_period && ms > 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ufs/core/ufs-sysfs.c:281:6: note: uninitialized use occurs here
281 | if (resume_period_update)
| ^~~~~~~~~~~~~~~~~~~~
drivers/ufs/core/ufs-sysfs.c:276:6: note: remove the '&&' if its condition is always true
276 | if (!hba->dev_info.rtc_update_period && ms > 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ufs/core/ufs-sysfs.c:271:27: note: initialize the variable 'resume_period_update' to silence this warning
271 | bool resume_period_update;
| ^
| = 0
2 warnings generated.
vim +276 drivers/ufs/core/ufs-sysfs.c
265
266 static ssize_t rtc_update_ms_store(struct device *dev, struct device_attribute *attr,
267 const char *buf, size_t count)
268 {
269 struct ufs_hba *hba = dev_get_drvdata(dev);
270 unsigned int ms;
271 bool resume_period_update;
272
273 if (kstrtouint(buf, 0, &ms))
274 return -EINVAL;
275
> 276 if (!hba->dev_info.rtc_update_period && ms > 0)
277 resume_period_update = true;
278 /* Minimum and maximum update frequency should be synchronized with all UFS vendors */
279 hba->dev_info.rtc_update_period = ms;
280
281 if (resume_period_update)
282 schedule_delayed_work(&hba->ufs_rtc_delayed_work,
283 msecs_to_jiffies(hba->dev_info.rtc_update_period));
284 return count;
285 }
286
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread