* Re: [PATCH] of/platform: Disable sysfb if a simple-framebuffer node is
[not found] <87a5rj9s37.fsf@minerva.mail-host-address-is-not-set>
@ 2023-11-12 14:41 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-11-12 14:41 UTC (permalink / raw)
To: Javier Martinez Canillas, Andrew Worsley
Cc: llvm, oe-kbuild-all, Thomas Zimmermann, open list,
open list:DRM DRIVER FOR FIRMWARE FRAMEBUFFERS, Maxime Ripard
Hi Javier,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.6 next-20231110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/of-platform-Disable-sysfb-if-a-simple-framebuffer-node-is/20231112-183751
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/87a5rj9s37.fsf%40minerva.mail-host-address-is-not-set
patch subject: [PATCH] of/platform: Disable sysfb if a simple-framebuffer node is
config: arm-versatile_defconfig (https://download.01.org/0day-ci/archive/20231112/202311122208.2emZJrfT-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231112/202311122208.2emZJrfT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311122208.2emZJrfT-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/of/platform.c:635:4: error: call to undeclared function 'sysfb_disable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
635 | sysfb_disable();
| ^
1 error generated.
vim +/sysfb_disable +635 drivers/of/platform.c
545
546 static int __init of_platform_default_populate_init(void)
547 {
548 struct device_node *node;
549
550 device_links_supplier_sync_state_pause();
551
552 if (!of_have_populated_dt())
553 return -ENODEV;
554
555 if (IS_ENABLED(CONFIG_PPC)) {
556 struct device_node *boot_display = NULL;
557 struct platform_device *dev;
558 int display_number = 0;
559 int ret;
560
561 /* Check if we have a MacOS display without a node spec */
562 if (of_property_present(of_chosen, "linux,bootx-noscreen")) {
563 /*
564 * The old code tried to work out which node was the MacOS
565 * display based on the address. I'm dropping that since the
566 * lack of a node spec only happens with old BootX versions
567 * (users can update) and with this code, they'll still get
568 * a display (just not the palette hacks).
569 */
570 dev = platform_device_alloc("bootx-noscreen", 0);
571 if (WARN_ON(!dev))
572 return -ENOMEM;
573 ret = platform_device_add(dev);
574 if (WARN_ON(ret)) {
575 platform_device_put(dev);
576 return ret;
577 }
578 }
579
580 /*
581 * For OF framebuffers, first create the device for the boot display,
582 * then for the other framebuffers. Only fail for the boot display;
583 * ignore errors for the rest.
584 */
585 for_each_node_by_type(node, "display") {
586 if (!of_get_property(node, "linux,opened", NULL) ||
587 !of_get_property(node, "linux,boot-display", NULL))
588 continue;
589 dev = of_platform_device_create(node, "of-display", NULL);
590 of_node_put(node);
591 if (WARN_ON(!dev))
592 return -ENOMEM;
593 boot_display = node;
594 display_number++;
595 break;
596 }
597 for_each_node_by_type(node, "display") {
598 char buf[14];
599 const char *of_display_format = "of-display.%d";
600
601 if (!of_get_property(node, "linux,opened", NULL) || node == boot_display)
602 continue;
603 ret = snprintf(buf, sizeof(buf), of_display_format, display_number++);
604 if (ret < sizeof(buf))
605 of_platform_device_create(node, buf, NULL);
606 }
607
608 } else {
609 /*
610 * Handle certain compatibles explicitly, since we don't want to create
611 * platform_devices for every node in /reserved-memory with a
612 * "compatible",
613 */
614 for_each_matching_node(node, reserved_mem_matches)
615 of_platform_device_create(node, NULL, NULL);
616
617 node = of_find_node_by_path("/firmware");
618 if (node) {
619 of_platform_populate(node, NULL, NULL, NULL);
620 of_node_put(node);
621 }
622
623 node = of_get_compatible_child(of_chosen, "simple-framebuffer");
624 if (node) {
625 /*
626 * Since a "simple-framebuffer" device is already added
627 * here, disable the Generic System Framebuffers (sysfb)
628 * to prevent it from registering another device for the
629 * system framebuffer later (e.g: using the screen_info
630 * data that may had been filled as well).
631 *
632 * This can happen for example on DT systems that do EFI
633 * booting and may provide a GOP table to the EFI stub.
634 */
> 635 sysfb_disable();
636 of_platform_device_create(node, NULL, NULL);
637 of_node_put(node);
638 }
639
640 /* Populate everything else. */
641 of_platform_default_populate(NULL, NULL, NULL);
642 }
643
644 return 0;
645 }
646 arch_initcall_sync(of_platform_default_populate_init);
647
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread