Re: [RFC PATCH net-next v2 06/10] net: ethtool: Introduce a command to list PHYs on an interface

Re: [RFC PATCH net-next v2 06/10] net: ethtool: Introduce a command to list PHYs on an interface

[kernel test robot]

Hi Maxime,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Maxime-Chevallier/net-phy-Introduce-ethernet-link-topology-representation/20231117-234210
base:   net-next/main
patch link:    https://lore.kernel.org/r/20231117162323.626979-7-maxime.chevallier%40bootlin.com
patch subject: [RFC PATCH net-next v2 06/10] net: ethtool: Introduce a command to list PHYs on an interface
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231118/202311181249.7bUVFYez-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231118/202311181249.7bUVFYez-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311181249.7bUVFYez-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/ethtool/phy.c:216:5: warning: no previous prototype for function 'ethnl_phy_dump_one_dev' [-Wmissing-prototypes]
   int ethnl_phy_dump_one_dev(struct sk_buff *skb, struct net_device *dev,
       ^
   net/ethtool/phy.c:216:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int ethnl_phy_dump_one_dev(struct sk_buff *skb, struct net_device *dev,
   ^
   static 
   1 warning generated.


vim +/ethnl_phy_dump_one_dev +216 net/ethtool/phy.c

   215	
 > 216	int ethnl_phy_dump_one_dev(struct sk_buff *skb, struct net_device *dev,
   217				   struct netlink_callback *cb)
   218	{
   219		struct ethnl_phy_dump_ctx *ctx = (void *)cb->ctx;
   220		struct phy_req_info *pri = PHY_REQINFO(&ctx->req_info);
   221		struct phy_device_node *pdn;
   222		unsigned long index = 1;
   223		void *ehdr;
   224		int ret;
   225	
   226		ctx->req_info.dev = dev;
   227	
   228		xa_for_each(&dev->link_topo.phys, index, pdn) {
   229			ehdr = ethnl_dump_put(skb, cb,
   230					      ETHTOOL_MSG_PHY_GET_REPLY);
   231			if (!ehdr) {
   232				ret = -EMSGSIZE;
   233				break;
   234			}
   235	
   236			ret = ethnl_fill_reply_header(skb, dev,
   237						      ETHTOOL_A_PHY_HEADER);
   238			if (ret < 0) {
   239				genlmsg_cancel(skb, ehdr);
   240				break;
   241			}
   242	
   243			memcpy(&pri->pdn, pdn, sizeof(*pdn));
   244			ret = ethnl_phy_fill_reply(&ctx->req_info, skb);
   245	
   246			genlmsg_end(skb, ehdr);
   247		}
   248	
   249		ctx->req_info.dev = NULL;
   250	
   251		return ret;
   252	}
   253	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki