Re: [PATCH] [RFC] gpio: adv-pcie-1761h: Add Advantech PCIe-1761H support

Re: [PATCH] [RFC] gpio: adv-pcie-1761h: Add Advantech PCIe-1761H support

[kernel test robot]

Hi Christian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.7-rc2 next-20231122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Seiler/gpio-adv-pcie-1761h-Add-Advantech-PCIe-1761H-support/20231120-232211
base:   linus/master
patch link:    https://lore.kernel.org/r/b7e8e35fc4534a2c928853dfacd3d55d88f2033e.camel%40luxflux.de
patch subject: [PATCH] [RFC] gpio: adv-pcie-1761h: Add Advantech PCIe-1761H support
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20231122/202311221945.c0KQRyT3-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/202311221945.c0KQRyT3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311221945.c0KQRyT3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpio/gpio-adv-pcie-1761h.c:374:13: warning: no previous prototype for function 'adv_pcie_1761h_irq_handler' [-Wmissing-prototypes]
   irqreturn_t adv_pcie_1761h_irq_handler(int irq, void *data)
               ^
   drivers/gpio/gpio-adv-pcie-1761h.c:374:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   irqreturn_t adv_pcie_1761h_irq_handler(int irq, void *data)
   ^
   static 
   1 warning generated.


vim +/adv_pcie_1761h_irq_handler +374 drivers/gpio/gpio-adv-pcie-1761h.c

   373	
 > 374	irqreturn_t adv_pcie_1761h_irq_handler(int irq, void *data)
   375	{
   376		struct adv_pcie_1761h_gpiochip *card = data;
   377		unsigned long pending;
   378	
   379		if (card == NULL)
   380			return IRQ_HANDLED;
   381	
   382		/* Read out which lines were set */
   383		raw_spin_lock(&card->lock);
   384		pending = ioread32(card->control_regs + PCIE1761H_OFFSET_IRQFLAG);
   385		raw_spin_unlock(&card->lock);
   386	
   387		if (!pending)
   388			return IRQ_NONE;
   389	
   390		for_each_set_bit(irq, &pending, card->chip.ngpio - 8)
   391			generic_handle_domain_irq(card->chip.irq.domain, irq + 8);
   392	
   393		/* Reset the IRQ flags for those lines */
   394		raw_spin_lock(&card->lock);
   395		iowrite32(pending, card->control_regs + PCIE1761H_OFFSET_IRQFLAG);
   396		raw_spin_unlock(&card->lock);
   397	
   398		return IRQ_HANDLED;
   399	}
   400	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] [RFC] gpio: adv-pcie-1761h: Add Advantech PCIe-1761H support

[kernel test robot]

Hi Christian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.7-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Seiler/gpio-adv-pcie-1761h-Add-Advantech-PCIe-1761H-support/20231120-232211
base:   linus/master
patch link:    https://lore.kernel.org/r/b7e8e35fc4534a2c928853dfacd3d55d88f2033e.camel%40luxflux.de
patch subject: [PATCH] [RFC] gpio: adv-pcie-1761h: Add Advantech PCIe-1761H support
config: arm64-randconfig-004-20231124 (https://download.01.org/0day-ci/archive/20231124/202311241249.PCyP5woT-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231124/202311241249.PCyP5woT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311241249.PCyP5woT-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-adv-pcie-1761h.c:374:13: warning: no previous prototype for function 'adv_pcie_1761h_irq_handler' [-Wmissing-prototypes]
     374 | irqreturn_t adv_pcie_1761h_irq_handler(int irq, void *data)
         |             ^
   drivers/gpio/gpio-adv-pcie-1761h.c:374:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     374 | irqreturn_t adv_pcie_1761h_irq_handler(int irq, void *data)
         | ^
         | static 
>> drivers/gpio/gpio-adv-pcie-1761h.c:557:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     557 | module_pci_driver(adv_pcie_1761h_driver);
         | ^
         | int
>> drivers/gpio/gpio-adv-pcie-1761h.c:557:19: error: a parameter list without types is only allowed in a function definition
     557 | module_pci_driver(adv_pcie_1761h_driver);
         |                   ^
   1 warning and 2 errors generated.


vim +/int +557 drivers/gpio/gpio-adv-pcie-1761h.c

   556	
 > 557	module_pci_driver(adv_pcie_1761h_driver);
   558	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki