* Re: [PATCH bpf-next v7 1/3] bpf: make common crypto API for TC/XDP programs
[not found] <20231202010604.1877561-1-vadfed@meta.com>
@ 2023-12-05 20:19 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-12-05 20:19 UTC (permalink / raw)
To: Vadim Fedorenko, Vadim Fedorenko, Jakub Kicinski,
Martin KaFai Lau, Andrii Nakryiko, Alexei Starovoitov,
Mykola Lysenko, Herbert Xu
Cc: llvm, oe-kbuild-all, netdev, linux-crypto, bpf
Hi Vadim,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/bpf-crypto-add-skcipher-to-bpf-crypto/20231202-091254
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20231202010604.1877561-1-vadfed%40meta.com
patch subject: [PATCH bpf-next v7 1/3] bpf: make common crypto API for TC/XDP programs
config: x86_64-buildonly-randconfig-001-20231202 (https://download.01.org/0day-ci/archive/20231206/202312060457.bRXN2xnb-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312060457.bRXN2xnb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312060457.bRXN2xnb-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/bpf/crypto.c:159:6: warning: variable 'ctx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!key) {
^~~~
kernel/bpf/crypto.c:192:6: note: uninitialized use occurs here
if (ctx->tfm)
^~~
kernel/bpf/crypto.c:159:2: note: remove the 'if' if its condition is always false
if (!key) {
^~~~~~~~~~~
kernel/bpf/crypto.c:154:6: warning: variable 'ctx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!key_len) {
^~~~~~~~
kernel/bpf/crypto.c:192:6: note: uninitialized use occurs here
if (ctx->tfm)
^~~
kernel/bpf/crypto.c:154:2: note: remove the 'if' if its condition is always false
if (!key_len) {
^~~~~~~~~~~~~~~
kernel/bpf/crypto.c:148:6: warning: variable 'ctx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (authsize && !type->setauthsize) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/crypto.c:192:6: note: uninitialized use occurs here
if (ctx->tfm)
^~~
kernel/bpf/crypto.c:148:2: note: remove the 'if' if its condition is always false
if (authsize && !type->setauthsize) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/crypto.c:143:6: warning: variable 'ctx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!authsize && type->setauthsize) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/crypto.c:192:6: note: uninitialized use occurs here
if (ctx->tfm)
^~~
kernel/bpf/crypto.c:143:2: note: remove the 'if' if its condition is always false
if (!authsize && type->setauthsize) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/crypto.c:138:6: warning: variable 'ctx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!type->has_algo(algo__str)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/crypto.c:192:6: note: uninitialized use occurs here
if (ctx->tfm)
^~~
kernel/bpf/crypto.c:138:2: note: remove the 'if' if its condition is always false
if (!type->has_algo(algo__str)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/crypto.c:128:28: note: initialize the variable 'ctx' to silence this warning
struct bpf_crypto_ctx *ctx;
^
= NULL
5 warnings generated.
vim +159 kernel/bpf/crypto.c
105
106 /**
107 * bpf_crypto_ctx_create() - Create a mutable BPF crypto context.
108 *
109 * Allocates a crypto context that can be used, acquired, and released by
110 * a BPF program. The crypto context returned by this function must either
111 * be embedded in a map as a kptr, or freed with bpf_crypto_ctx_release().
112 * As crypto API functions use GFP_KERNEL allocations, this function can
113 * only be used in sleepable BPF programs.
114 *
115 * bpf_crypto_ctx_create() allocates memory for crypto context.
116 * It may return NULL if no memory is available.
117 * @type__str: pointer to string representation of crypto type.
118 * @algo__str: pointer to string representation of algorithm.
119 * @pkey: bpf_dynptr which holds cipher key to do crypto.
120 * @err: integer to store error code when NULL is returned
121 */
122 __bpf_kfunc struct bpf_crypto_ctx *
123 bpf_crypto_ctx_create(const char *type__str, const char *algo__str,
124 const struct bpf_dynptr_kern *pkey,
125 unsigned int authsize, int *err)
126 {
127 const struct bpf_crypto_type *type = bpf_crypto_get_type(type__str);
128 struct bpf_crypto_ctx *ctx;
129 const u8 *key;
130 u32 key_len;
131
132 type = bpf_crypto_get_type(type__str);
133 if (IS_ERR(type)) {
134 *err = PTR_ERR(type);
135 return NULL;
136 }
137
138 if (!type->has_algo(algo__str)) {
139 *err = -EOPNOTSUPP;
140 goto err;
141 }
142
143 if (!authsize && type->setauthsize) {
144 *err = -EOPNOTSUPP;
145 goto err;
146 }
147
148 if (authsize && !type->setauthsize) {
149 *err = -EOPNOTSUPP;
150 goto err;
151 }
152
153 key_len = __bpf_dynptr_size(pkey);
154 if (!key_len) {
155 *err = -EINVAL;
156 goto err;
157 }
158 key = __bpf_dynptr_data(pkey, key_len);
> 159 if (!key) {
160 *err = -EINVAL;
161 goto err;
162 }
163
164 ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
165 if (!ctx) {
166 *err = -ENOMEM;
167 goto err;
168 }
169
170 ctx->type = type;
171 ctx->tfm = type->alloc_tfm(algo__str);
172 if (IS_ERR(ctx->tfm)) {
173 *err = PTR_ERR(ctx->tfm);
174 ctx->tfm = NULL;
175 goto err;
176 }
177
178 if (authsize) {
179 *err = type->setauthsize(ctx->tfm, authsize);
180 if (*err)
181 goto err;
182 }
183
184 *err = type->setkey(ctx->tfm, key, key_len);
185 if (*err)
186 goto err;
187
188 refcount_set(&ctx->usage, 1);
189
190 return ctx;
191 err:
192 if (ctx->tfm)
193 type->free_tfm(ctx->tfm);
194 kfree(ctx);
195 module_put(type->owner);
196
197 return NULL;
198 }
199
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread