Re: [PATCH v3 3/7] media: v4l2-subdev: Store frame interval in subdev state

Re: [PATCH v3 3/7] media: v4l2-subdev: Store frame interval in subdev state

[kernel test robot]

Hi Laurent,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bec3db03911bd85da29c1c8ee556162153002c9a]

url:    https://github.com/intel-lab-lkp/linux/commits/Laurent-Pinchart/media-v4l2-subdev-Add-which-field-to-struct-v4l2_subdev_frame_interval/20231205-220946
base:   bec3db03911bd85da29c1c8ee556162153002c9a
patch link:    https://lore.kernel.org/r/20231205140810.22368-3-laurent.pinchart%40ideasonboard.com
patch subject: [PATCH v3 3/7] media: v4l2-subdev: Store frame interval in subdev state
config: arm-aspeed_g4_defconfig (https://download.01.org/0day-ci/archive/20231206/202312061141.SrudvARf-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312061141.SrudvARf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312061141.SrudvARf-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/media/v4l2-core/v4l2-subdev.c:21:
   In file included from include/linux/videodev2.h:61:
   include/uapi/linux/videodev2.h:1809:2: warning: field  within 'struct v4l2_ext_control' is less aligned than 'union v4l2_ext_control::(anonymous at include/uapi/linux/videodev2.h:1809:2)' and is usually due to 'struct v4l2_ext_control' being packed, which can lead to unaligned accesses [-Wunaligned-access]
    1809 |         union {
         |         ^
>> drivers/media/v4l2-core/v4l2-subdev.c:1655:1: warning: no previous prototype for function '__v4l2_subdev_state_get_interval' [-Wmissing-prototypes]
    1655 | __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
         | ^
   drivers/media/v4l2-core/v4l2-subdev.c:1654:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    1654 | struct v4l2_fract *
         | ^
         | static 
   2 warnings generated.


vim +/__v4l2_subdev_state_get_interval +1655 drivers/media/v4l2-core/v4l2-subdev.c

  1653	
  1654	struct v4l2_fract *
> 1655	__v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
  1656					 unsigned int pad, u32 stream)
  1657	{
  1658		struct v4l2_subdev_stream_configs *stream_configs;
  1659		unsigned int i;
  1660	
  1661		if (WARN_ON(!state))
  1662			return NULL;
  1663	
  1664		lockdep_assert_held(state->lock);
  1665	
  1666		if (state->pads) {
  1667			if (stream)
  1668				return NULL;
  1669	
  1670			if (pad >= state->sd->entity.num_pads)
  1671				return NULL;
  1672	
  1673			return &state->pads[pad].interval;
  1674		}
  1675	
  1676		lockdep_assert_held(state->lock);
  1677	
  1678		stream_configs = &state->stream_configs;
  1679	
  1680		for (i = 0; i < stream_configs->num_configs; ++i) {
  1681			if (stream_configs->configs[i].pad == pad &&
  1682			    stream_configs->configs[i].stream == stream)
  1683				return &stream_configs->configs[i].interval;
  1684		}
  1685	
  1686		return NULL;
  1687	}
  1688	EXPORT_SYMBOL_GPL(__v4l2_subdev_state_get_interval);
  1689	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki